[INFO] fetching crate pg_query 5.1.0... [INFO] checking pg_query-5.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pg_query 5.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate pg_query 5.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pg_query 5.1.0 [INFO] finished tweaking crates.io crate pg_query 5.1.0 [INFO] tweaked toml for crates.io crate pg_query 5.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 94 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bindgen v0.66.1 (latest: v0.70.1) [INFO] [stderr] Adding blake2b_simd v0.5.11 (latest: v1.0.2) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding dirs v1.0.5 (latest: v5.0.1) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding multimap v0.8.3 (latest: v0.10.0) [INFO] [stderr] Adding peeking_take_while v0.1.2 (latest: v1.0.0) [INFO] [stderr] Adding prost v0.10.4 (latest: v0.13.2) [INFO] [stderr] Adding prost-build v0.10.4 (latest: v0.13.2) [INFO] [stderr] Adding prost-derive v0.10.1 (latest: v0.13.2) [INFO] [stderr] Adding prost-types v0.10.1 (latest: v0.13.2) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding redox_users v0.3.5 (latest: v0.4.6) [INFO] [stderr] Adding rust-argon2 v0.8.3 (latest: v2.1.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding term v0.5.2 (latest: v1.0.0) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding which v4.4.2 (latest: v6.0.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 677eeaf66690dbb707086c16e662b7d06bace791385caf24870ff9bf2340e2cc [INFO] running `Command { std: "docker" "start" "-a" "677eeaf66690dbb707086c16e662b7d06bace791385caf24870ff9bf2340e2cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "677eeaf66690dbb707086c16e662b7d06bace791385caf24870ff9bf2340e2cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "677eeaf66690dbb707086c16e662b7d06bace791385caf24870ff9bf2340e2cc", kill_on_drop: false }` [INFO] [stdout] 677eeaf66690dbb707086c16e662b7d06bace791385caf24870ff9bf2340e2cc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 152d25da8d421dfbff31e774b8d817dda966e78679211b6ffdab24dbc1077aee [INFO] running `Command { std: "docker" "start" "-a" "152d25da8d421dfbff31e774b8d817dda966e78679211b6ffdab24dbc1077aee", kill_on_drop: false }` [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling cmake v0.1.51 [INFO] [stderr] Compiling bytes v1.7.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling libloading v0.8.5 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling fastrand v2.1.1 [INFO] [stderr] Compiling bindgen v0.66.1 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling multimap v0.8.3 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking easy-parallel v3.3.1 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling tempfile v3.12.0 [INFO] [stderr] Compiling prost-build v0.10.4 [INFO] [stderr] Compiling prost-derive v0.10.1 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling prost v0.10.4 [INFO] [stderr] Compiling prost-types v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling pg_query v5.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Command` and `Stdio` [INFO] [stdout] --> build.rs:8:20 [INFO] [stdout] | [INFO] [stdout] 8 | use std::process::{Command, Stdio}; [INFO] [stdout] | ^^^^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `node_structs::*` [INFO] [stdout] --> src/lib.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | pub use node_structs::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `node_structs::*` [INFO] [stdout] --> src/lib.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | pub use node_structs::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/truncate.rs:235:48 [INFO] [stdout] | [INFO] [stdout] 235 | truncations.retain(|t| t.node.to_enum().unwrap() != node); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/truncate.rs:320:14 [INFO] [stdout] | [INFO] [stdout] 319 | fn dummy_select(target_list: Vec, where_clause: Option>, values_lists: Vec) -> Box { [INFO] [stdout] | ---------------------- ------------------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | Box::new(Node { [INFO] [stdout] | ______________^ [INFO] [stdout] 321 | | node: Some(NodeEnum::SelectStmt(Box::new(protobuf::SelectStmt { [INFO] [stdout] 322 | | distinct_clause: vec![], [INFO] [stdout] 323 | | into_clause: None, [INFO] [stdout] ... | [INFO] [stdout] 342 | | }))), [INFO] [stdout] 343 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/truncate.rs:347:14 [INFO] [stdout] | [INFO] [stdout] 346 | fn dummy_insert(cols: Vec) -> Box { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 347 | Box::new(Node { [INFO] [stdout] | ______________^ [INFO] [stdout] 348 | | node: Some(NodeEnum::InsertStmt(Box::new(protobuf::InsertStmt { [INFO] [stdout] 349 | | relation: Some(protobuf::RangeVar { [INFO] [stdout] 350 | | catalogname: "".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 364 | | }))), [INFO] [stdout] 365 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/truncate.rs:369:14 [INFO] [stdout] | [INFO] [stdout] 368 | fn dummy_update(target_list: Vec) -> Box { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 369 | Box::new(Node { [INFO] [stdout] | ______________^ [INFO] [stdout] 370 | | node: Some(NodeEnum::UpdateStmt(Box::new(protobuf::UpdateStmt { [INFO] [stdout] 371 | | relation: Some(protobuf::RangeVar { [INFO] [stdout] 372 | | catalogname: "".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 385 | | }))), [INFO] [stdout] 386 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/truncate.rs:235:48 [INFO] [stdout] | [INFO] [stdout] 235 | truncations.retain(|t| t.node.to_enum().unwrap() != node); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/truncate.rs:320:14 [INFO] [stdout] | [INFO] [stdout] 319 | fn dummy_select(target_list: Vec, where_clause: Option>, values_lists: Vec) -> Box { [INFO] [stdout] | ---------------------- ------------------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | Box::new(Node { [INFO] [stdout] | ______________^ [INFO] [stdout] 321 | | node: Some(NodeEnum::SelectStmt(Box::new(protobuf::SelectStmt { [INFO] [stdout] 322 | | distinct_clause: vec![], [INFO] [stdout] 323 | | into_clause: None, [INFO] [stdout] ... | [INFO] [stdout] 342 | | }))), [INFO] [stdout] 343 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/truncate.rs:347:14 [INFO] [stdout] | [INFO] [stdout] 346 | fn dummy_insert(cols: Vec) -> Box { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 347 | Box::new(Node { [INFO] [stdout] | ______________^ [INFO] [stdout] 348 | | node: Some(NodeEnum::InsertStmt(Box::new(protobuf::InsertStmt { [INFO] [stdout] 349 | | relation: Some(protobuf::RangeVar { [INFO] [stdout] 350 | | catalogname: "".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 364 | | }))), [INFO] [stdout] 365 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/truncate.rs:369:14 [INFO] [stdout] | [INFO] [stdout] 368 | fn dummy_update(target_list: Vec) -> Box { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 369 | Box::new(Node { [INFO] [stdout] | ______________^ [INFO] [stdout] 370 | | node: Some(NodeEnum::UpdateStmt(Box::new(protobuf::UpdateStmt { [INFO] [stdout] 371 | | relation: Some(protobuf::RangeVar { [INFO] [stdout] 372 | | catalogname: "".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 385 | | }))), [INFO] [stdout] 386 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pg_query` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pg_query` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "152d25da8d421dfbff31e774b8d817dda966e78679211b6ffdab24dbc1077aee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "152d25da8d421dfbff31e774b8d817dda966e78679211b6ffdab24dbc1077aee", kill_on_drop: false }` [INFO] [stdout] 152d25da8d421dfbff31e774b8d817dda966e78679211b6ffdab24dbc1077aee