[INFO] fetching crate pg-trunk 0.12.27... [INFO] checking pg-trunk-0.12.27 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pg-trunk 0.12.27 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate pg-trunk 0.12.27 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pg-trunk 0.12.27 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate pg-trunk 0.12.27 [INFO] tweaked toml for crates.io crate pg-trunk 0.12.27 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate pg-trunk 0.12.27 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4914ddc6e5b3c3a1ce7cf62db2aa1910bac5ec2d245468d0821b459f93560f72 [INFO] running `Command { std: "docker" "start" "-a" "4914ddc6e5b3c3a1ce7cf62db2aa1910bac5ec2d245468d0821b459f93560f72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4914ddc6e5b3c3a1ce7cf62db2aa1910bac5ec2d245468d0821b459f93560f72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4914ddc6e5b3c3a1ce7cf62db2aa1910bac5ec2d245468d0821b459f93560f72", kill_on_drop: false }` [INFO] [stdout] 4914ddc6e5b3c3a1ce7cf62db2aa1910bac5ec2d245468d0821b459f93560f72 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 762f5eedf8bc99dd2c12e236860f80317762e4d90bd913d88260b7b0ad072ae1 [INFO] running `Command { std: "docker" "start" "-a" "762f5eedf8bc99dd2c12e236860f80317762e4d90bd913d88260b7b0ad072ae1", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling fs-err v2.11.0 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking filetime v0.2.24 [INFO] [stderr] Checking os_pipe v1.2.1 [INFO] [stderr] Checking shared_child v1.0.1 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Compiling assert_cmd v2.0.16 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking predicates v3.1.2 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking rustix v0.38.35 [INFO] [stderr] Checking duct v0.13.7 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking read-write-pipe v0.1.0 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking slicedisplay v0.2.2 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking elf v0.7.4 [INFO] [stderr] Checking tee_readwrite v0.1.0 [INFO] [stderr] Checking colorful v0.2.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.15.2+1.6.4 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking which v4.4.2 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking tar v0.4.41 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tokio-task-manager v0.2.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking git2 v0.17.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_with v2.3.3 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking bollard-stubs v1.42.0-rc.7 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking hyperlocal v0.8.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking bollard v0.14.0 [INFO] [stderr] Checking pg-trunk v0.12.27 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `name` and `description` are never read [INFO] [stdout] --> src/commands/publish.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 62 | pub struct Category { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 63 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 64 | pub description: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Category` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `extension_name` is never read [INFO] [stdout] --> src/commands/verify.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct Extension { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 36 | pub extension_name: String, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Extension` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `module_pathname` is never read [INFO] [stdout] --> src/control_file.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct ControlFile { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 8 | pub directory: Option, [INFO] [stdout] 9 | pub module_pathname: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ControlFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `postgres_versions` is never read [INFO] [stdout] --> src/v1.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct TrunkProjectView { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | pub postgres_versions: Option>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TrunkProjectView` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `platform` is never read [INFO] [stdout] --> src/v1.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Download { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pub platform: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Download` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:46:70 [INFO] [stdout] | [INFO] [stdout] 46 | async fn execute(&self, task: Task) -> Result<(), anyhow::Error> { [INFO] [stdout] | _____________________________----------_______________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | | match self { [INFO] [stdout] 48 | | SubCommands::Build(cmd) => cmd.execute(task).await, [INFO] [stdout] 49 | | SubCommands::Publish(cmd) => cmd.execute(task).await, [INFO] [stdout] ... | [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:83:11 [INFO] [stdout] | [INFO] [stdout] 76 | let tm = TaskManager::new(Duration::from_secs(60)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | [INFO] [stdout] 78 | let rt = tokio::runtime::Builder::new_multi_thread() [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | match rt.block_on(async { [INFO] [stdout] | ___________^ [INFO] [stdout] 84 | | let cli = Cli::parse(); [INFO] [stdout] 85 | | let result = cli.command.execute(tm.task()).await; [INFO] [stdout] 86 | | tm.wait().await; [INFO] [stdout] 87 | | result [INFO] [stdout] 88 | | }) { [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/build.rs:194:70 [INFO] [stdout] | [INFO] [stdout] 194 | async fn execute(&self, task: Task) -> Result<(), anyhow::Error> { [INFO] [stdout] | _____________________________----------_______________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | | let build_settings = self.settings()?; [INFO] [stdout] 196 | | info!("Building from path {}", build_settings.path); [INFO] [stdout] 197 | | let path = Path::new(&build_settings.path); [INFO] [stdout] ... | [INFO] [stdout] 308 | | return Ok(()); [INFO] [stdout] 309 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/containers.rs:353:15 [INFO] [stdout] | [INFO] [stdout] 335 | let (receiver, sender, stream) = ByteStreamSyncSender::new(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | let f = || { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | match f() { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/install.rs:145:71 [INFO] [stdout] | [INFO] [stdout] 145 | async fn execute(&self, _task: Task) -> Result<(), anyhow::Error> { [INFO] [stdout] | _____________________________-----------_______________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | | let pg_config = self.pgconfig()?; [INFO] [stdout] 147 | | [INFO] [stdout] 148 | | let package_lib_dir = pg_config.pkglibdir()?; [INFO] [stdout] ... | [INFO] [stdout] 182 | | Ok(()) [INFO] [stdout] 183 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/pgrx.rs:77:30 [INFO] [stdout] | [INFO] [stdout] 77 | .filter_map(|&s| Version::parse(s).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/publish.rs:208:71 [INFO] [stdout] | [INFO] [stdout] 208 | async fn execute(&self, _task: Task) -> Result<(), anyhow::Error> { [INFO] [stdout] | _____________________________-----------_______________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | | let mut publish_settings = self.settings()?; [INFO] [stdout] 210 | | // Validate extension name input [INFO] [stdout] 211 | | let mut slugs = Vec::new(); [INFO] [stdout] ... | [INFO] [stdout] 386 | | Ok(()) [INFO] [stdout] 387 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/verify.rs:128:52 [INFO] [stdout] | [INFO] [stdout] 128 | async fn execute(&self, _: Task) -> Result<()> { [INFO] [stdout] | _____________________________-______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | | let tempdir = TempDir::new()?; [INFO] [stdout] 130 | | // Given an extension name, let's fetch its Trunk project [INFO] [stdout] 131 | | let trunk_project = { [INFO] [stdout] ... | [INFO] [stdout] 201 | | Ok(()) [INFO] [stdout] 202 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trunk_toml.rs:77:18 [INFO] [stdout] | [INFO] [stdout] 72 | extract: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | .or_else(|| maybe_toml.as_ref().map(extract)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trunk_toml.rs:90:18 [INFO] [stdout] | [INFO] [stdout] 85 | extract: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | .or_else(|| maybe_toml.as_ref().map(extract).and_then(Option::as_ref)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pg-trunk` (bin "trunk") due to 11 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `name` and `description` are never read [INFO] [stdout] --> src/commands/publish.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 62 | pub struct Category { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 63 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 64 | pub description: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Category` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `extension_name` is never read [INFO] [stdout] --> src/commands/verify.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct Extension { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 36 | pub extension_name: String, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Extension` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `postgres_versions` is never read [INFO] [stdout] --> src/v1.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct TrunkProjectView { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | pub postgres_versions: Option>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TrunkProjectView` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `platform` is never read [INFO] [stdout] --> src/v1.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Download { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pub platform: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Download` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:46:70 [INFO] [stdout] | [INFO] [stdout] 46 | async fn execute(&self, task: Task) -> Result<(), anyhow::Error> { [INFO] [stdout] | _____________________________----------_______________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | | match self { [INFO] [stdout] 48 | | SubCommands::Build(cmd) => cmd.execute(task).await, [INFO] [stdout] 49 | | SubCommands::Publish(cmd) => cmd.execute(task).await, [INFO] [stdout] ... | [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:83:11 [INFO] [stdout] | [INFO] [stdout] 76 | let tm = TaskManager::new(Duration::from_secs(60)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | [INFO] [stdout] 78 | let rt = tokio::runtime::Builder::new_multi_thread() [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | match rt.block_on(async { [INFO] [stdout] | ___________^ [INFO] [stdout] 84 | | let cli = Cli::parse(); [INFO] [stdout] 85 | | let result = cli.command.execute(tm.task()).await; [INFO] [stdout] 86 | | tm.wait().await; [INFO] [stdout] 87 | | result [INFO] [stdout] 88 | | }) { [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/build.rs:194:70 [INFO] [stdout] | [INFO] [stdout] 194 | async fn execute(&self, task: Task) -> Result<(), anyhow::Error> { [INFO] [stdout] | _____________________________----------_______________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | | let build_settings = self.settings()?; [INFO] [stdout] 196 | | info!("Building from path {}", build_settings.path); [INFO] [stdout] 197 | | let path = Path::new(&build_settings.path); [INFO] [stdout] ... | [INFO] [stdout] 308 | | return Ok(()); [INFO] [stdout] 309 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/containers.rs:353:15 [INFO] [stdout] | [INFO] [stdout] 335 | let (receiver, sender, stream) = ByteStreamSyncSender::new(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | let f = || { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | match f() { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/install.rs:145:71 [INFO] [stdout] | [INFO] [stdout] 145 | async fn execute(&self, _task: Task) -> Result<(), anyhow::Error> { [INFO] [stdout] | _____________________________-----------_______________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | | let pg_config = self.pgconfig()?; [INFO] [stdout] 147 | | [INFO] [stdout] 148 | | let package_lib_dir = pg_config.pkglibdir()?; [INFO] [stdout] ... | [INFO] [stdout] 182 | | Ok(()) [INFO] [stdout] 183 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/pgrx.rs:77:30 [INFO] [stdout] | [INFO] [stdout] 77 | .filter_map(|&s| Version::parse(s).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/publish.rs:208:71 [INFO] [stdout] | [INFO] [stdout] 208 | async fn execute(&self, _task: Task) -> Result<(), anyhow::Error> { [INFO] [stdout] | _____________________________-----------_______________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | | let mut publish_settings = self.settings()?; [INFO] [stdout] 210 | | // Validate extension name input [INFO] [stdout] 211 | | let mut slugs = Vec::new(); [INFO] [stdout] ... | [INFO] [stdout] 386 | | Ok(()) [INFO] [stdout] 387 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/verify.rs:128:52 [INFO] [stdout] | [INFO] [stdout] 128 | async fn execute(&self, _: Task) -> Result<()> { [INFO] [stdout] | _____________________________-______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | | let tempdir = TempDir::new()?; [INFO] [stdout] 130 | | // Given an extension name, let's fetch its Trunk project [INFO] [stdout] 131 | | let trunk_project = { [INFO] [stdout] ... | [INFO] [stdout] 201 | | Ok(()) [INFO] [stdout] 202 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trunk_toml.rs:77:18 [INFO] [stdout] | [INFO] [stdout] 72 | extract: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | .or_else(|| maybe_toml.as_ref().map(extract)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trunk_toml.rs:90:18 [INFO] [stdout] | [INFO] [stdout] 85 | extract: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | .or_else(|| maybe_toml.as_ref().map(extract).and_then(Option::as_ref)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pg-trunk` (bin "trunk" test) due to 11 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "762f5eedf8bc99dd2c12e236860f80317762e4d90bd913d88260b7b0ad072ae1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "762f5eedf8bc99dd2c12e236860f80317762e4d90bd913d88260b7b0ad072ae1", kill_on_drop: false }` [INFO] [stdout] 762f5eedf8bc99dd2c12e236860f80317762e4d90bd913d88260b7b0ad072ae1