[INFO] fetching crate petr-ir 0.1.0... [INFO] checking petr-ir-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate petr-ir 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate petr-ir 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate petr-ir 0.1.0 [INFO] finished tweaking crates.io crate petr-ir 0.1.0 [INFO] tweaked toml for crates.io crate petr-ir 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 64 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miette v5.10.0 (latest: v7.2.0) [INFO] [stderr] Adding miette-derive v5.10.0 (latest: v7.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding owo-colors v3.5.0 (latest: v4.0.0) [INFO] [stderr] Adding supports-color v2.1.0 (latest: v3.0.0) [INFO] [stderr] Adding supports-hyperlinks v2.1.0 (latest: v3.0.0) [INFO] [stderr] Adding supports-unicode v2.1.0 (latest: v3.0.0) [INFO] [stderr] Adding terminal_size v0.1.17 (latest: v0.3.0) [INFO] [stderr] Adding textwrap v0.15.2 (latest: v0.16.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e1fb64ab3a115cc694ccdc8882b52b6bedca387a524fc50a1bbc511cc9d40d31 [INFO] running `Command { std: "docker" "start" "-a" "e1fb64ab3a115cc694ccdc8882b52b6bedca387a524fc50a1bbc511cc9d40d31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e1fb64ab3a115cc694ccdc8882b52b6bedca387a524fc50a1bbc511cc9d40d31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e1fb64ab3a115cc694ccdc8882b52b6bedca387a524fc50a1bbc511cc9d40d31", kill_on_drop: false }` [INFO] [stdout] e1fb64ab3a115cc694ccdc8882b52b6bedca387a524fc50a1bbc511cc9d40d31 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 580a917ab77543c5d918630396b0d8f48dc522db0961e46cbcef9f1e270617fa [INFO] running `Command { std: "docker" "start" "-a" "580a917ab77543c5d918630396b0d8f48dc522db0961e46cbcef9f1e270617fa", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking supports-hyperlinks v2.1.0 [INFO] [stderr] Checking supports-unicode v2.1.0 [INFO] [stderr] Compiling miette-derive v5.10.0 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Checking supports-color v2.1.0 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Checking dissimilar v1.0.9 [INFO] [stderr] Checking textwrap v0.15.2 [INFO] [stderr] Checking expect-test v1.5.0 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling logos-codegen v0.14.1 [INFO] [stderr] Checking backtrace v0.3.73 [INFO] [stderr] Compiling logos-derive v0.14.1 [INFO] [stderr] Checking logos v0.14.1 [INFO] [stderr] Checking backtrace-ext v0.2.1 [INFO] [stderr] Checking miette v5.10.0 [INFO] [stderr] Checking petr-utils v0.1.0 [INFO] [stderr] Checking petr-ast v0.1.0 [INFO] [stderr] Checking petr-bind v0.1.0 [INFO] [stderr] Checking petr-parse v0.1.0 [INFO] [stderr] Checking petr-resolve v0.1.0 [INFO] [stderr] Checking petr-typecheck v0.1.0 [INFO] [stderr] Checking petr-ir v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn lower(checker: TypeChecker) -> Result<(DataSection, Vec)> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let lowerer = Lowerer::new(checker)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Ok(lowerer.finalize()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:121:36 [INFO] [stdout] | [INFO] [stdout] 112 | func: MonomorphizedFunction, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let function_definition_body = self.type_checker.get_function(&func.id).body.clone(); [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | [INFO] [stdout] 120 | let mut buf = vec![]; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | self.with_variable_context(|ctx| -> Result<_> { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 122 | | // Pop parameters off the stack in reverse order -- the last parameter for the function [INFO] [stdout] 123 | | // will be the first thing popped off the stack [INFO] [stdout] 124 | | // When we lower a function call, we push them onto the stack from first to last. Since [INFO] [stdout] ... | [INFO] [stdout] 162 | | ))) [INFO] [stdout] 163 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:114:127 [INFO] [stdout] | [INFO] [stdout] 114 | ...omorphized_functions.iter().find(|(_id, (sig, _))| *sig == func.signature()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:156:51 [INFO] [stdout] | [INFO] [stdout] 120 | let mut buf = vec![]; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | let mut expr_body = ctx.lower_expr(&function_definition_body, return_dest)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | Ok(ctx.monomorphized_functions.insert(( [INFO] [stdout] | ___________________________________________________^ [INFO] [stdout] 157 | | FunctionSignature { [INFO] [stdout] 158 | | label: func.id, [INFO] [stdout] 159 | | concrete_types: func.params.iter().map(|(_name, ty)| ty.clone()).collect(), [INFO] [stdout] 160 | | }, [INFO] [stdout] 161 | | Function { body: buf }, [INFO] [stdout] 162 | | ))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:217:49 [INFO] [stdout] | [INFO] [stdout] 217 | .map(|(name, expr)| (*name, self.to_ir_type(self.type_checker.expr_ty(expr)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:325:37 [INFO] [stdout] | [INFO] [stdout] 325 | ... fields: variant.fields.iter().map(|field| self.to_ir_type(*field)).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `petr-ir` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "580a917ab77543c5d918630396b0d8f48dc522db0961e46cbcef9f1e270617fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "580a917ab77543c5d918630396b0d8f48dc522db0961e46cbcef9f1e270617fa", kill_on_drop: false }` [INFO] [stdout] 580a917ab77543c5d918630396b0d8f48dc522db0961e46cbcef9f1e270617fa