[INFO] fetching crate petr-codegen 0.1.0... [INFO] checking petr-codegen-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate petr-codegen 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate petr-codegen 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate petr-codegen 0.1.0 [INFO] finished tweaking crates.io crate petr-codegen 0.1.0 [INFO] tweaked toml for crates.io crate petr-codegen 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 89 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding cranelift v0.108.1 (latest: v0.111.0) [INFO] [stderr] Adding cranelift-bforest v0.108.1 (latest: v0.111.0) [INFO] [stderr] Adding cranelift-codegen v0.108.1 (latest: v0.111.0) [INFO] [stderr] Adding cranelift-codegen-meta v0.108.1 (latest: v0.111.0) [INFO] [stderr] Adding cranelift-codegen-shared v0.108.1 (latest: v0.111.0) [INFO] [stderr] Adding cranelift-control v0.108.1 (latest: v0.111.0) [INFO] [stderr] Adding cranelift-entity v0.108.1 (latest: v0.111.0) [INFO] [stderr] Adding cranelift-frontend v0.108.1 (latest: v0.111.0) [INFO] [stderr] Adding cranelift-isle v0.108.1 (latest: v0.111.0) [INFO] [stderr] Adding cranelift-module v0.108.1 (latest: v0.111.0) [INFO] [stderr] Adding cranelift-native v0.108.1 (latest: v0.111.0) [INFO] [stderr] Adding cranelift-object v0.108.1 (latest: v0.111.0) [INFO] [stderr] Adding gimli v0.28.1 (latest: v0.31.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.13.2 (latest: v0.14.5) [INFO] [stderr] Adding miette v5.10.0 (latest: v7.2.0) [INFO] [stderr] Adding miette-derive v5.10.0 (latest: v7.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding object v0.33.0 (latest: v0.36.4) [INFO] [stderr] Adding owo-colors v3.5.0 (latest: v4.0.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding supports-color v2.1.0 (latest: v3.0.0) [INFO] [stderr] Adding supports-hyperlinks v2.1.0 (latest: v3.0.0) [INFO] [stderr] Adding supports-unicode v2.1.0 (latest: v3.0.0) [INFO] [stderr] Adding terminal_size v0.1.17 (latest: v0.3.0) [INFO] [stderr] Adding textwrap v0.15.2 (latest: v0.16.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5c4281be86b8f6b7efffd37980ad277fe5ab51d498fde03c231cfd70f194b3e8 [INFO] running `Command { std: "docker" "start" "-a" "5c4281be86b8f6b7efffd37980ad277fe5ab51d498fde03c231cfd70f194b3e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5c4281be86b8f6b7efffd37980ad277fe5ab51d498fde03c231cfd70f194b3e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c4281be86b8f6b7efffd37980ad277fe5ab51d498fde03c231cfd70f194b3e8", kill_on_drop: false }` [INFO] [stdout] 5c4281be86b8f6b7efffd37980ad277fe5ab51d498fde03c231cfd70f194b3e8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 04a02b2bfa8027201b09515f65f2973c6a897ddd6f3aac1b09ba2c764bb1cae0 [INFO] running `Command { std: "docker" "start" "-a" "04a02b2bfa8027201b09515f65f2973c6a897ddd6f3aac1b09ba2c764bb1cae0", kill_on_drop: false }` [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling cranelift-isle v0.108.1 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling cranelift-codegen-shared v0.108.1 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking supports-unicode v2.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling cranelift-codegen-meta v0.108.1 [INFO] [stderr] Compiling miette-derive v5.10.0 [INFO] [stderr] Checking supports-color v2.1.0 [INFO] [stderr] Checking supports-hyperlinks v2.1.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking cranelift-entity v0.108.1 [INFO] [stderr] Checking arbitrary v1.3.2 [INFO] [stderr] Checking slice-group-by v0.3.1 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Checking textwrap v0.15.2 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking cranelift-bforest v0.108.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking regalloc2 v0.9.3 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking cranelift-control v0.108.1 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking object v0.33.0 [INFO] [stderr] Compiling cranelift-codegen v0.108.1 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking backtrace-ext v0.2.1 [INFO] [stderr] Checking miette v5.10.0 [INFO] [stderr] Checking petr-utils v0.1.0 [INFO] [stderr] Checking petr-ast v0.1.0 [INFO] [stderr] Checking petr-bind v0.1.0 [INFO] [stderr] Checking petr-resolve v0.1.0 [INFO] [stderr] Checking petr-typecheck v0.1.0 [INFO] [stderr] Checking petr-ir v0.1.0 [INFO] [stderr] Checking cranelift-frontend v0.108.1 [INFO] [stderr] Checking cranelift-module v0.108.1 [INFO] [stderr] Checking cranelift-native v0.108.1 [INFO] [stderr] Checking cranelift-object v0.108.1 [INFO] [stderr] Checking cranelift v0.108.1 [INFO] [stderr] Checking petr-codegen v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 54 | let mut flag_builder = settings::builder(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let isa_builder = isa_builder().map_err(ToString::to_string).map_err(IrErrorKind::GenericIRError)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let isa = isa_builder.finish(settings::Flags::new(flag_builder)).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | let builder = ObjectBuilder::new(isa, file_name, cranelift_module::default_libcall_names()).expect("TODO"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | let module = ObjectModule::new(builder); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | Ok(Self { module }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:41:26 [INFO] [stdout] | [INFO] [stdout] 40 | fn from(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Self { kind: value.into() } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 54 | let mut flag_builder = settings::builder(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let isa_builder = isa_builder().map_err(ToString::to_string).map_err(IrErrorKind::GenericIRError)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let isa = isa_builder.finish(settings::Flags::new(flag_builder)).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | let builder = ObjectBuilder::new(isa, file_name, cranelift_module::default_libcall_names()).expect("TODO"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | let module = ObjectModule::new(builder); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | Ok(Self { module }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `petr-codegen` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:41:26 [INFO] [stdout] | [INFO] [stdout] 40 | fn from(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Self { kind: value.into() } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `petr-codegen` (lib) due to 3 previous errors [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "04a02b2bfa8027201b09515f65f2973c6a897ddd6f3aac1b09ba2c764bb1cae0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "04a02b2bfa8027201b09515f65f2973c6a897ddd6f3aac1b09ba2c764bb1cae0", kill_on_drop: false }` [INFO] [stdout] 04a02b2bfa8027201b09515f65f2973c6a897ddd6f3aac1b09ba2c764bb1cae0