[INFO] fetching crate perpetual 0.3.8... [INFO] checking perpetual-0.3.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate perpetual 0.3.8 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate perpetual 0.3.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate perpetual 0.3.8 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate perpetual 0.3.8 [INFO] tweaked toml for crates.io crate perpetual 0.3.8 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate perpetual 0.3.8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4a6073e589474fb6fbe64b4c01d77469ec59f9ee94665ef206c9def8ee0af6c3 [INFO] running `Command { std: "docker" "start" "-a" "4a6073e589474fb6fbe64b4c01d77469ec59f9ee94665ef206c9def8ee0af6c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4a6073e589474fb6fbe64b4c01d77469ec59f9ee94665ef206c9def8ee0af6c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4a6073e589474fb6fbe64b4c01d77469ec59f9ee94665ef206c9def8ee0af6c3", kill_on_drop: false }` [INFO] [stdout] 4a6073e589474fb6fbe64b4c01d77469ec59f9ee94665ef206c9def8ee0af6c3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 02a981be4ca43840d208fe7b69a306fe77c2d2ad8bd6876200df6bf9622ecec3 [INFO] running `Command { std: "docker" "start" "-a" "02a981be4ca43840d208fe7b69a306fe77c2d2ad8bd6876200df6bf9622ecec3", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling cc v1.1.7 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling target-features v0.1.6 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking array-init-cursor v0.2.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking planus v0.3.1 [INFO] [stderr] Compiling smartstring v1.0.1 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling psm v0.1.21 [INFO] [stderr] Compiling stacker v0.1.15 [INFO] [stderr] Compiling polars-utils v0.41.3 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking raw-cpuid v11.1.0 [INFO] [stderr] Compiling polars-arrow v0.41.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking foreign_vec v0.1.0 [INFO] [stderr] Checking ethnum v1.5.0 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking streaming-iterator v0.1.9 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking atoi_simd v0.15.6 [INFO] [stderr] Checking fast-float v0.2.0 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Compiling polars-compute v0.41.3 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Compiling polars-core v0.41.3 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling polars-ops v0.41.3 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking xxhash-rust v0.8.12 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling serde_json v1.0.121 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking argminmax v0.6.2 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking now v0.1.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking streaming-decompression v0.1.2 [INFO] [stderr] Checking clap_builder v4.5.13 [INFO] [stderr] Checking memmap2 v0.7.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling polars v0.41.3 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling bytemuck_derive v1.7.0 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling multiversion-macros v0.7.4 [INFO] [stderr] Checking bytemuck v1.16.3 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Compiling zerocopy-derive v0.6.6 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking parquet-format-safe v0.2.4 [INFO] [stderr] Checking zerocopy v0.6.6 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking multiversion v0.7.4 [INFO] [stderr] Checking clap v4.5.13 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.18 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking polars-arrow-format v0.1.0 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking perpetual v0.3.8 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/booster.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 132 | fn parse_missing<'de, D>(d: D) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Deserialize::deserialize(d).map(|x: Option<_>| x.unwrap_or(f64::NAN)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi_output.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 73 | fn parse_missing<'de, D>(d: D) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Deserialize::deserialize(d).map(|x: Option<_>| x.unwrap_or(f64::NAN)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi_output.rs:304:22 [INFO] [stdout] | [INFO] [stdout] 304 | .map(|b| b.clone().set_objective(objective.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi_output.rs:315:22 [INFO] [stdout] | [INFO] [stdout] 315 | .map(|b| b.clone().set_base_score(base_score)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi_output.rs:326:54 [INFO] [stdout] | [INFO] [stdout] 326 | self.boosters = self.boosters.iter().map(|b| b.clone().set_max_bin(max_bin)).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi_output.rs:333:54 [INFO] [stdout] | [INFO] [stdout] 333 | self.boosters = self.boosters.iter().map(|b| b.clone().set_parallel(parallel)).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi_output.rs:343:22 [INFO] [stdout] | [INFO] [stdout] 343 | .map(|b| b.clone().set_monotone_constraints(monotone_constraints.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi_output.rs:365:54 [INFO] [stdout] | [INFO] [stdout] 365 | self.boosters = self.boosters.iter().map(|b| b.clone().set_missing(missing)).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi_output.rs:375:22 [INFO] [stdout] | [INFO] [stdout] 375 | .map(|b| b.clone().set_allow_missing_splits(allow_missing_splits)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi_output.rs:387:22 [INFO] [stdout] | [INFO] [stdout] 387 | .map(|b| b.clone().set_create_missing_branch(create_missing_branch)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi_output.rs:415:22 [INFO] [stdout] | [INFO] [stdout] 415 | .map(|b| b.clone().set_missing_node_treatment(missing_node_treatment.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi_output.rs:426:22 [INFO] [stdout] | [INFO] [stdout] 426 | .map(|b| b.clone().set_log_iterations(log_iterations)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `perpetual` (lib) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "02a981be4ca43840d208fe7b69a306fe77c2d2ad8bd6876200df6bf9622ecec3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "02a981be4ca43840d208fe7b69a306fe77c2d2ad8bd6876200df6bf9622ecec3", kill_on_drop: false }` [INFO] [stdout] 02a981be4ca43840d208fe7b69a306fe77c2d2ad8bd6876200df6bf9622ecec3