[INFO] fetching crate perigee 0.7.0... [INFO] checking perigee-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate perigee 0.7.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate perigee 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate perigee 0.7.0 [INFO] finished tweaking crates.io crate perigee 0.7.0 [INFO] tweaked toml for crates.io crate perigee 0.7.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 84 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nalgebra v0.32.6 (latest: v0.33.0) [INFO] [stderr] Adding num-derive v0.3.3 (latest: v0.4.2) [INFO] [stderr] Adding parry3d v0.13.8 (latest: v0.17.0) [INFO] [stderr] Adding rapier3d v0.17.2 (latest: v0.22.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding simba v0.8.1 (latest: v0.9.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 14288cd6ae7851da1a9f6fac0f11c965a99a71e2f915ac1ac375f2bee2143847 [INFO] running `Command { std: "docker" "start" "-a" "14288cd6ae7851da1a9f6fac0f11c965a99a71e2f915ac1ac375f2bee2143847", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "14288cd6ae7851da1a9f6fac0f11c965a99a71e2f915ac1ac375f2bee2143847", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14288cd6ae7851da1a9f6fac0f11c965a99a71e2f915ac1ac375f2bee2143847", kill_on_drop: false }` [INFO] [stdout] 14288cd6ae7851da1a9f6fac0f11c965a99a71e2f915ac1ac375f2bee2143847 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0ad2a29a2e52d8e43b0d6412c4a0e241c378f076aa5723ce8fcb9d4c276c4658 [INFO] running `Command { std: "docker" "start" "-a" "0ad2a29a2e52d8e43b0d6412c4a0e241c378f076aa5723ce8fcb9d4c276c4658", kill_on_drop: false }` [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling nalgebra-macros v0.2.2 [INFO] [stderr] Checking robust v1.1.0 [INFO] [stderr] Compiling inflections v1.1.1 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking zune-jpeg v0.4.13 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking safe_arch v0.7.2 [INFO] [stderr] Compiling gltf-derive v1.4.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking wide v0.7.28 [INFO] [stderr] Checking spade v2.12.0 [INFO] [stderr] Checking image v0.25.2 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Compiling perigee_macros v0.1.1 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Checking gltf-json v1.4.1 [INFO] [stderr] Checking gltf v1.4.1 [INFO] [stderr] Checking nalgebra v0.32.6 [INFO] [stderr] Checking parry3d v0.13.8 [INFO] [stderr] Checking rapier3d v0.17.2 [INFO] [stderr] Checking perigee v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/animation/manager.rs:76:42 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn add(&mut self, anim: Animation) -> Option { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | self.map [INFO] [stdout] 76 | .insert(anim.name().clone(), DetailedAnimation::new(anim)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `CString::from_raw` that must be used [INFO] [stdout] --> src/ffi/strings.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 17 | unsafe { CString::from_raw(string_ptr as *mut i8) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(from_raw(ptr))` if you intend to drop the `CString` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 17 | unsafe { let _ = CString::from_raw(string_ptr as *mut i8); }; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pointers.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Self { [INFO] [stdout] 29 | inner: Rc::new(RefCell::new(value)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/animation/manager.rs:76:42 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn add(&mut self, anim: Animation) -> Option { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | self.map [INFO] [stdout] 76 | .insert(anim.name().clone(), DetailedAnimation::new(anim)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `perigee` (lib test) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused return value of `CString::from_raw` that must be used [INFO] [stdout] --> src/ffi/strings.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 17 | unsafe { CString::from_raw(string_ptr as *mut i8) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(from_raw(ptr))` if you intend to drop the `CString` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 17 | unsafe { let _ = CString::from_raw(string_ptr as *mut i8); }; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pointers.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Self { [INFO] [stdout] 29 | inner: Rc::new(RefCell::new(value)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `perigee` (lib) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "0ad2a29a2e52d8e43b0d6412c4a0e241c378f076aa5723ce8fcb9d4c276c4658", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ad2a29a2e52d8e43b0d6412c4a0e241c378f076aa5723ce8fcb9d4c276c4658", kill_on_drop: false }` [INFO] [stdout] 0ad2a29a2e52d8e43b0d6412c4a0e241c378f076aa5723ce8fcb9d4c276c4658