[INFO] fetching crate percy-preview-app 0.0.3... [INFO] checking percy-preview-app-0.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate percy-preview-app 0.0.3 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate percy-preview-app 0.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate percy-preview-app 0.0.3 [INFO] finished tweaking crates.io crate percy-preview-app 0.0.3 [INFO] tweaked toml for crates.io crate percy-preview-app 0.0.3 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 46 packages to latest compatible versions [INFO] [stderr] Adding app-world v0.1.8 (latest: v0.3.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding percy-dom v0.7.5 (latest: v0.9.9) [INFO] [stderr] Adding percy-router v0.3.7 (latest: v0.5.1) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding serde_yaml v0.8.26 (latest: v0.9.34+deprecated) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] [stderr] Adding virtual-node v0.3.2 (latest: v0.5.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 83211f66cb3617849b0b99bad1bf4979790b4ff5b9abf2c84c9377b3c78c2d06 [INFO] running `Command { std: "docker" "start" "-a" "83211f66cb3617849b0b99bad1bf4979790b4ff5b9abf2c84c9377b3c78c2d06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "83211f66cb3617849b0b99bad1bf4979790b4ff5b9abf2c84c9377b3c78c2d06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "83211f66cb3617849b0b99bad1bf4979790b4ff5b9abf2c84c9377b3c78c2d06", kill_on_drop: false }` [INFO] [stdout] 83211f66cb3617849b0b99bad1bf4979790b4ff5b9abf2c84c9377b3c78c2d06 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ad50b1fecd5d904b4455998afb748fcaf3c6cb5e3f8017b82eb81e6a990a955e [INFO] running `Command { std: "docker" "start" "-a" "ad50b1fecd5d904b4455998afb748fcaf3c6cb5e3f8017b82eb81e6a990a955e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling linked-hash-map v0.5.6 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling hashbrown v0.12.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking app-world v0.1.8 [INFO] [stderr] Compiling html-validation v0.1.2 [INFO] [stderr] Compiling yaml-rust v0.4.5 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.93 [INFO] [stderr] Compiling percy-router-macro v0.1.5 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling html-macro v0.2.5 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.93 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.93 [INFO] [stderr] Checking wasm-bindgen v0.2.93 [INFO] [stderr] Checking js-sys v0.3.70 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Checking web-sys v0.3.70 [INFO] [stderr] Compiling serde_yaml v0.8.26 [INFO] [stderr] Compiling sunbeam-ir v0.0.3-alpha [INFO] [stderr] Compiling sunbeam-build v0.0.3-alpha [INFO] [stderr] Compiling sunbeam-macro v0.0.3-alpha [INFO] [stderr] Compiling percy-preview-app v0.0.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking sunbeam v0.0.3-alpha [INFO] [stderr] Checking virtual-node v0.3.2 [INFO] [stderr] Checking percy-dom v0.7.5 [INFO] [stderr] Checking percy-preview v0.0.3 [INFO] [stderr] Checking percy-router v0.3.7 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 66 | config: WebClientConfig, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | render: Arc ()>>>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | / AppConfig { [INFO] [stdout] 71 | | async_task_spawner: config.async_task_spawner, [INFO] [stdout] 72 | | after_path_change: Box::new(|new_path| { [INFO] [stdout] 73 | | history() [INFO] [stdout] ... | [INFO] [stdout] 77 | | previews: config.previews, [INFO] [stdout] 78 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/world.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 20 | pub(super) fn create_world(config: WorldConfig) -> World { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | World { [INFO] [stdout] 22 | state: State { [INFO] [stdout] | ________________^ [INFO] [stdout] 23 | | rendering_enabled: true, [INFO] [stdout] 24 | | active_path: "/".to_string(), [INFO] [stdout] 25 | | previews: config.previews, [INFO] [stdout] 26 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/world.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 20 | pub(super) fn create_world(config: WorldConfig) -> World { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | resources: Resources { [INFO] [stdout] | ____________________^ [INFO] [stdout] 28 | | after_path_change: config.after_path_change, [INFO] [stdout] 29 | | render_fn: config.render, [INFO] [stdout] 30 | | router: config.router, [INFO] [stdout] 31 | | async_task_spawner: config.async_task_spawner, [INFO] [stdout] 32 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/world/message/message_handlers.rs:24:46 [INFO] [stdout] | [INFO] [stdout] 21 | let render_fn = self.resources.render_fn.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | .spawn(Box::pin(async move { (render_fn.lock().unwrap())() })); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/visualize_component_route.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 13 | let route_data = provider.get_visualize_component_route_data(&component_name_url_friendly); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | ComponentView { data: route_data }.render() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 66 | config: WebClientConfig, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | render: Arc ()>>>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | / AppConfig { [INFO] [stdout] 71 | | async_task_spawner: config.async_task_spawner, [INFO] [stdout] 72 | | after_path_change: Box::new(|new_path| { [INFO] [stdout] 73 | | history() [INFO] [stdout] ... | [INFO] [stdout] 77 | | previews: config.previews, [INFO] [stdout] 78 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/world.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 20 | pub(super) fn create_world(config: WorldConfig) -> World { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | World { [INFO] [stdout] 22 | state: State { [INFO] [stdout] | ________________^ [INFO] [stdout] 23 | | rendering_enabled: true, [INFO] [stdout] 24 | | active_path: "/".to_string(), [INFO] [stdout] 25 | | previews: config.previews, [INFO] [stdout] 26 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/world.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 20 | pub(super) fn create_world(config: WorldConfig) -> World { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | resources: Resources { [INFO] [stdout] | ____________________^ [INFO] [stdout] 28 | | after_path_change: config.after_path_change, [INFO] [stdout] 29 | | render_fn: config.render, [INFO] [stdout] 30 | | router: config.router, [INFO] [stdout] 31 | | async_task_spawner: config.async_task_spawner, [INFO] [stdout] 32 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/world/message/message_handlers.rs:24:46 [INFO] [stdout] | [INFO] [stdout] 21 | let render_fn = self.resources.render_fn.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | .spawn(Box::pin(async move { (render_fn.lock().unwrap())() })); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/view/visualize_component_route.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 13 | let route_data = provider.get_visualize_component_route_data(&component_name_url_friendly); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | ComponentView { data: route_data }.render() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `percy-preview-app` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `percy-preview-app` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "ad50b1fecd5d904b4455998afb748fcaf3c6cb5e3f8017b82eb81e6a990a955e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad50b1fecd5d904b4455998afb748fcaf3c6cb5e3f8017b82eb81e6a990a955e", kill_on_drop: false }` [INFO] [stdout] ad50b1fecd5d904b4455998afb748fcaf3c6cb5e3f8017b82eb81e6a990a955e