[INFO] fetching crate per-thread-object 0.6.0... [INFO] checking per-thread-object-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate per-thread-object 0.6.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate per-thread-object 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate per-thread-object 0.6.0 [INFO] finished tweaking crates.io crate per-thread-object 0.6.0 [INFO] tweaked toml for crates.io crate per-thread-object 0.6.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 117 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (latest: v4.5.16) [INFO] [stderr] Adding clap_lex v0.2.4 (latest: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding generator v0.7.5 (latest: v0.8.3) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding loom v0.5.6 (latest: v0.7.2) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding os_str_bytes v6.6.1 (latest: v7.0.0) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding windows v0.48.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 80302665e34df18284fb17a55b68dcc29bf962f4fd7930524b8b2fe1449675c3 [INFO] running `Command { std: "docker" "start" "-a" "80302665e34df18284fb17a55b68dcc29bf962f4fd7930524b8b2fe1449675c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "80302665e34df18284fb17a55b68dcc29bf962f4fd7930524b8b2fe1449675c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80302665e34df18284fb17a55b68dcc29bf962f4fd7930524b8b2fe1449675c3", kill_on_drop: false }` [INFO] [stdout] 80302665e34df18284fb17a55b68dcc29bf962f4fd7930524b8b2fe1449675c3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f4f73a8d3e68da3e0d5dc81c4ca61b5529a5e003c8dc7a0065c626ed49cd0d2 [INFO] running `Command { std: "docker" "start" "-a" "1f4f73a8d3e68da3e0d5dc81c4ca61b5529a5e003c8dc7a0065c626ed49cd0d2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking traitobject v0.1.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking cache-padded v1.3.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking per-thread-object v0.6.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking unsafe-any v0.4.2 [INFO] [stdout] warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html). [INFO] [stdout] --> src/page.rs:5:19 [INFO] [stdout] | [INFO] [stdout] 5 | use cache_padded::CachePadded; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html). [INFO] [stdout] --> src/page.rs:29:16 [INFO] [stdout] | [INFO] [stdout] 29 | fastpage: [CachePadded>>>; DEFAULT_PAGE_CAP] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html). [INFO] [stdout] --> src/page.rs:66:28 [INFO] [stdout] | [INFO] [stdout] 66 | fastpage: arr![CachePadded::new(ManuallyDrop::new(UnsafeCell::new(None))); x16] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `cache_padded::CachePadded::::new`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html). [INFO] [stdout] --> src/page.rs:66:41 [INFO] [stdout] | [INFO] [stdout] 66 | fastpage: arr![CachePadded::new(ManuallyDrop::new(UnsafeCell::new(None))); x16] [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking thread-local-object v0.1.0 [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:112:13 [INFO] [stdout] | [INFO] [stdout] 112 | Err(err) => match err {} [INFO] [stdout] | ^^^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:110:60 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn get_or_init<'stack, F>(&'stack self, token: &'stack StackToken, init: F) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | match self.get_or_try_init::<_, Infallible>(token, || Ok(init())) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:110:66 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn get_or_init<'stack, F>(&'stack self, token: &'stack StackToken, init: F) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | match self.get_or_try_init::<_, Infallible>(token, || Ok(init())) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loom.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(t: T) -> UnsafeCell { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | UnsafeCell(std::cell::UnsafeCell::new(t)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/page.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 114 | let pages = inner.fallback.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | / pages.get(page_id - 1)? [INFO] [stdout] 116 | | .ptr [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `per-thread-object` (lib) due to 5 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "1f4f73a8d3e68da3e0d5dc81c4ca61b5529a5e003c8dc7a0065c626ed49cd0d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f4f73a8d3e68da3e0d5dc81c4ca61b5529a5e003c8dc7a0065c626ed49cd0d2", kill_on_drop: false }` [INFO] [stdout] 1f4f73a8d3e68da3e0d5dc81c4ca61b5529a5e003c8dc7a0065c626ed49cd0d2