[INFO] fetching crate penrose_ui 0.3.5... [INFO] checking penrose_ui-0.3.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate penrose_ui 0.3.5 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate penrose_ui 0.3.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate penrose_ui 0.3.5 [INFO] finished tweaking crates.io crate penrose_ui 0.3.5 [INFO] tweaked toml for crates.io crate penrose_ui 0.3.5 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate penrose_ui 0.3.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c3ca79d206045ca6e1a2f8ab8381a13e3c13cb7bbbe0b4d4322b1a80a3d2881a [INFO] running `Command { std: "docker" "start" "-a" "c3ca79d206045ca6e1a2f8ab8381a13e3c13cb7bbbe0b4d4322b1a80a3d2881a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c3ca79d206045ca6e1a2f8ab8381a13e3c13cb7bbbe0b4d4322b1a80a3d2881a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3ca79d206045ca6e1a2f8ab8381a13e3c13cb7bbbe0b4d4322b1a80a3d2881a", kill_on_drop: false }` [INFO] [stdout] c3ca79d206045ca6e1a2f8ab8381a13e3c13cb7bbbe0b4d4322b1a80a3d2881a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b615c52d56cc4aaa3885969d448c8921092dfb256feb655047452b3cfad4e16 [INFO] running `Command { std: "docker" "start" "-a" "1b615c52d56cc4aaa3885969d448c8921092dfb256feb655047452b3cfad4e16", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling serde v1.0.199 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Compiling x11rb v0.12.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking libloading v0.8.3 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Checking anymap v0.12.1 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking const-cstr v0.3.0 [INFO] [stderr] Compiling yeslogic-fontconfig-sys v4.0.1 [INFO] [stderr] Compiling x11 v2.21.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking gethostname v0.3.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking x11rb-protocol v0.12.0 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking penrose_keysyms v0.3.5 [INFO] [stderr] Checking penrose v0.3.5 [INFO] [stderr] Checking penrose_ui v0.3.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bar/mod.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 55 | bg: impl Into, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | widgets: Vec>>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let draw = Draw::new(font, point_size, bg)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | [INFO] [stdout] 63 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | draw, [INFO] [stdout] 65 | | position, [INFO] [stdout] 66 | | widgets, [INFO] [stdout] ... | [INFO] [stdout] 70 | | active_screen: 0, [INFO] [stdout] 71 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bar/widgets/mod.rs:251:23 [INFO] [stdout] | [INFO] [stdout] 245 | pub fn new(style: TextStyle, get_text: F) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | get_text: Box::new(get_text), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/mod.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn new(font: &str, point_size: u8, bg: impl Into) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let conn = RustConn::new()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let mut colors = HashMap::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 160 | | conn, [INFO] [stdout] 161 | | dpy, [INFO] [stdout] 162 | | fs: Fontset::try_new(dpy, &format!("{font}:size={point_size}"))?, [INFO] [stdout] ... | [INFO] [stdout] 165 | | colors, [INFO] [stdout] 166 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/mod.rs:459:12 [INFO] [stdout] | [INFO] [stdout] 459 | Ok(Self(inner)) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `penrose_ui` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bar/mod.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 55 | bg: impl Into, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | widgets: Vec>>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let draw = Draw::new(font, point_size, bg)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | [INFO] [stdout] 63 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | draw, [INFO] [stdout] 65 | | position, [INFO] [stdout] 66 | | widgets, [INFO] [stdout] ... | [INFO] [stdout] 70 | | active_screen: 0, [INFO] [stdout] 71 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bar/widgets/mod.rs:251:23 [INFO] [stdout] | [INFO] [stdout] 245 | pub fn new(style: TextStyle, get_text: F) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | get_text: Box::new(get_text), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/mod.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn new(font: &str, point_size: u8, bg: impl Into) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let conn = RustConn::new()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let mut colors = HashMap::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 160 | | conn, [INFO] [stdout] 161 | | dpy, [INFO] [stdout] 162 | | fs: Fontset::try_new(dpy, &format!("{font}:size={point_size}"))?, [INFO] [stdout] ... | [INFO] [stdout] 165 | | colors, [INFO] [stdout] 166 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/mod.rs:459:12 [INFO] [stdout] | [INFO] [stdout] 459 | Ok(Self(inner)) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `penrose_ui` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "1b615c52d56cc4aaa3885969d448c8921092dfb256feb655047452b3cfad4e16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b615c52d56cc4aaa3885969d448c8921092dfb256feb655047452b3cfad4e16", kill_on_drop: false }` [INFO] [stdout] 1b615c52d56cc4aaa3885969d448c8921092dfb256feb655047452b3cfad4e16