[INFO] fetching crate pelite 0.10.0... [INFO] checking pelite-0.10.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pelite 0.10.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate pelite 0.10.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pelite 0.10.0 [INFO] finished tweaking crates.io crate pelite 0.10.0 [INFO] tweaked toml for crates.io crate pelite 0.10.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate pelite 0.10.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cc282520129b4377c7ebbe8d85eaf17bb6523e810eacc69ec1f9e9150f865e95 [INFO] running `Command { std: "docker" "start" "-a" "cc282520129b4377c7ebbe8d85eaf17bb6523e810eacc69ec1f9e9150f865e95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cc282520129b4377c7ebbe8d85eaf17bb6523e810eacc69ec1f9e9150f865e95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc282520129b4377c7ebbe8d85eaf17bb6523e810eacc69ec1f9e9150f865e95", kill_on_drop: false }` [INFO] [stdout] cc282520129b4377c7ebbe8d85eaf17bb6523e810eacc69ec1f9e9150f865e95 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] de78200132d2b0972455f4c890e326024197f06ca23ae57f435bdacd511acfa0 [INFO] running `Command { std: "docker" "start" "-a" "de78200132d2b0972455f4c890e326024197f06ca23ae57f435bdacd511acfa0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.88 [INFO] [stderr] Compiling derive_pod v0.1.2 [INFO] [stderr] Checking no-std-compat v0.4.1 [INFO] [stderr] Compiling pelite-macros v0.1.1 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking lde v0.3.0 [INFO] [stderr] Checking format_xml v0.2.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking dataview v1.0.0 [INFO] [stderr] Checking pelite v0.10.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking rand v0.5.6 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resources/find.rs:116:43 [INFO] [stdout] | [INFO] [stdout] 116 | icons.into_iter().flat_map(move |icons| icons.entries().map(move |de| { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resources/find.rs:130:47 [INFO] [stdout] | [INFO] [stdout] 130 | cursors.into_iter().flat_map(move |cursors| cursors.entries().map(move |de| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pelite` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pe64/imports.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 303 | for _ in desc.iat() {} [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 303 | while let Ok(_) = desc.iat() {} [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 303 | for _ in desc.iat()? {} [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 303 | if let Ok(_) = desc.iat() {} [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pe64/imports.rs:304:12 [INFO] [stdout] | [INFO] [stdout] 304 | for _ in desc.int() {} [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 304 | while let Ok(_) = desc.int() {} [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 304 | for _ in desc.int()? {} [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 304 | if let Ok(_) = desc.int() {} [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pe32/../pe64/imports.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 303 | for _ in desc.iat() {} [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 303 | while let Ok(_) = desc.iat() {} [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 303 | for _ in desc.iat()? {} [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 303 | if let Ok(_) = desc.iat() {} [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pe32/../pe64/imports.rs:304:12 [INFO] [stdout] | [INFO] [stdout] 304 | for _ in desc.int() {} [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 304 | while let Ok(_) = desc.int() {} [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 304 | for _ in desc.int()? {} [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 304 | if let Ok(_) = desc.int() {} [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resources/find.rs:116:43 [INFO] [stdout] | [INFO] [stdout] 116 | icons.into_iter().flat_map(move |icons| icons.entries().map(move |de| { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resources/find.rs:130:47 [INFO] [stdout] | [INFO] [stdout] 130 | cursors.into_iter().flat_map(move |cursors| cursors.entries().map(move |de| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pelite` (lib test) due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "de78200132d2b0972455f4c890e326024197f06ca23ae57f435bdacd511acfa0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de78200132d2b0972455f4c890e326024197f06ca23ae57f435bdacd511acfa0", kill_on_drop: false }` [INFO] [stdout] de78200132d2b0972455f4c890e326024197f06ca23ae57f435bdacd511acfa0