[INFO] fetching crate pel 0.1.0... [INFO] checking pel-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pel 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate pel 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pel 0.1.0 [INFO] finished tweaking crates.io crate pel 0.1.0 [INFO] tweaked toml for crates.io crate pel 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate pel 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 75ab3e760972c4d199b37ce735e3672fa8b6af277ecab47fa82e72c275fae76f [INFO] running `Command { std: "docker" "start" "-a" "75ab3e760972c4d199b37ce735e3672fa8b6af277ecab47fa82e72c275fae76f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "75ab3e760972c4d199b37ce735e3672fa8b6af277ecab47fa82e72c275fae76f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "75ab3e760972c4d199b37ce735e3672fa8b6af277ecab47fa82e72c275fae76f", kill_on_drop: false }` [INFO] [stdout] 75ab3e760972c4d199b37ce735e3672fa8b6af277ecab47fa82e72c275fae76f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f9f53d102699d45b8a220f7a6a0c640f6c35e3a9dfd3ecb3df699dec79374ea7 [INFO] running `Command { std: "docker" "start" "-a" "f9f53d102699d45b8a220f7a6a0c640f6c35e3a9dfd3ecb3df699dec79374ea7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling xml-rs v0.8.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking lazycell v1.2.1 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Checking arrayvec v0.5.1 [INFO] [stderr] Checking downcast-rs v1.1.1 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking lock_api v0.3.3 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Checking smallvec v1.1.0 [INFO] [stderr] Checking instant v0.1.2 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Checking stb_truetype v0.3.1 [INFO] [stderr] Compiling x11-dl v2.18.4 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking parking_lot_core v0.7.0 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking ogl33 v0.2.0 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking parking_lot v0.10.0 [INFO] [stderr] Compiling wayland-scanner v0.23.6 [INFO] [stderr] Compiling gl_generator v0.13.1 [INFO] [stderr] Compiling gl_generator v0.11.0 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.23.6 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking line_drawing v0.7.0 [INFO] [stderr] Compiling glutin_glx_sys v0.1.5 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking rusttype v0.8.2 [INFO] [stderr] Compiling glutin_egl_sys v0.1.4 [INFO] [stderr] Checking rusttype v0.7.9 [INFO] [stderr] Checking andrew v0.2.1 [INFO] [stderr] Compiling wayland-client v0.23.6 [INFO] [stderr] Compiling wayland-protocols v0.23.6 [INFO] [stderr] Checking wayland-commons v0.23.6 [INFO] [stderr] Checking calloop v0.4.4 [INFO] [stderr] Checking smithay-client-toolkit v0.6.4 [INFO] [stderr] Checking winit v0.20.0 [INFO] [stderr] Checking glutin v0.22.0 [INFO] [stderr] Checking pel v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:200:16 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn run(self, event_handler: E) -> ! [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let mut wb = WindowBuilder::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | let el = EventLoop::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let context = ContextBuilder::new() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | let window = unsafe { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | let mut pel = Wrapper::build(event_handler); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | let mut ctx = Context::new(window, &self.pel_attribs); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | el.run(move |event, _, flow| match event { [INFO] [stdout] | ________________^ [INFO] [stdout] 201 | | Event::WindowEvent { window_id, event } => pel.window_event(&mut ctx, window_id, event, flow), [INFO] [stdout] 202 | | Event::DeviceEvent { device_id, event } => pel.device_event(&mut ctx, device_id, event), [INFO] [stdout] 203 | | Event::NewEvents(cause) => pel.start(&mut ctx, cause), [INFO] [stdout] ... | [INFO] [stdout] 207 | | _ => (), [INFO] [stdout] 208 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:47:23 [INFO] [stdout] | [INFO] [stdout] 42 | pub(super) fn new(window: WindowedContext, attribs: &PelAttributes) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | _program: Program::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:48:22 [INFO] [stdout] | [INFO] [stdout] 42 | pub(super) fn new(window: WindowedContext, attribs: &PelAttributes) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | texture: Texture::new(texture_width, texture_height), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpu/program.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 75 | let vs_src = CString::new(include_str!("src/default.vs")) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | .expect("Default vertex shader source code is not a valid C string"); [INFO] [stdout] 77 | let vs_bin = Shader::compile(&vs_src, GL_VERTEX_SHADER).expect("Could not compile default vertex shader"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | [INFO] [stdout] 79 | let fs_src = CString::new(include_str!("src/default.fs")) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | .expect("Default fragment shader source code is not a valid C string"); [INFO] [stdout] 81 | let fs_bin = Shader::compile(&fs_src, GL_FRAGMENT_SHADER).expect("Could not compile default fragment shader"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | [INFO] [stdout] 83 | Self::link(&[vs_bin, fs_bin]).expect("Could not link default program") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:200:16 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn run(self, event_handler: E) -> ! [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let mut wb = WindowBuilder::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | let el = EventLoop::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let context = ContextBuilder::new() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | let window = unsafe { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | let mut pel = Wrapper::build(event_handler); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | let mut ctx = Context::new(window, &self.pel_attribs); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | el.run(move |event, _, flow| match event { [INFO] [stdout] | ________________^ [INFO] [stdout] 201 | | Event::WindowEvent { window_id, event } => pel.window_event(&mut ctx, window_id, event, flow), [INFO] [stdout] 202 | | Event::DeviceEvent { device_id, event } => pel.device_event(&mut ctx, device_id, event), [INFO] [stdout] 203 | | Event::NewEvents(cause) => pel.start(&mut ctx, cause), [INFO] [stdout] ... | [INFO] [stdout] 207 | | _ => (), [INFO] [stdout] 208 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:47:23 [INFO] [stdout] | [INFO] [stdout] 42 | pub(super) fn new(window: WindowedContext, attribs: &PelAttributes) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | _program: Program::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:48:22 [INFO] [stdout] | [INFO] [stdout] 42 | pub(super) fn new(window: WindowedContext, attribs: &PelAttributes) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | texture: Texture::new(texture_width, texture_height), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpu/program.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 75 | let vs_src = CString::new(include_str!("src/default.vs")) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | .expect("Default vertex shader source code is not a valid C string"); [INFO] [stdout] 77 | let vs_bin = Shader::compile(&vs_src, GL_VERTEX_SHADER).expect("Could not compile default vertex shader"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | [INFO] [stdout] 79 | let fs_src = CString::new(include_str!("src/default.fs")) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | .expect("Default fragment shader source code is not a valid C string"); [INFO] [stdout] 81 | let fs_bin = Shader::compile(&fs_src, GL_FRAGMENT_SHADER).expect("Could not compile default fragment shader"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | [INFO] [stdout] 83 | Self::link(&[vs_bin, fs_bin]).expect("Could not link default program") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/gpu/texture.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | mem::replace(&mut self.inner, Surface::new(w, h)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 85 | let _ = mem::replace(&mut self.inner, Surface::new(w, h)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/gpu/texture.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | mem::replace(&mut self.inner, Surface::new(w, h)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 85 | let _ = mem::replace(&mut self.inner, Surface::new(w, h)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pel` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `pel` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f9f53d102699d45b8a220f7a6a0c640f6c35e3a9dfd3ecb3df699dec79374ea7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9f53d102699d45b8a220f7a6a0c640f6c35e3a9dfd3ecb3df699dec79374ea7", kill_on_drop: false }` [INFO] [stdout] f9f53d102699d45b8a220f7a6a0c640f6c35e3a9dfd3ecb3df699dec79374ea7