[INFO] fetching crate pegasus_astro 0.1.0... [INFO] checking pegasus_astro-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pegasus_astro 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate pegasus_astro 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pegasus_astro 0.1.0 [INFO] finished tweaking crates.io crate pegasus_astro 0.1.0 [INFO] tweaked toml for crates.io crate pegasus_astro 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate pegasus_astro 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 01a8ab112166b031d5c461f6399f6cc99c600a8a7bcdfceb10b1ff1f60e3b3b3 [INFO] running `Command { std: "docker" "start" "-a" "01a8ab112166b031d5c461f6399f6cc99c600a8a7bcdfceb10b1ff1f60e3b3b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "01a8ab112166b031d5c461f6399f6cc99c600a8a7bcdfceb10b1ff1f60e3b3b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01a8ab112166b031d5c461f6399f6cc99c600a8a7bcdfceb10b1ff1f60e3b3b3", kill_on_drop: false }` [INFO] [stdout] 01a8ab112166b031d5c461f6399f6cc99c600a8a7bcdfceb10b1ff1f60e3b3b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8883cf12fc2ebb90536a18c752dfef668e9361a1c06dcaedbb91dd1155262e0e [INFO] running `Command { std: "docker" "start" "-a" "8883cf12fc2ebb90536a18c752dfef668e9361a1c06dcaedbb91dd1155262e0e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.95 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling anyhow v1.0.57 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Compiling indexmap v1.8.2 [INFO] [stderr] Compiling hashbrown v0.11.2 [INFO] [stderr] Checking tracing-core v0.1.26 [INFO] [stderr] Compiling remove_dir_all v0.5.3 [INFO] [stderr] Compiling fastrand v1.7.0 [INFO] [stderr] Checking http v0.2.7 [INFO] [stderr] Compiling cmake v0.1.48 [INFO] [stderr] Compiling itertools v0.10.3 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Compiling regex-syntax v0.6.26 [INFO] [stderr] Compiling bytes v1.1.0 [INFO] [stderr] Compiling fixedbitset v0.4.1 [INFO] [stderr] Compiling multimap v0.8.3 [INFO] [stderr] Compiling protobuf v3.0.2 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling async-trait v0.1.53 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking tower-layer v0.3.1 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling which v4.2.5 [INFO] [stderr] Compiling tempfile v3.3.0 [INFO] [stderr] Checking http-range-header v0.3.0 [INFO] [stderr] Compiling protoc-bin-vendored-linux-ppcle_64 v3.0.0 [INFO] [stderr] Compiling protoc-bin-vendored-linux-aarch_64 v3.0.0 [INFO] [stderr] Compiling protoc-bin-vendored-macos-x86_64 v3.0.0 [INFO] [stderr] Compiling protoc-bin-vendored-linux-x86_32 v3.0.0 [INFO] [stderr] Compiling prost-build v0.10.4 [INFO] [stderr] Compiling protoc-bin-vendored-linux-x86_64 v3.0.0 [INFO] [stderr] Checking matchit v0.5.0 [INFO] [stderr] Checking sync_wrapper v0.1.1 [INFO] [stderr] Compiling petgraph v0.6.2 [INFO] [stderr] Compiling protoc-bin-vendored-win32 v3.0.0 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Compiling protoc-bin-vendored v3.0.0 [INFO] [stderr] Checking mio v0.8.3 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking libudev v0.3.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Checking uuid v1.1.0 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking serialport v4.1.0 [INFO] [stderr] Checking mio-serial v5.0.2 [INFO] [stderr] Compiling prettyplease v0.1.11 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling prost-derive v0.10.1 [INFO] [stderr] Compiling tracing-attributes v0.1.21 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling pin-project-internal v1.0.10 [INFO] [stderr] Compiling async-stream-impl v0.3.3 [INFO] [stderr] Checking tokio v1.18.2 [INFO] [stderr] Checking async-stream v0.3.3 [INFO] [stderr] Compiling thiserror v1.0.31 [INFO] [stderr] Checking pin-project v1.0.10 [INFO] [stderr] Compiling protobuf-support v3.0.2 [INFO] [stderr] Checking tracing v0.1.34 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Compiling prost v0.10.4 [INFO] [stderr] Compiling prost-types v0.10.1 [INFO] [stderr] Compiling tonic-build v0.7.2 [INFO] [stderr] Checking axum-core v0.2.4 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking tokio-util v0.7.2 [INFO] [stderr] Checking tokio-io-timeout v1.2.0 [INFO] [stderr] Checking tokio-stream v0.1.8 [INFO] [stderr] Checking tokio-serial v5.4.3 [INFO] [stderr] Compiling tonic-reflection v0.4.0 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Checking tower v0.4.12 [INFO] [stderr] Compiling protobuf-parse v3.0.2 [INFO] [stderr] Checking tower-http v0.3.3 [INFO] [stderr] Compiling protobuf-codegen v3.0.2 [INFO] [stderr] Compiling lightspeed-astro v0.6.3 [INFO] [stderr] Checking hyper v0.14.19 [INFO] [stderr] Checking hyper-timeout v0.4.1 [INFO] [stderr] Checking axum v0.5.6 [INFO] [stderr] Checking tonic v0.7.2 [INFO] [stderr] Checking astrotools v0.3.1 [INFO] [stderr] Checking pegasus_astro v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `id`, `name`, and `address` are never read [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct PowerBoxDevice { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 12 | id: Uuid, [INFO] [stdout] | ^^ [INFO] [stdout] 13 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 14 | pub properties: Vec, [INFO] [stdout] 15 | address: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id`, `name`, and `address` are never read [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct PowerBoxDevice { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 12 | id: Uuid, [INFO] [stdout] | ^^ [INFO] [stdout] 13 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 14 | pub properties: Vec, [INFO] [stdout] 15 | address: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/ppba/main.rs:44:22 [INFO] [stdout] | [INFO] [stdout] 28 | let mut devices: Vec = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | devices: Arc::new(Mutex::new(devices)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/ppba/main.rs:54:55 [INFO] [stdout] | [INFO] [stdout] 53 | request: Request, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | ) -> Result, Status> { [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 55 | | debug!( [INFO] [stdout] 56 | | "Got a request to query devices from {:?}", [INFO] [stdout] 57 | | request.remote_addr() [INFO] [stdout] ... | [INFO] [stdout] 78 | | } [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/ppba/main.rs:84:56 [INFO] [stdout] | [INFO] [stdout] 83 | request: Request, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | ) -> Result, Status> { [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 85 | | info!( [INFO] [stdout] 86 | | "Got a request to set a property from {:?}", [INFO] [stdout] 87 | | request.remote_addr() [INFO] [stdout] ... | [INFO] [stdout] 119 | | Ok(Response::new(reply)) [INFO] [stdout] 120 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/ppba/main.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/ppba/ppba.rs:156:15 [INFO] [stdout] | [INFO] [stdout] 140 | fn send_command(&mut self, comm: T, val: Option) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | match self.port.write(&command) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/ppba/main.rs:44:22 [INFO] [stdout] | [INFO] [stdout] 28 | let mut devices: Vec = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | devices: Arc::new(Mutex::new(devices)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/ppba/main.rs:54:55 [INFO] [stdout] | [INFO] [stdout] 53 | request: Request, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | ) -> Result, Status> { [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 55 | | debug!( [INFO] [stdout] 56 | | "Got a request to query devices from {:?}", [INFO] [stdout] 57 | | request.remote_addr() [INFO] [stdout] ... | [INFO] [stdout] 78 | | } [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/ppba/main.rs:84:56 [INFO] [stdout] | [INFO] [stdout] 83 | request: Request, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | ) -> Result, Status> { [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 85 | | info!( [INFO] [stdout] 86 | | "Got a request to set a property from {:?}", [INFO] [stdout] 87 | | request.remote_addr() [INFO] [stdout] ... | [INFO] [stdout] 119 | | Ok(Response::new(reply)) [INFO] [stdout] 120 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/ppba/main.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/ppba/ppba.rs:156:15 [INFO] [stdout] | [INFO] [stdout] 140 | fn send_command(&mut self, comm: T, val: Option) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | match self.port.write(&command) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pegasus_astro` (bin "ppba") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pegasus_astro` (bin "ppba" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "8883cf12fc2ebb90536a18c752dfef668e9361a1c06dcaedbb91dd1155262e0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8883cf12fc2ebb90536a18c752dfef668e9361a1c06dcaedbb91dd1155262e0e", kill_on_drop: false }` [INFO] [stdout] 8883cf12fc2ebb90536a18c752dfef668e9361a1c06dcaedbb91dd1155262e0e