[INFO] fetching crate pearl 0.21.0... [INFO] checking pearl-0.21.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pearl 0.21.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate pearl 0.21.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pearl 0.21.0 [INFO] finished tweaking crates.io crate pearl 0.21.0 [INFO] tweaked toml for crates.io crate pearl 0.21.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate pearl 0.21.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `nix` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 270e8a466e4edfd5277806fa51827b5ed6c2e2d50ff91730429421536403919d [INFO] running `Command { std: "docker" "start" "-a" "270e8a466e4edfd5277806fa51827b5ed6c2e2d50ff91730429421536403919d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "270e8a466e4edfd5277806fa51827b5ed6c2e2d50ff91730429421536403919d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "270e8a466e4edfd5277806fa51827b5ed6c2e2d50ff91730429421536403919d", kill_on_drop: false }` [INFO] [stdout] 270e8a466e4edfd5277806fa51827b5ed6c2e2d50ff91730429421536403919d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 99edcd1a3030b64cbad2fd117cec7d66da06ed640de27bfe7a65d67ca8ad1880 [INFO] running `Command { std: "docker" "start" "-a" "99edcd1a3030b64cbad2fd117cec7d66da06ed640de27bfe7a65d67ca8ad1880", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `nix` dependency) [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling futures-task v0.3.29 [INFO] [stderr] Compiling futures-channel v0.3.29 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking futures-sink v0.3.29 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Checking futures-io v0.3.29 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Compiling iana-time-zone v0.1.58 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Compiling async-trait v0.1.74 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling thiserror v1.0.51 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking cpufeatures v0.2.11 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking crc v3.0.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.41 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tempfile v3.8.1 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Compiling pearl v0.21.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Compiling futures-macro v0.3.29 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.51 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Checking tokio v1.35.0 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking futures-executor v0.3.29 [INFO] [stderr] Checking futures v0.3.29 [INFO] [stdout] warning: unexpected `cfg` condition value: `std` [INFO] [stdout] --> src/filter/ahash/mod.rs:35:7 [INFO] [stdout] | [INFO] [stdout] 35 | #[cfg(feature = "std")] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `async-io-rio` and `benchmark` [INFO] [stdout] = help: consider adding `std` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `128` [INFO] [stdout] --> src/filter/ahash/fallback_hash.rs:153:11 [INFO] [stdout] | [INFO] [stdout] 153 | #[cfg(target_pointer_width = "128")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_pointer_width` are: `16`, `32`, and `64` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::BloomConfig` [INFO] [stdout] --> src/tools/validation.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub use crate::BloomConfig; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `std` [INFO] [stdout] --> src/filter/ahash/mod.rs:35:7 [INFO] [stdout] | [INFO] [stdout] 35 | #[cfg(feature = "std")] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `async-io-rio` and `benchmark` [INFO] [stdout] = help: consider adding `std` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `128` [INFO] [stdout] --> src/filter/ahash/fallback_hash.rs:153:11 [INFO] [stdout] | [INFO] [stdout] 153 | #[cfg(target_pointer_width = "128")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_pointer_width` are: `16`, `32`, and `64` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::BloomConfig` [INFO] [stdout] --> src/tools/validation.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub use crate::BloomConfig; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_all`, `contains_key`, and `push_deletion` are never used [INFO] [stdout] --> src/blob/index/mod.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 30 | pub(crate) trait IndexTrait: Send + Sync { [INFO] [stdout] | ---------- methods in this trait [INFO] [stdout] 31 | async fn get_all(&self, key: &K) -> Result>; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | async fn contains_key(&self, key: &K) -> Result>; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | fn push_deletion(&mut self, key: &K, header: RecordHeader) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SimpleFileIndex` is never constructed [INFO] [stdout] --> src/blob/index/simple.rs:8:19 [INFO] [stdout] | [INFO] [stdout] 8 | pub(crate) struct SimpleFileIndex { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/blob/index/simple.rs:169:8 [INFO] [stdout] | [INFO] [stdout] 168 | impl SimpleFileIndex { [INFO] [stdout] | -------------------- associated items in this implementation [INFO] [stdout] 169 | fn hash_valid(header: &IndexHeader, buf: &mut [u8]) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 179 | async fn read_index_header(file: &File) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 187 | async fn search_all( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 263 | async fn binary_search( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 304 | async fn validate_header(&self, buf: &mut [u8], blob_size: u64) -> Result<()> [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 316 | fn serialize( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 376 | async fn read_at(file: &File, index: usize, header: &IndexHeader) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `FileTrait` is never used [INFO] [stdout] --> src/io/mod.rs:37:7 [INFO] [stdout] | [INFO] [stdout] 37 | trait FileTrait: Sized { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `read_u128x2`, `read_u128x4`, `read_last_u16`, `read_last_u128x2`, and `read_last_u128x4` are never used [INFO] [stdout] --> src/filter/ahash/convert.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 97 | pub(crate) trait ReadFromSlice { [INFO] [stdout] | ------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 102 | fn read_u128x2(&self) -> ([u128; 2], &[u8]); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 103 | fn read_u128x4(&self) -> ([u128; 4], &[u8]); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 104 | fn read_last_u16(&self) -> u16; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 108 | fn read_last_u128x2(&self) -> [u128; 2]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 109 | fn read_last_u128x4(&self) -> [u128; 4]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/core.rs:170:20 [INFO] [stdout] | [INFO] [stdout] 140 | let index_name = name.with_extension(BLOB_INDEX_FILE_EXTENSION); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | .or_else(|error| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | Ok(Index::new(index_name, iodriver, index_config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/core.rs:313:46 [INFO] [stdout] | [INFO] [stdout] 313 | .map(|header| Entry::new(header, file.clone(), file_name.clone())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/core.rs:313:60 [INFO] [stdout] | [INFO] [stdout] 313 | .map(|header| Entry::new(header, file.clone(), file_name.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/bptree/core.rs:33:76 [INFO] [stdout] | [INFO] [stdout] 33 | async fn from_file(name: FileName, iodriver: IoDriver) -> Result { [INFO] [stdout] | ________________________--------------______________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | | trace!("open index file"); [INFO] [stdout] 35 | | let file = iodriver [INFO] [stdout] 36 | | .open(name.as_path()) [INFO] [stdout] ... | [INFO] [stdout] 49 | | }) [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/bptree/node.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | deserialize(&buf[offset..(offset + size_of::())]).map_err(Into::into) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/bptree/node.rs:84:38 [INFO] [stdout] | [INFO] [stdout] 84 | .binary_search_by(|elem| K::Ref::from(elem).cmp(&key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/bptree/node.rs:122:26 [INFO] [stdout] | [INFO] [stdout] 122 | .map(|bytes| deserialize::(bytes).map_err(Into::into)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/bptree/serializer.rs:243:12 [INFO] [stdout] | [INFO] [stdout] 227 | let mut buf = BytesMut::with_capacity(data_size); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | Ok((header, self.metadata, buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/core.rs:156:21 [INFO] [stdout] | [INFO] [stdout] 151 | pub(crate) fn new(name: FileName, iodriver: IoDriver, config: IndexConfig) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let params = IndexParams::new(config.bloom_config.is_some(), config.recreate_index_file); [INFO] [stdout] 153 | let bloom_filter = config.bloom_config.map(|cfg| Bloom::new(cfg)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | filter: CombinedFilter::new(bloom_filter, RangeFilter::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/core.rs:158:20 [INFO] [stdout] | [INFO] [stdout] 151 | pub(crate) fn new(name: FileName, iodriver: IoDriver, config: IndexConfig) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let params = IndexParams::new(config.bloom_config.is_some(), config.recreate_index_file); [INFO] [stdout] 153 | let bloom_filter = config.bloom_config.map(|cfg| Bloom::new(cfg)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | inner: State::InMemory(SRwLock::default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/core.rs:278:12 [INFO] [stdout] | [INFO] [stdout] 276 | let bloom = Bloom::from_raw(bloom_buf)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | let range = RangeFilter::::from_raw(range_buf)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | Ok((bloom, range, range_size + size_of::())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/simple.rs:18:76 [INFO] [stdout] | [INFO] [stdout] 18 | async fn from_file(name: FileName, iodriver: IoDriver) -> Result { [INFO] [stdout] | ________________________--------------______________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | | trace!("open index file"); [INFO] [stdout] 20 | | let file = iodriver [INFO] [stdout] 21 | | .open(name.as_path()) [INFO] [stdout] ... | [INFO] [stdout] 26 | | Ok(Self { file, header }) [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/simple.rs:351:33 [INFO] [stdout] | [INFO] [stdout] 351 | .filter_map(|h| serialize(&h).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:157:45 [INFO] [stdout] | [INFO] [stdout] 153 | pub(crate) async fn read_exact_at(&self, mut buf: BytesMut, offset: u64) -> IOResult { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let file_inner = self.inner.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | Self::inplace_sync_call(move || file_inner.std_file.read_exact_at(&mut buf, offset).map(|_| buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:157:101 [INFO] [stdout] | [INFO] [stdout] 153 | pub(crate) async fn read_exact_at(&self, mut buf: BytesMut, offset: u64) -> IOResult { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let file_inner = self.inner.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | Self::inplace_sync_call(move || file_inner.std_file.read_exact_at(&mut buf, offset).map(|_| buf)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:159:48 [INFO] [stdout] | [INFO] [stdout] 153 | pub(crate) async fn read_exact_at(&self, mut buf: BytesMut, offset: u64) -> IOResult { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let file_inner = self.inner.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | Self::background_sync_call(move || file_inner.std_file.read_exact_at(&mut buf, offset).map(|_| buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:159:104 [INFO] [stdout] | [INFO] [stdout] 153 | pub(crate) async fn read_exact_at(&self, mut buf: BytesMut, offset: u64) -> IOResult { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let file_inner = self.inner.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | Self::background_sync_call(move || file_inner.std_file.read_exact_at(&mut buf, offset).map(|_| buf)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:178:12 [INFO] [stdout] | [INFO] [stdout] 178 | Ok(metadata.created().unwrap_or(SystemTime::now())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:231:37 [INFO] [stdout] | [INFO] [stdout] 226 | fn inplace_sync_call(f: F) -> R [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | tokio::task::block_in_place(move || f()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:287:114 [INFO] [stdout] | [INFO] [stdout] 287 | async fn write_append_writable_data(&self, c: impl WritableDataCreator) -> IOResult { [INFO] [stdout] | ___________________________________________________________________------------------------------_________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 288 | | self.write_append_writable_data(c).await [INFO] [stdout] 289 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:290:66 [INFO] [stdout] | [INFO] [stdout] 290 | async fn write_append_all(&self, buf: Bytes) -> IOResult<()> { [INFO] [stdout] | ______________________________________----------__________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | | self.write_append_all(buf).await [INFO] [stdout] 292 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:293:75 [INFO] [stdout] | [INFO] [stdout] 293 | async fn write_all_at(&self, offset: u64, buf: Bytes) -> IOResult<()> { [INFO] [stdout] | _______________________________________________----------__________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | | self.write_all_at(offset, buf).await [INFO] [stdout] 295 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:302:85 [INFO] [stdout] | [INFO] [stdout] 302 | async fn read_exact_at(&self, buf: BytesMut, offset: u64) -> IOResult { [INFO] [stdout] | ___________________________________-------------_____________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 303 | | self.read_exact_at(buf, offset).await [INFO] [stdout] 304 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/partially_serialized.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 38 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | head_with_data, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | header_len, [INFO] [stdout] 44 | data, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | } = self; [INFO] [stdout] 46 | let (head, checksum) = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Self::finalize_with_checksum(head_with_data, header_len, blob_offset); [INFO] [stdout] 48 | Ok((head.freeze(), data, checksum)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/record.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn create(key: &K, timestamp: u64, data: Bytes, meta: Option) -> bincode::Result [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | Ok(Self { header, meta, data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/record.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 120 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | data, header, meta, .. [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let mut buf = BytesMut::with_capacity(buf_len); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let data = if include_data { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 140 | | PartiallySerializedRecord::new(buf, header_len, data), [INFO] [stdout] 141 | | header, [INFO] [stdout] 142 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/core.rs:718:58 [INFO] [stdout] | [INFO] [stdout] 718 | safe.active_blob = active_blob.map(|ab| Box::new(ASRwLock::new(ab))); [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/core.rs:764:17 [INFO] [stdout] | [INFO] [stdout] 762 | let sem = disk_access_sem.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 763 | let _sem = sem.acquire().await.expect("sem is closed"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 764 | / Blob::from_file(file.clone(), iodriver.clone(), config.blob()) [INFO] [stdout] 765 | | .await [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/core.rs:1107:19 [INFO] [stdout] | [INFO] [stdout] 1105 | fn new(config: Config, iodriver: IoDriver) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1106 | Self { [INFO] [stdout] 1107 | safe: RwLock::new(Safe::new(config.bloom_filter_group_size())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/observer.rs:75:20 [INFO] [stdout] | [INFO] [stdout] 73 | pub(crate) fn new(inner: Arc>) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | Self { [INFO] [stdout] 75 | state: ObserverState::Created(inner) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/observer_worker.rs:46:39 [INFO] [stdout] | [INFO] [stdout] 39 | receiver: Receiver, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | inner: Arc>, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | deferred_index_dump_info: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/observer_worker.rs:47:30 [INFO] [stdout] | [INFO] [stdout] 39 | receiver: Receiver, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | inner: Arc>, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | index_dump_task: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/observer_worker.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 39 | receiver: Receiver, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | inner: Arc>, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | fsync_task: None [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/observer_worker.rs:231:47 [INFO] [stdout] | [INFO] [stdout] 229 | let inner = self.inner.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | let task = tokio::spawn(async move { [INFO] [stdout] 231 | inner.try_dump_old_blob_indexes().await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/bloom.rs:236:20 [INFO] [stdout] | [INFO] [stdout] 233 | pub(crate) fn new_from_shared_config(config: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | inner: Some(AtomicBitVec::new(bits_count)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/bloom.rs:239:22 [INFO] [stdout] | [INFO] [stdout] 233 | pub(crate) fn new_from_shared_config(config: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | hashers: Self::hashers(config.hashers_count), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/bloom.rs:349:12 [INFO] [stdout] | [INFO] [stdout] 345 | let inner = [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 349 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 350 | | inner: Some(inner), [INFO] [stdout] 351 | | snapshot_protector: RwLock::new(()), [INFO] [stdout] 352 | | bits_count: save.bits_count, [INFO] [stdout] 353 | | hashers: Self::hashers(save.config.hashers_count), [INFO] [stdout] 354 | | config: Arc::new(save.config), [INFO] [stdout] 355 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/bloom.rs:363:9 [INFO] [stdout] | [INFO] [stdout] 363 | bincode::serialize(&save).map_err(Into::into) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/bloom.rs:369:12 [INFO] [stdout] | [INFO] [stdout] 369 | Ok(Self::from(save)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/hierarchical.rs:423:9 [INFO] [stdout] | [INFO] [stdout] 422 | pub fn into_vec(self) -> Vec> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 423 | self.children.into_iter().flatten().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/hierarchical.rs:575:9 [INFO] [stdout] | [INFO] [stdout] 574 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 575 | self.children.into_iter().flatten() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/range.rs:97:23 [INFO] [stdout] | [INFO] [stdout] 95 | RangeFilterInner::from_raw(buf).map(|safe| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Self { [INFO] [stdout] 97 | safe: RwLock::new(safe) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tools/blob_reader.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) fn from_path>(path: P) -> AnyResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let file = OpenOptions::new().read(true).open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Ok(BlobReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 14 | | len: file.metadata()?.len(), [INFO] [stdout] 15 | | file, [INFO] [stdout] 16 | | position: 0, [INFO] [stdout] 17 | | latest_wrong_header: None, [INFO] [stdout] 18 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tools/blob_reader.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub(crate) fn from_file(mut file: File) -> AnyResult { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok(BlobReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 25 | | file, [INFO] [stdout] 26 | | position, [INFO] [stdout] 27 | | len, [INFO] [stdout] 28 | | latest_wrong_header: None, [INFO] [stdout] 29 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tools/blob_writer.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) fn from_path>(path: P, cache_written: bool) -> AnyResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let cache = if cache_written { Some(vec![]) } else { None }; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Ok(BlobWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 20 | | file, [INFO] [stdout] 21 | | written: 0, [INFO] [stdout] 22 | | cache, [INFO] [stdout] 23 | | written_cached: 0, [INFO] [stdout] 24 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tools/utils.rs:126:11 [INFO] [stdout] | [INFO] [stdout] 125 | pub(super) fn block_on>(f: F) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | match tokio::runtime::Handle::try_current() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 46 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pearl` (lib) due to 47 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: methods `get_all`, `contains_key`, and `push_deletion` are never used [INFO] [stdout] --> src/blob/index/mod.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 30 | pub(crate) trait IndexTrait: Send + Sync { [INFO] [stdout] | ---------- methods in this trait [INFO] [stdout] 31 | async fn get_all(&self, key: &K) -> Result>; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | async fn contains_key(&self, key: &K) -> Result>; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | fn push_deletion(&mut self, key: &K, header: RecordHeader) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SimpleFileIndex` is never constructed [INFO] [stdout] --> src/blob/index/simple.rs:8:19 [INFO] [stdout] | [INFO] [stdout] 8 | pub(crate) struct SimpleFileIndex { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/blob/index/simple.rs:169:8 [INFO] [stdout] | [INFO] [stdout] 168 | impl SimpleFileIndex { [INFO] [stdout] | -------------------- associated items in this implementation [INFO] [stdout] 169 | fn hash_valid(header: &IndexHeader, buf: &mut [u8]) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 179 | async fn read_index_header(file: &File) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 187 | async fn search_all( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 263 | async fn binary_search( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 304 | async fn validate_header(&self, buf: &mut [u8], blob_size: u64) -> Result<()> [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 316 | fn serialize( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 376 | async fn read_at(file: &File, index: usize, header: &IndexHeader) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `FileTrait` is never used [INFO] [stdout] --> src/io/mod.rs:37:7 [INFO] [stdout] | [INFO] [stdout] 37 | trait FileTrait: Sized { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `read_u128x2`, `read_u128x4`, `read_last_u16`, `read_last_u128x2`, and `read_last_u128x4` are never used [INFO] [stdout] --> src/filter/ahash/convert.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 97 | pub(crate) trait ReadFromSlice { [INFO] [stdout] | ------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 102 | fn read_u128x2(&self) -> ([u128; 2], &[u8]); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 103 | fn read_u128x4(&self) -> ([u128; 4], &[u8]); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 104 | fn read_last_u16(&self) -> u16; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 108 | fn read_last_u128x2(&self) -> [u128; 2]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 109 | fn read_last_u128x4(&self) -> [u128; 4]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/core.rs:170:20 [INFO] [stdout] | [INFO] [stdout] 140 | let index_name = name.with_extension(BLOB_INDEX_FILE_EXTENSION); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | .or_else(|error| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | Ok(Index::new(index_name, iodriver, index_config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/core.rs:313:46 [INFO] [stdout] | [INFO] [stdout] 313 | .map(|header| Entry::new(header, file.clone(), file_name.clone())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/core.rs:313:60 [INFO] [stdout] | [INFO] [stdout] 313 | .map(|header| Entry::new(header, file.clone(), file_name.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/bptree/core.rs:33:76 [INFO] [stdout] | [INFO] [stdout] 33 | async fn from_file(name: FileName, iodriver: IoDriver) -> Result { [INFO] [stdout] | ________________________--------------______________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | | trace!("open index file"); [INFO] [stdout] 35 | | let file = iodriver [INFO] [stdout] 36 | | .open(name.as_path()) [INFO] [stdout] ... | [INFO] [stdout] 49 | | }) [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/bptree/node.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | deserialize(&buf[offset..(offset + size_of::())]).map_err(Into::into) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/bptree/node.rs:84:38 [INFO] [stdout] | [INFO] [stdout] 84 | .binary_search_by(|elem| K::Ref::from(elem).cmp(&key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/bptree/node.rs:122:26 [INFO] [stdout] | [INFO] [stdout] 122 | .map(|bytes| deserialize::(bytes).map_err(Into::into)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/bptree/serializer.rs:243:12 [INFO] [stdout] | [INFO] [stdout] 227 | let mut buf = BytesMut::with_capacity(data_size); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | Ok((header, self.metadata, buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/bptree/tests.rs:256:55 [INFO] [stdout] | [INFO] [stdout] 256 | for key in not_presented_keys.clone().map(|k| serialize(&k).unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/core.rs:156:21 [INFO] [stdout] | [INFO] [stdout] 151 | pub(crate) fn new(name: FileName, iodriver: IoDriver, config: IndexConfig) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let params = IndexParams::new(config.bloom_config.is_some(), config.recreate_index_file); [INFO] [stdout] 153 | let bloom_filter = config.bloom_config.map(|cfg| Bloom::new(cfg)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | filter: CombinedFilter::new(bloom_filter, RangeFilter::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/core.rs:158:20 [INFO] [stdout] | [INFO] [stdout] 151 | pub(crate) fn new(name: FileName, iodriver: IoDriver, config: IndexConfig) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let params = IndexParams::new(config.bloom_config.is_some(), config.recreate_index_file); [INFO] [stdout] 153 | let bloom_filter = config.bloom_config.map(|cfg| Bloom::new(cfg)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | inner: State::InMemory(SRwLock::default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/core.rs:278:12 [INFO] [stdout] | [INFO] [stdout] 276 | let bloom = Bloom::from_raw(bloom_buf)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | let range = RangeFilter::::from_raw(range_buf)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | Ok((bloom, range, range_size + size_of::())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/simple.rs:18:76 [INFO] [stdout] | [INFO] [stdout] 18 | async fn from_file(name: FileName, iodriver: IoDriver) -> Result { [INFO] [stdout] | ________________________--------------______________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | | trace!("open index file"); [INFO] [stdout] 20 | | let file = iodriver [INFO] [stdout] 21 | | .open(name.as_path()) [INFO] [stdout] ... | [INFO] [stdout] 26 | | Ok(Self { file, header }) [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/simple.rs:351:33 [INFO] [stdout] | [INFO] [stdout] 351 | .filter_map(|h| serialize(&h).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/benchmarks.rs:61:18 [INFO] [stdout] | [INFO] [stdout] 61 | .map(|i| serialize(&i).expect("can't serialize")) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/benchmarks.rs:205:18 [INFO] [stdout] | [INFO] [stdout] 205 | .map(|i| serialize(&i).expect("can't serialize")) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob/index/benchmarks.rs:254:18 [INFO] [stdout] | [INFO] [stdout] 254 | .map(|i| serialize(&i).expect("can't serialize")) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:157:45 [INFO] [stdout] | [INFO] [stdout] 153 | pub(crate) async fn read_exact_at(&self, mut buf: BytesMut, offset: u64) -> IOResult { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let file_inner = self.inner.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | Self::inplace_sync_call(move || file_inner.std_file.read_exact_at(&mut buf, offset).map(|_| buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:157:101 [INFO] [stdout] | [INFO] [stdout] 153 | pub(crate) async fn read_exact_at(&self, mut buf: BytesMut, offset: u64) -> IOResult { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let file_inner = self.inner.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | Self::inplace_sync_call(move || file_inner.std_file.read_exact_at(&mut buf, offset).map(|_| buf)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:159:48 [INFO] [stdout] | [INFO] [stdout] 153 | pub(crate) async fn read_exact_at(&self, mut buf: BytesMut, offset: u64) -> IOResult { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let file_inner = self.inner.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | Self::background_sync_call(move || file_inner.std_file.read_exact_at(&mut buf, offset).map(|_| buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:159:104 [INFO] [stdout] | [INFO] [stdout] 153 | pub(crate) async fn read_exact_at(&self, mut buf: BytesMut, offset: u64) -> IOResult { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let file_inner = self.inner.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | Self::background_sync_call(move || file_inner.std_file.read_exact_at(&mut buf, offset).map(|_| buf)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:178:12 [INFO] [stdout] | [INFO] [stdout] 178 | Ok(metadata.created().unwrap_or(SystemTime::now())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:231:37 [INFO] [stdout] | [INFO] [stdout] 226 | fn inplace_sync_call(f: F) -> R [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | tokio::task::block_in_place(move || f()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:287:114 [INFO] [stdout] | [INFO] [stdout] 287 | async fn write_append_writable_data(&self, c: impl WritableDataCreator) -> IOResult { [INFO] [stdout] | ___________________________________________________________________------------------------------_________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 288 | | self.write_append_writable_data(c).await [INFO] [stdout] 289 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:290:66 [INFO] [stdout] | [INFO] [stdout] 290 | async fn write_append_all(&self, buf: Bytes) -> IOResult<()> { [INFO] [stdout] | ______________________________________----------__________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | | self.write_append_all(buf).await [INFO] [stdout] 292 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:293:75 [INFO] [stdout] | [INFO] [stdout] 293 | async fn write_all_at(&self, offset: u64, buf: Bytes) -> IOResult<()> { [INFO] [stdout] | _______________________________________________----------__________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | | self.write_all_at(offset, buf).await [INFO] [stdout] 295 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/unix/sync.rs:302:85 [INFO] [stdout] | [INFO] [stdout] 302 | async fn read_exact_at(&self, buf: BytesMut, offset: u64) -> IOResult { [INFO] [stdout] | ___________________________________-------------_____________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 303 | | self.read_exact_at(buf, offset).await [INFO] [stdout] 304 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/partially_serialized.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 38 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | head_with_data, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | header_len, [INFO] [stdout] 44 | data, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | } = self; [INFO] [stdout] 46 | let (head, checksum) = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Self::finalize_with_checksum(head_with_data, header_len, blob_offset); [INFO] [stdout] 48 | Ok((head.freeze(), data, checksum)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/record.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn create(key: &K, timestamp: u64, data: Bytes, meta: Option) -> bincode::Result [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | Ok(Self { header, meta, data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/record.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 120 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | data, header, meta, .. [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let mut buf = BytesMut::with_capacity(buf_len); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let data = if include_data { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 140 | | PartiallySerializedRecord::new(buf, header_len, data), [INFO] [stdout] 141 | | header, [INFO] [stdout] 142 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/core.rs:718:58 [INFO] [stdout] | [INFO] [stdout] 718 | safe.active_blob = active_blob.map(|ab| Box::new(ASRwLock::new(ab))); [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/core.rs:764:17 [INFO] [stdout] | [INFO] [stdout] 762 | let sem = disk_access_sem.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 763 | let _sem = sem.acquire().await.expect("sem is closed"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 764 | / Blob::from_file(file.clone(), iodriver.clone(), config.blob()) [INFO] [stdout] 765 | | .await [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/core.rs:1107:19 [INFO] [stdout] | [INFO] [stdout] 1105 | fn new(config: Config, iodriver: IoDriver) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1106 | Self { [INFO] [stdout] 1107 | safe: RwLock::new(Safe::new(config.bloom_filter_group_size())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/observer.rs:75:20 [INFO] [stdout] | [INFO] [stdout] 73 | pub(crate) fn new(inner: Arc>) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | Self { [INFO] [stdout] 75 | state: ObserverState::Created(inner) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/observer_worker.rs:46:39 [INFO] [stdout] | [INFO] [stdout] 39 | receiver: Receiver, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | inner: Arc>, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | deferred_index_dump_info: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/observer_worker.rs:47:30 [INFO] [stdout] | [INFO] [stdout] 39 | receiver: Receiver, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | inner: Arc>, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | index_dump_task: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/observer_worker.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 39 | receiver: Receiver, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | inner: Arc>, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | fsync_task: None [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/observer_worker.rs:231:47 [INFO] [stdout] | [INFO] [stdout] 229 | let inner = self.inner.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | let task = tokio::spawn(async move { [INFO] [stdout] 231 | inner.try_dump_old_blob_indexes().await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/bloom.rs:236:20 [INFO] [stdout] | [INFO] [stdout] 233 | pub(crate) fn new_from_shared_config(config: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | inner: Some(AtomicBitVec::new(bits_count)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/bloom.rs:239:22 [INFO] [stdout] | [INFO] [stdout] 233 | pub(crate) fn new_from_shared_config(config: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | hashers: Self::hashers(config.hashers_count), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/bloom.rs:349:12 [INFO] [stdout] | [INFO] [stdout] 345 | let inner = [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 349 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 350 | | inner: Some(inner), [INFO] [stdout] 351 | | snapshot_protector: RwLock::new(()), [INFO] [stdout] 352 | | bits_count: save.bits_count, [INFO] [stdout] 353 | | hashers: Self::hashers(save.config.hashers_count), [INFO] [stdout] 354 | | config: Arc::new(save.config), [INFO] [stdout] 355 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/bloom.rs:363:9 [INFO] [stdout] | [INFO] [stdout] 363 | bincode::serialize(&save).map_err(Into::into) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/bloom.rs:369:12 [INFO] [stdout] | [INFO] [stdout] 369 | Ok(Self::from(save)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/hierarchical.rs:423:9 [INFO] [stdout] | [INFO] [stdout] 422 | pub fn into_vec(self) -> Vec> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 423 | self.children.into_iter().flatten().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/hierarchical.rs:575:9 [INFO] [stdout] | [INFO] [stdout] 574 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 575 | self.children.into_iter().flatten() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/range.rs:97:23 [INFO] [stdout] | [INFO] [stdout] 95 | RangeFilterInner::from_raw(buf).map(|safe| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Self { [INFO] [stdout] 97 | safe: RwLock::new(safe) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tools/blob_reader.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) fn from_path>(path: P) -> AnyResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let file = OpenOptions::new().read(true).open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Ok(BlobReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 14 | | len: file.metadata()?.len(), [INFO] [stdout] 15 | | file, [INFO] [stdout] 16 | | position: 0, [INFO] [stdout] 17 | | latest_wrong_header: None, [INFO] [stdout] 18 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tools/blob_reader.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub(crate) fn from_file(mut file: File) -> AnyResult { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok(BlobReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 25 | | file, [INFO] [stdout] 26 | | position, [INFO] [stdout] 27 | | len, [INFO] [stdout] 28 | | latest_wrong_header: None, [INFO] [stdout] 29 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tools/blob_writer.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) fn from_path>(path: P, cache_written: bool) -> AnyResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let cache = if cache_written { Some(vec![]) } else { None }; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Ok(BlobWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 20 | | file, [INFO] [stdout] 21 | | written: 0, [INFO] [stdout] 22 | | cache, [INFO] [stdout] 23 | | written_cached: 0, [INFO] [stdout] 24 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tools/utils.rs:126:11 [INFO] [stdout] | [INFO] [stdout] 125 | pub(super) fn block_on>(f: F) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | match tokio::runtime::Handle::try_current() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 50 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pearl` (lib test) due to 51 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "99edcd1a3030b64cbad2fd117cec7d66da06ed640de27bfe7a65d67ca8ad1880", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "99edcd1a3030b64cbad2fd117cec7d66da06ed640de27bfe7a65d67ca8ad1880", kill_on_drop: false }` [INFO] [stdout] 99edcd1a3030b64cbad2fd117cec7d66da06ed640de27bfe7a65d67ca8ad1880