[INFO] fetching crate pear_client 0.1.1... [INFO] checking pear_client-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pear_client 0.1.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate pear_client 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pear_client 0.1.1 [INFO] finished tweaking crates.io crate pear_client 0.1.1 [INFO] tweaked toml for crates.io crate pear_client 0.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 128 packages to latest compatible versions [INFO] [stderr] Adding compact_str v0.7.1 (latest: v0.8.0) [INFO] [stderr] Adding html5ever v0.27.0 (latest: v0.28.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding markup5ever v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding phf_generator v0.10.0 (latest: v0.11.2) [INFO] [stderr] Adding phf_shared v0.10.0 (latest: v0.11.2) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding xml5ever v0.18.1 (latest: v0.19.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7fbe3ef1390c78dbd4d7d61859e1fc85b0d245698bfd103d2e5a756df5a12c97 [INFO] running `Command { std: "docker" "start" "-a" "7fbe3ef1390c78dbd4d7d61859e1fc85b0d245698bfd103d2e5a756df5a12c97", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7fbe3ef1390c78dbd4d7d61859e1fc85b0d245698bfd103d2e5a756df5a12c97", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7fbe3ef1390c78dbd4d7d61859e1fc85b0d245698bfd103d2e5a756df5a12c97", kill_on_drop: false }` [INFO] [stdout] 7fbe3ef1390c78dbd4d7d61859e1fc85b0d245698bfd103d2e5a756df5a12c97 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1588802aaa1c1b4a1d6f20abc29113575a9cf45151528d51be9d41acbf41b40b [INFO] running `Command { std: "docker" "start" "-a" "1588802aaa1c1b4a1d6f20abc29113575a9cf45151528d51be9d41acbf41b40b", kill_on_drop: false }` [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking phf_shared v0.10.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling html5ever v0.27.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling ppv-lite86 v0.2.20 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling string_cache_codegen v0.5.2 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling markup5ever v0.12.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking string_cache v0.8.7 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking xml5ever v0.18.1 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking markup5ever_rcdom v0.3.0 [INFO] [stderr] Checking pear_client v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `reqwest` [INFO] [stdout] --> src/lib.rs:3:7 [INFO] [stdout] | [INFO] [stdout] 3 | #[cfg(feature = "reqwest")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `http`, and `serde` [INFO] [stdout] = help: consider adding `reqwest` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `reqwest` [INFO] [stdout] --> src/lib.rs:3:7 [INFO] [stdout] | [INFO] [stdout] 3 | #[cfg(feature = "reqwest")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `http`, and `serde` [INFO] [stdout] = help: consider adding `reqwest` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/http.rs:80:14 [INFO] [stdout] | [INFO] [stdout] 74 | let req = Request::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let res = self.inner.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Box::pin(async move { [INFO] [stdout] | ______________^ [INFO] [stdout] 81 | | let res: Response = res.await.map_err(|e| HttpPearClientError::Send(format!("{e:?}")))?; [INFO] [stdout] 82 | | let body = res [INFO] [stdout] 83 | | .into_body() [INFO] [stdout] ... | [INFO] [stdout] 89 | | Ok(result) [INFO] [stdout] 90 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/http.rs:124:14 [INFO] [stdout] | [INFO] [stdout] 118 | let req = Request::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | let res = self.inner.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | Box::pin(async move { [INFO] [stdout] | ______________^ [INFO] [stdout] 125 | | let res: Response = res.await.map_err(|e| HttpPearClientError::Send(format!("{e:?}")))?; [INFO] [stdout] 126 | | let body = res [INFO] [stdout] 127 | | .into_body() [INFO] [stdout] ... | [INFO] [stdout] 133 | | Ok(result) [INFO] [stdout] 134 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/http.rs:168:14 [INFO] [stdout] | [INFO] [stdout] 162 | let req = Request::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | let res = self.inner.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | Box::pin(async move { [INFO] [stdout] | ______________^ [INFO] [stdout] 169 | | let res: Response = res.await.map_err(|e| HttpPearClientError::Send(format!("{e:?}")))?; [INFO] [stdout] 170 | | let body = res [INFO] [stdout] 171 | | .into_body() [INFO] [stdout] ... | [INFO] [stdout] 177 | | Ok(result) [INFO] [stdout] 178 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/http.rs:212:14 [INFO] [stdout] | [INFO] [stdout] 206 | let req = Request::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let res = self.inner.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | Box::pin(async move { [INFO] [stdout] | ______________^ [INFO] [stdout] 213 | | let res: Response = res.await.map_err(|e| HttpPearClientError::Send(format!("{e:?}")))?; [INFO] [stdout] 214 | | let body = res [INFO] [stdout] 215 | | .into_body() [INFO] [stdout] ... | [INFO] [stdout] 221 | | Ok(result) [INFO] [stdout] 222 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/package.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 16 | let sink = RcDom::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let dom: RcDom = parse_document(sink, XmlParseOpts::default()).from_utf8().read_from(input).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Self::from_rc_dom(dom).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/package.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn from_rc_dom(dom: RcDom) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let doc = dom.document; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let root = find_root(&doc, "a").map_err(|_| PackageListingFromRcDomError::RootNotFound)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Ok(Self::from_xml_node(&root)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/package.rs:83:8 [INFO] [stdout] | [INFO] [stdout] 54 | let mut category: Option = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let mut items: Vec = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 84 | | category: category.ok_or(PackageListingFromXmlNodeError::MissingCategory)?, [INFO] [stdout] 85 | | items, [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/package.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 116 | let sink = RcDom::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | let dom: RcDom = parse_document(sink, XmlParseOpts::default()).from_utf8().read_from(input).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | Self::from_rc_dom(dom).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/package.rs:134:8 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn from_rc_dom(dom: RcDom) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | let doc = dom.document; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let root = find_root(&doc, "p").map_err(|_| PackageInfoFromRcDomError::RootNotFound)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Ok(Self::from_xml_node(&root)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/package.rs:338:8 [INFO] [stdout] | [INFO] [stdout] 212 | let mut package_name: Option = None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | let mut channel: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | let mut category: Option = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | let mut license: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | let mut license_uri: Option = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | let mut summary: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | let mut description: Option = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | let mut release: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | let mut parent: Option = None; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | let mut deprecation_channel: Option = None; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | let mut deprecation_package: Option = None; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 338 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 339 | | name: package_name.ok_or(E::MissingName)?, [INFO] [stdout] 340 | | channel: channel.ok_or(E::MissingChannel)?, [INFO] [stdout] 341 | | category: category.ok_or(E::MissingCategory)?, [INFO] [stdout] ... | [INFO] [stdout] 353 | | }, [INFO] [stdout] 354 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/release.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 17 | let sink = RcDom::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let dom: RcDom = parse_document(sink, XmlParseOpts::default()).from_utf8().read_from(input).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Self::from_rc_dom(dom).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/release.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn from_rc_dom(dom: RcDom) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let doc = dom.document; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let root = find_root(&doc, "a").map_err(|_| ReleaseListingFromRcDomError::RootNotFound)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(Self::from_xml_node(&root)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/release.rs:101:8 [INFO] [stdout] | [INFO] [stdout] 61 | let mut package: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let mut channel: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let mut items: Vec> = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 102 | | package: package.ok_or(ReleaseListingFromXmlNodeError::MissingPackage)?, [INFO] [stdout] 103 | | channel: channel.ok_or(ReleaseListingFromXmlNodeError::MissingChannel)?, [INFO] [stdout] 104 | | items, [INFO] [stdout] 105 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/release.rs:165:8 [INFO] [stdout] | [INFO] [stdout] 136 | let mut version: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let mut stability: Option = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 166 | | version: version.ok_or(ShortReleaseFromXmlNodeError::MissingVersion)?, [INFO] [stdout] 167 | | stability: stability.ok_or(ShortReleaseFromXmlNodeError::MissingStability)?, [INFO] [stdout] 168 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/release.rs:206:5 [INFO] [stdout] | [INFO] [stdout] 204 | let sink = RcDom::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | let dom: RcDom = parse_document(sink, XmlParseOpts::default()).from_utf8().read_from(input).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | Self::from_rc_dom(dom).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/release.rs:222:8 [INFO] [stdout] | [INFO] [stdout] 219 | pub fn from_rc_dom(dom: RcDom) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | let doc = dom.document; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | let root = find_root(&doc, "r").map_err(|_| ReleaseFromRcDomError::RootNotFound)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | Ok(Self::from_xml_node(&root)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/release.rs:470:8 [INFO] [stdout] | [INFO] [stdout] 322 | let mut package: Option> = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | let mut channel: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 324 | let mut version: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 325 | let mut status: Option = None; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 326 | let mut license: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 327 | let mut maintainer: Option = None; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 328 | let mut summary: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | let mut description: Option = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 330 | let mut date: Option = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 331 | let mut release_notes: Option = None; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 332 | let mut archive_size: Option = None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 333 | let mut archive_link: Option = None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 334 | let mut extracted: Option = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 470 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 471 | | package: package.ok_or(E::MissingPackage)?, [INFO] [stdout] 472 | | channel: channel.ok_or(E::MissingChannel)?, [INFO] [stdout] 473 | | version: version.ok_or(E::MissingVersion)?, [INFO] [stdout] ... | [INFO] [stdout] 485 | | extracted_link: extracted.ok_or(E::MissingExtracted)?, [INFO] [stdout] 486 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xml_util.rs:23:3 [INFO] [stdout] | [INFO] [stdout] 10 | let children = doc.children.borrow(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | root.cloned().ok_or(()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xml_util.rs:41:6 [INFO] [stdout] | [INFO] [stdout] 30 | let children = node.children.borrow(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | Ok(match text { [INFO] [stdout] | ______^ [INFO] [stdout] 42 | | None => CompactString::default(), [INFO] [stdout] 43 | | Some(text) => { [INFO] [stdout] 44 | | let text: &StrTendril = &text.borrow(); [INFO] [stdout] 45 | | CompactString::new(text) [INFO] [stdout] 46 | | } [INFO] [stdout] 47 | | }) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/http.rs:80:14 [INFO] [stdout] | [INFO] [stdout] 74 | let req = Request::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let res = self.inner.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Box::pin(async move { [INFO] [stdout] | ______________^ [INFO] [stdout] 81 | | let res: Response = res.await.map_err(|e| HttpPearClientError::Send(format!("{e:?}")))?; [INFO] [stdout] 82 | | let body = res [INFO] [stdout] 83 | | .into_body() [INFO] [stdout] ... | [INFO] [stdout] 89 | | Ok(result) [INFO] [stdout] 90 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/http.rs:124:14 [INFO] [stdout] | [INFO] [stdout] 118 | let req = Request::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | let res = self.inner.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | Box::pin(async move { [INFO] [stdout] | ______________^ [INFO] [stdout] 125 | | let res: Response = res.await.map_err(|e| HttpPearClientError::Send(format!("{e:?}")))?; [INFO] [stdout] 126 | | let body = res [INFO] [stdout] 127 | | .into_body() [INFO] [stdout] ... | [INFO] [stdout] 133 | | Ok(result) [INFO] [stdout] 134 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/http.rs:168:14 [INFO] [stdout] | [INFO] [stdout] 162 | let req = Request::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | let res = self.inner.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | Box::pin(async move { [INFO] [stdout] | ______________^ [INFO] [stdout] 169 | | let res: Response = res.await.map_err(|e| HttpPearClientError::Send(format!("{e:?}")))?; [INFO] [stdout] 170 | | let body = res [INFO] [stdout] 171 | | .into_body() [INFO] [stdout] ... | [INFO] [stdout] 177 | | Ok(result) [INFO] [stdout] 178 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/http.rs:212:14 [INFO] [stdout] | [INFO] [stdout] 206 | let req = Request::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let res = self.inner.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | Box::pin(async move { [INFO] [stdout] | ______________^ [INFO] [stdout] 213 | | let res: Response = res.await.map_err(|e| HttpPearClientError::Send(format!("{e:?}")))?; [INFO] [stdout] 214 | | let body = res [INFO] [stdout] 215 | | .into_body() [INFO] [stdout] ... | [INFO] [stdout] 221 | | Ok(result) [INFO] [stdout] 222 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/package.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 16 | let sink = RcDom::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let dom: RcDom = parse_document(sink, XmlParseOpts::default()).from_utf8().read_from(input).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Self::from_rc_dom(dom).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/package.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn from_rc_dom(dom: RcDom) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let doc = dom.document; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let root = find_root(&doc, "a").map_err(|_| PackageListingFromRcDomError::RootNotFound)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Ok(Self::from_xml_node(&root)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/package.rs:83:8 [INFO] [stdout] | [INFO] [stdout] 54 | let mut category: Option = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let mut items: Vec = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 84 | | category: category.ok_or(PackageListingFromXmlNodeError::MissingCategory)?, [INFO] [stdout] 85 | | items, [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/package.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 116 | let sink = RcDom::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | let dom: RcDom = parse_document(sink, XmlParseOpts::default()).from_utf8().read_from(input).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | Self::from_rc_dom(dom).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/package.rs:134:8 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn from_rc_dom(dom: RcDom) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | let doc = dom.document; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let root = find_root(&doc, "p").map_err(|_| PackageInfoFromRcDomError::RootNotFound)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Ok(Self::from_xml_node(&root)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/package.rs:338:8 [INFO] [stdout] | [INFO] [stdout] 212 | let mut package_name: Option = None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | let mut channel: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | let mut category: Option = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | let mut license: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | let mut license_uri: Option = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | let mut summary: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | let mut description: Option = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | let mut release: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | let mut parent: Option = None; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | let mut deprecation_channel: Option = None; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | let mut deprecation_package: Option = None; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 338 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 339 | | name: package_name.ok_or(E::MissingName)?, [INFO] [stdout] 340 | | channel: channel.ok_or(E::MissingChannel)?, [INFO] [stdout] 341 | | category: category.ok_or(E::MissingCategory)?, [INFO] [stdout] ... | [INFO] [stdout] 353 | | }, [INFO] [stdout] 354 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/release.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 17 | let sink = RcDom::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let dom: RcDom = parse_document(sink, XmlParseOpts::default()).from_utf8().read_from(input).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Self::from_rc_dom(dom).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/release.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn from_rc_dom(dom: RcDom) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let doc = dom.document; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let root = find_root(&doc, "a").map_err(|_| ReleaseListingFromRcDomError::RootNotFound)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(Self::from_xml_node(&root)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/release.rs:101:8 [INFO] [stdout] | [INFO] [stdout] 61 | let mut package: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let mut channel: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let mut items: Vec> = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 102 | | package: package.ok_or(ReleaseListingFromXmlNodeError::MissingPackage)?, [INFO] [stdout] 103 | | channel: channel.ok_or(ReleaseListingFromXmlNodeError::MissingChannel)?, [INFO] [stdout] 104 | | items, [INFO] [stdout] 105 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/release.rs:165:8 [INFO] [stdout] | [INFO] [stdout] 136 | let mut version: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let mut stability: Option = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 166 | | version: version.ok_or(ShortReleaseFromXmlNodeError::MissingVersion)?, [INFO] [stdout] 167 | | stability: stability.ok_or(ShortReleaseFromXmlNodeError::MissingStability)?, [INFO] [stdout] 168 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/release.rs:206:5 [INFO] [stdout] | [INFO] [stdout] 204 | let sink = RcDom::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | let dom: RcDom = parse_document(sink, XmlParseOpts::default()).from_utf8().read_from(input).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | Self::from_rc_dom(dom).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/release.rs:222:8 [INFO] [stdout] | [INFO] [stdout] 219 | pub fn from_rc_dom(dom: RcDom) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | let doc = dom.document; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | let root = find_root(&doc, "r").map_err(|_| ReleaseFromRcDomError::RootNotFound)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | Ok(Self::from_xml_node(&root)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/release.rs:470:8 [INFO] [stdout] | [INFO] [stdout] 322 | let mut package: Option> = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | let mut channel: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 324 | let mut version: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 325 | let mut status: Option = None; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 326 | let mut license: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 327 | let mut maintainer: Option = None; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 328 | let mut summary: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | let mut description: Option = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 330 | let mut date: Option = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 331 | let mut release_notes: Option = None; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 332 | let mut archive_size: Option = None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 333 | let mut archive_link: Option = None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 334 | let mut extracted: Option = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 470 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 471 | | package: package.ok_or(E::MissingPackage)?, [INFO] [stdout] 472 | | channel: channel.ok_or(E::MissingChannel)?, [INFO] [stdout] 473 | | version: version.ok_or(E::MissingVersion)?, [INFO] [stdout] ... | [INFO] [stdout] 485 | | extracted_link: extracted.ok_or(E::MissingExtracted)?, [INFO] [stdout] 486 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xml_util.rs:23:3 [INFO] [stdout] | [INFO] [stdout] 10 | let children = doc.children.borrow(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | root.cloned().ok_or(()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xml_util.rs:41:6 [INFO] [stdout] | [INFO] [stdout] 30 | let children = node.children.borrow(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | Ok(match text { [INFO] [stdout] | ______^ [INFO] [stdout] 42 | | None => CompactString::default(), [INFO] [stdout] 43 | | Some(text) => { [INFO] [stdout] 44 | | let text: &StrTendril = &text.borrow(); [INFO] [stdout] 45 | | CompactString::new(text) [INFO] [stdout] 46 | | } [INFO] [stdout] 47 | | }) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pear_client` (lib test) due to 20 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 19 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pear_client` (lib) due to 20 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "1588802aaa1c1b4a1d6f20abc29113575a9cf45151528d51be9d41acbf41b40b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1588802aaa1c1b4a1d6f20abc29113575a9cf45151528d51be9d41acbf41b40b", kill_on_drop: false }` [INFO] [stdout] 1588802aaa1c1b4a1d6f20abc29113575a9cf45151528d51be9d41acbf41b40b