[INFO] fetching crate peace_params_derive 0.0.13... [INFO] checking peace_params_derive-0.0.13 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate peace_params_derive 0.0.13 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate peace_params_derive 0.0.13 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate peace_params_derive 0.0.13 [INFO] finished tweaking crates.io crate peace_params_derive 0.0.13 [INFO] tweaked toml for crates.io crate peace_params_derive 0.0.13 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8b93e82c67cc82da6fd2dd92c3cf340f13ea0fddf8b408edff6531af894891e1 [INFO] running `Command { std: "docker" "start" "-a" "8b93e82c67cc82da6fd2dd92c3cf340f13ea0fddf8b408edff6531af894891e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8b93e82c67cc82da6fd2dd92c3cf340f13ea0fddf8b408edff6531af894891e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b93e82c67cc82da6fd2dd92c3cf340f13ea0fddf8b408edff6531af894891e1", kill_on_drop: false }` [INFO] [stdout] 8b93e82c67cc82da6fd2dd92c3cf340f13ea0fddf8b408edff6531af894891e1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 15519360bea0bad38fc878b70d2bc74cead19e1eea979f23fe379a2667eda88c [INFO] running `Command { std: "docker" "start" "-a" "15519360bea0bad38fc878b70d2bc74cead19e1eea979f23fe379a2667eda88c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking heck v0.4.1 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking peace_params_derive v0.0.13 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fields_map.rs:11:59 [INFO] [stdout] | [INFO] [stdout] 11 | let fields_mapped = fields.iter().map(|field| (field, f(field))); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/type_gen.rs:415:50 [INFO] [stdout] | [INFO] [stdout] 415 | .map(|(field_index, field)| (tuple_ident_from_field_index(field_index), field)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:153:23 [INFO] [stdout] | [INFO] [stdout] 148 | let string = match get_lit_str(&parse_nested_meta)? { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | Some(string) => string, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | match string.parse_with(Punctuated::::parse_terminated) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:358:5 [INFO] [stdout] | [INFO] [stdout] 353 | let field_generics_maybe = variant [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | / field_generics_maybe [INFO] [stdout] 359 | | .filter(|field_generic| { [INFO] [stdout] 360 | | parent_generics [INFO] [stdout] 361 | | .params [INFO] [stdout] 362 | | .iter() [INFO] [stdout] 363 | | .any(|parent_generic_param| field_generic == parent_generic_param) [INFO] [stdout] 364 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:511:29 [INFO] [stdout] | [INFO] [stdout] 509 | fn_expr: impl Fn(&Field, &Ident) -> proc_macro2::TokenStream + 'f, [INFO] [stdout] | ----------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 510 | ) -> impl Iterator + 'f { [INFO] [stdout] 511 | fields_stmt_map(fields, move |field, field_name, _field_index| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 512 | | let expr = fn_expr(field, field_name); [INFO] [stdout] 513 | | quote!(let #field_name = #expr;) [INFO] [stdout] 514 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:528:5 [INFO] [stdout] | [INFO] [stdout] 526 | fn_stmt: impl Fn(&Field, &Ident, LitInt) -> proc_macro2::TokenStream + 'f, [INFO] [stdout] | ------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 527 | ) -> impl Iterator + 'f { [INFO] [stdout] 528 | / fields [INFO] [stdout] 529 | | .iter() [INFO] [stdout] 530 | | .enumerate() [INFO] [stdout] 531 | | .filter(|(_field_index, field)| !is_phantom_data(&field.ty)) [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:532:14 [INFO] [stdout] | [INFO] [stdout] 526 | fn_stmt: impl Fn(&Field, &Ident, LitInt) -> proc_macro2::TokenStream + 'f, [INFO] [stdout] | ------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 532 | .map(move |(field_index, field)| { [INFO] [stdout] | ______________^ [INFO] [stdout] 533 | | let field_lit_int = tuple_index_from_field_index(field_index); [INFO] [stdout] 534 | | if let Some(field_ident) = field.ident.as_ref() { [INFO] [stdout] 535 | | fn_stmt(field, field_ident, field_lit_int) [INFO] [stdout] ... | [INFO] [stdout] 539 | | } [INFO] [stdout] 540 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `peace_params_derive` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fields_map.rs:11:59 [INFO] [stdout] | [INFO] [stdout] 11 | let fields_mapped = fields.iter().map(|field| (field, f(field))); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/type_gen.rs:415:50 [INFO] [stdout] | [INFO] [stdout] 415 | .map(|(field_index, field)| (tuple_ident_from_field_index(field_index), field)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:153:23 [INFO] [stdout] | [INFO] [stdout] 148 | let string = match get_lit_str(&parse_nested_meta)? { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | Some(string) => string, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | match string.parse_with(Punctuated::::parse_terminated) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:358:5 [INFO] [stdout] | [INFO] [stdout] 353 | let field_generics_maybe = variant [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | / field_generics_maybe [INFO] [stdout] 359 | | .filter(|field_generic| { [INFO] [stdout] 360 | | parent_generics [INFO] [stdout] 361 | | .params [INFO] [stdout] 362 | | .iter() [INFO] [stdout] 363 | | .any(|parent_generic_param| field_generic == parent_generic_param) [INFO] [stdout] 364 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:511:29 [INFO] [stdout] | [INFO] [stdout] 509 | fn_expr: impl Fn(&Field, &Ident) -> proc_macro2::TokenStream + 'f, [INFO] [stdout] | ----------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 510 | ) -> impl Iterator + 'f { [INFO] [stdout] 511 | fields_stmt_map(fields, move |field, field_name, _field_index| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 512 | | let expr = fn_expr(field, field_name); [INFO] [stdout] 513 | | quote!(let #field_name = #expr;) [INFO] [stdout] 514 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:528:5 [INFO] [stdout] | [INFO] [stdout] 526 | fn_stmt: impl Fn(&Field, &Ident, LitInt) -> proc_macro2::TokenStream + 'f, [INFO] [stdout] | ------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 527 | ) -> impl Iterator + 'f { [INFO] [stdout] 528 | / fields [INFO] [stdout] 529 | | .iter() [INFO] [stdout] 530 | | .enumerate() [INFO] [stdout] 531 | | .filter(|(_field_index, field)| !is_phantom_data(&field.ty)) [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:532:14 [INFO] [stdout] | [INFO] [stdout] 526 | fn_stmt: impl Fn(&Field, &Ident, LitInt) -> proc_macro2::TokenStream + 'f, [INFO] [stdout] | ------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 532 | .map(move |(field_index, field)| { [INFO] [stdout] | ______________^ [INFO] [stdout] 533 | | let field_lit_int = tuple_index_from_field_index(field_index); [INFO] [stdout] 534 | | if let Some(field_ident) = field.ident.as_ref() { [INFO] [stdout] 535 | | fn_stmt(field, field_ident, field_lit_int) [INFO] [stdout] ... | [INFO] [stdout] 539 | | } [INFO] [stdout] 540 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `peace_params_derive` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "15519360bea0bad38fc878b70d2bc74cead19e1eea979f23fe379a2667eda88c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "15519360bea0bad38fc878b70d2bc74cead19e1eea979f23fe379a2667eda88c", kill_on_drop: false }` [INFO] [stdout] 15519360bea0bad38fc878b70d2bc74cead19e1eea979f23fe379a2667eda88c