[INFO] fetching crate pdf_form_ids 0.6.0... [INFO] checking pdf_form_ids-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pdf_form_ids 0.6.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate pdf_form_ids 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pdf_form_ids 0.6.0 [INFO] finished tweaking crates.io crate pdf_form_ids 0.6.0 [INFO] tweaked toml for crates.io crate pdf_form_ids 0.6.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 59 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding case v0.1.0 (latest: v1.0.0) [INFO] [stderr] Adding chrono v0.3.0 (latest: v0.4.38) [INFO] [stderr] Adding deflate v0.7.20 (latest: v1.0.0) [INFO] [stderr] Adding derive-error v0.0.4 (latest: v0.0.5) [INFO] [stderr] Adding dtoa v0.4.8 (latest: v1.0.9) [INFO] [stderr] Adding flate2 v0.2.20 (latest: v1.0.33) [INFO] [stderr] Adding gif v0.10.3 (latest: v0.13.1) [INFO] [stderr] Adding image v0.19.0 (latest: v0.25.2) [INFO] [stderr] Adding itoa v0.3.4 (latest: v1.0.11) [INFO] [stderr] Adding jpeg-decoder v0.1.22 (latest: v0.3.1) [INFO] [stderr] Adding linked-hash-map v0.3.0 (latest: v0.5.6) [INFO] [stderr] Adding lopdf v0.15.3 (latest: v0.34.0) [INFO] [stderr] Adding num v0.1.42 (latest: v0.4.3) [INFO] [stderr] Adding num-derive v0.2.5 (latest: v0.4.2) [INFO] [stderr] Adding num-rational v0.1.42 (latest: v0.4.2) [INFO] [stderr] Adding png v0.12.0 (latest: v0.17.13) [INFO] [stderr] Adding pom v1.1.0 (latest: v3.4.0) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.3.15 (latest: v1.0.37) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding syn v0.11.11 (latest: v2.0.77) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding unicode-xid v0.0.4 (latest: v0.2.5) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 104bac0666ce8ab9a3fa5b5932353882fb12e37289ca2cba9192f3d325d177c4 [INFO] running `Command { std: "docker" "start" "-a" "104bac0666ce8ab9a3fa5b5932353882fb12e37289ca2cba9192f3d325d177c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "104bac0666ce8ab9a3fa5b5932353882fb12e37289ca2cba9192f3d325d177c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "104bac0666ce8ab9a3fa5b5932353882fb12e37289ca2cba9192f3d325d177c4", kill_on_drop: false }` [INFO] [stdout] 104bac0666ce8ab9a3fa5b5932353882fb12e37289ca2cba9192f3d325d177c4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c118d6f338fff1765e839a12db556e9861b06dd0a4b69f4d82967616f6cd76d2 [INFO] running `Command { std: "docker" "start" "-a" "c118d6f338fff1765e839a12db556e9861b06dd0a4b69f4d82967616f6cd76d2", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Compiling miniz-sys v0.1.12 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking itoa v0.3.4 [INFO] [stderr] Compiling case v0.1.0 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking linked-hash-map v0.3.0 [INFO] [stderr] Checking pom v1.1.0 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Compiling derive-error v0.0.4 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking lopdf v0.15.3 [INFO] [stderr] Checking pdf_form_ids v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:468:32 [INFO] [stdout] | [INFO] [stdout] 468 | ... if (key != "Off") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 468 - if (key != "Off") { [INFO] [stdout] 468 + if key != "Off" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:468:32 [INFO] [stdout] | [INFO] [stdout] 468 | ... if (key != "Off") { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 468 - if (key != "Off") { [INFO] [stdout] 468 + if key != "Off" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 140 | fn load_doc(doc: Document) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | let mut form_ids = Vec::new(); [INFO] [stdout] 142 | let mut queue = VecDeque::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Ok(Form { doc, form_ids }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:641:9 [INFO] [stdout] | [INFO] [stdout] 640 | pub fn save>(&mut self, path: P) -> Result<(), io::Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 641 | self.doc.save(path).map(|_| ()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 140 | fn load_doc(doc: Document) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | let mut form_ids = Vec::new(); [INFO] [stdout] 142 | let mut queue = VecDeque::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Ok(Form { doc, form_ids }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:641:9 [INFO] [stdout] | [INFO] [stdout] 640 | pub fn save>(&mut self, path: P) -> Result<(), io::Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 641 | self.doc.save(path).map(|_| ()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pdf_form_ids` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `pdf_form_ids` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "c118d6f338fff1765e839a12db556e9861b06dd0a4b69f4d82967616f6cd76d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c118d6f338fff1765e839a12db556e9861b06dd0a4b69f4d82967616f6cd76d2", kill_on_drop: false }` [INFO] [stdout] c118d6f338fff1765e839a12db556e9861b06dd0a4b69f4d82967616f6cd76d2