[INFO] fetching crate pcp-mutex 0.2.0... [INFO] checking pcp-mutex-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pcp-mutex 0.2.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate pcp-mutex 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pcp-mutex 0.2.0 [INFO] finished tweaking crates.io crate pcp-mutex 0.2.0 [INFO] tweaked toml for crates.io crate pcp-mutex 0.2.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate pcp-mutex 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9b5a04c7254fd8a9c38040f422ecb4c2f2a8d708197ce628ec191be7ac781ddf [INFO] running `Command { std: "docker" "start" "-a" "9b5a04c7254fd8a9c38040f422ecb4c2f2a8d708197ce628ec191be7ac781ddf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9b5a04c7254fd8a9c38040f422ecb4c2f2a8d708197ce628ec191be7ac781ddf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b5a04c7254fd8a9c38040f422ecb4c2f2a8d708197ce628ec191be7ac781ddf", kill_on_drop: false }` [INFO] [stdout] 9b5a04c7254fd8a9c38040f422ecb4c2f2a8d708197ce628ec191be7ac781ddf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ffb6e1a748e77c1512497ae8a9a756002ca79a0321f6dde8714eeb802bbeb510 [INFO] running `Command { std: "docker" "start" "-a" "ffb6e1a748e77c1512497ae8a9a756002ca79a0321f6dde8714eeb802bbeb510", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking linux-futex v0.1.1 [INFO] [stderr] Checking pcp-mutex v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:133:18 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn create<'a, T>(&'a self, res: T, ceiling: Priority) -> PcpMutex<'a, T> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | PcpMutex { [INFO] [stdout] 133 | res: UnsafeCell::new(res), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:135:19 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn create<'a, T>(&'a self, res: T, ceiling: Priority) -> PcpMutex<'a, T> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | lock: Arc::new(PcpMutexLock { [INFO] [stdout] | ___________________^ [INFO] [stdout] 136 | | ceiling, [INFO] [stdout] 137 | | futex: PiFutex::default(), [INFO] [stdout] 138 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:249:35 [INFO] [stdout] | [INFO] [stdout] 248 | pub fn lock(&'a self, f: impl FnOnce(&mut T) -> R) -> R { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | thread::THREAD_STATE.with(|thread_state| self.lock_internal(thread_state, f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pcp-mutex` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:133:18 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn create<'a, T>(&'a self, res: T, ceiling: Priority) -> PcpMutex<'a, T> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | PcpMutex { [INFO] [stdout] 133 | res: UnsafeCell::new(res), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:135:19 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn create<'a, T>(&'a self, res: T, ceiling: Priority) -> PcpMutex<'a, T> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | lock: Arc::new(PcpMutexLock { [INFO] [stdout] | ___________________^ [INFO] [stdout] 136 | | ceiling, [INFO] [stdout] 137 | | futex: PiFutex::default(), [INFO] [stdout] 138 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:249:35 [INFO] [stdout] | [INFO] [stdout] 248 | pub fn lock(&'a self, f: impl FnOnce(&mut T) -> R) -> R { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | thread::THREAD_STATE.with(|thread_state| self.lock_internal(thread_state, f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pcp-mutex` (lib test) due to 4 previous errors [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "ffb6e1a748e77c1512497ae8a9a756002ca79a0321f6dde8714eeb802bbeb510", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ffb6e1a748e77c1512497ae8a9a756002ca79a0321f6dde8714eeb802bbeb510", kill_on_drop: false }` [INFO] [stdout] ffb6e1a748e77c1512497ae8a9a756002ca79a0321f6dde8714eeb802bbeb510