[INFO] fetching crate pco_cli 0.3.0... [INFO] checking pco_cli-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pco_cli 0.3.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate pco_cli 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pco_cli 0.3.0 [INFO] finished tweaking crates.io crate pco_cli 0.3.0 [INFO] tweaked toml for crates.io crate pco_cli 0.3.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate pco_cli 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 107641800f10e96bd26a502844afedc329777bb99233b3dbecd9f00e332b97e4 [INFO] running `Command { std: "docker" "start" "-a" "107641800f10e96bd26a502844afedc329777bb99233b3dbecd9f00e332b97e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "107641800f10e96bd26a502844afedc329777bb99233b3dbecd9f00e332b97e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "107641800f10e96bd26a502844afedc329777bb99233b3dbecd9f00e332b97e4", kill_on_drop: false }` [INFO] [stdout] 107641800f10e96bd26a502844afedc329777bb99233b3dbecd9f00e332b97e4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9bffa20a1104e4cf8f99e916950902163daab2ef04e2167e1b8ea3d8fae56cd7 [INFO] running `Command { std: "docker" "start" "-a" "9bffa20a1104e4cf8f99e916950902163daab2ef04e2167e1b8ea3d8fae56cd7", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking arrow-schema v49.0.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling zstd-safe v7.0.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking winnow v0.6.5 [INFO] [stderr] Checking bytecount v0.6.7 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking integer-encoding v3.0.4 [INFO] [stderr] Compiling flatbuffers v23.5.26 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking indexmap v2.2.5 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Compiling syn v2.0.53 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking papergrid v0.11.0 [INFO] [stderr] Compiling jobserver v0.1.28 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking better_io v0.1.0 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking chrono v0.4.35 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking pco v0.3.0 [INFO] [stderr] Checking num-iter v0.1.44 [INFO] [stderr] Checking thrift v0.17.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling zstd-sys v2.0.9+zstd.1.5.5 [INFO] [stderr] Checking num v0.4.1 [INFO] [stderr] Checking arrow-buffer v49.0.0 [INFO] [stderr] Compiling tabled_derive v0.7.0 [INFO] [stderr] Checking arrow-data v49.0.0 [INFO] [stderr] Checking arrow-array v49.0.0 [INFO] [stderr] Checking tabled v0.15.0 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling clap_derive v4.5.3 [INFO] [stderr] Checking arrow-select v49.0.0 [INFO] [stderr] Checking arrow-cast v49.0.0 [INFO] [stderr] Checking arrow-ord v49.0.0 [INFO] [stderr] Checking arrow-ipc v49.0.0 [INFO] [stderr] Checking arrow-string v49.0.0 [INFO] [stderr] Checking arrow-arith v49.0.0 [INFO] [stderr] Checking arrow-row v49.0.0 [INFO] [stderr] Checking clap v4.5.3 [INFO] [stderr] Checking zstd v0.13.0 [INFO] [stderr] Checking parquet v49.0.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking toml_edit v0.22.8 [INFO] [stderr] Checking arrow-csv v49.0.0 [INFO] [stderr] Checking arrow v49.0.0 [INFO] [stderr] Checking toml v0.8.12 [INFO] [stderr] Checking pco_cli v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench/mod.rs:55:22 [INFO] [stdout] | [INFO] [stdout] 55 | #[arg(long, short, default_values_t = Vec::::new(), value_delimiter = ',')] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench/mod.rs:55:22 [INFO] [stdout] | [INFO] [stdout] 55 | #[arg(long, short, default_values_t = Vec::::new(), value_delimiter = ',')] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench/mod.rs:59:15 [INFO] [stdout] | [INFO] [stdout] 59 | #[arg(long, default_values_t = Vec::::new(), value_parser = parse::arrow_dtype, value_delimiter = ',')] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench/mod.rs:59:15 [INFO] [stdout] | [INFO] [stdout] 59 | #[arg(long, default_values_t = Vec::::new(), value_parser = parse::arrow_dtype, value_delimiter = ',')] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench/codecs/mod.rs:101:3 [INFO] [stdout] | [INFO] [stdout] 100 | let mut default_arg_matches = ::command().get_matches_from(empty_args); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | ::from_arg_matches_mut(&mut default_arg_matches).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench/codecs/mod.rs:129:8 [INFO] [stdout] | [INFO] [stdout] 113 | let mut matches = Self::command() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let codec = Self::from_arg_matches_mut(&mut matches)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | Ok(Box::new(codec)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench/codecs/mod.rs:253:8 [INFO] [stdout] | [INFO] [stdout] 232 | let codec: Result> = match name { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | Ok(Self(codec?)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:105:6 [INFO] [stdout] | [INFO] [stdout] 95 | fn schema_from_field_paths(mut field_paths: Vec<(Field, PathBuf)>) -> Result { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | let fields = field_paths.into_iter().map(|(f, _)| f).collect::>(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Ok(Schema::new_with_metadata(fields, metadata)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:151:6 [INFO] [stdout] | [INFO] [stdout] 149 | let dtype = parse::arrow_dtype(dtype_str)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | let name = split.collect::>().join("_"); [INFO] [stdout] 151 | Ok(Some(Field::new(name, dtype, false))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:187:6 [INFO] [stdout] | [INFO] [stdout] 161 | let inferred_schema = csv::infer_schema_from_files( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | let mut fields = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | Ok(Schema::new(fields)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:238:3 [INFO] [stdout] | [INFO] [stdout] 238 | / match file_opt.format()? { [INFO] [stdout] 239 | | // maybe one day I should structure this better [INFO] [stdout] 240 | | Format::Binary => infer_binary_schema(path), [INFO] [stdout] 241 | | Format::Csv => infer_csv_schema(col_opt, file_opt), [INFO] [stdout] ... | [INFO] [stdout] 244 | | Format::Wav => infer_wav_schema(path), [INFO] [stdout] 245 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:297:8 [INFO] [stdout] | [INFO] [stdout] 296 | let dtype = schema.field(col_idx).data_type().clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | Ok(BinaryColumnReader { [INFO] [stdout] | ________^ [INFO] [stdout] 298 | | col_path, [INFO] [stdout] 299 | | dtype, [INFO] [stdout] 300 | | did_read: false, [INFO] [stdout] 301 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:347:8 [INFO] [stdout] | [INFO] [stdout] 338 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | let batch_reader_builder = ParquetRecordBatchReaderBuilder::try_new(file)?; [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | let parquet_schema = parquet::arrow::arrow_to_parquet_schema(schema)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | let batch_reader = batch_reader_builder [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 347 | Ok(Self(batch_reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:358:10 [INFO] [stdout] | [INFO] [stdout] 355 | self.0.next().map(|batch_result| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 356 | let batch = batch_result?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | // 0 because we told arrow to only read the exact column we want [INFO] [stdout] 358 | Ok(batch.column(0).clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:375:8 [INFO] [stdout] | [INFO] [stdout] 370 | let csv_reader = csv::ReaderBuilder::new(SchemaRef::new(schema.clone())) [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 375 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 376 | | csv_reader, [INFO] [stdout] 377 | | col_idx, [INFO] [stdout] 378 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:388:10 [INFO] [stdout] | [INFO] [stdout] 386 | self.csv_reader.next().map(|batch_result| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | let batch = batch_result?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 388 | Ok(batch.column(self.col_idx).clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pco_cli` (bin "pcodec") due to 17 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench/mod.rs:55:22 [INFO] [stdout] | [INFO] [stdout] 55 | #[arg(long, short, default_values_t = Vec::::new(), value_delimiter = ',')] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench/mod.rs:55:22 [INFO] [stdout] | [INFO] [stdout] 55 | #[arg(long, short, default_values_t = Vec::::new(), value_delimiter = ',')] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench/mod.rs:59:15 [INFO] [stdout] | [INFO] [stdout] 59 | #[arg(long, default_values_t = Vec::::new(), value_parser = parse::arrow_dtype, value_delimiter = ',')] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench/mod.rs:59:15 [INFO] [stdout] | [INFO] [stdout] 59 | #[arg(long, default_values_t = Vec::::new(), value_parser = parse::arrow_dtype, value_delimiter = ',')] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench/codecs/mod.rs:101:3 [INFO] [stdout] | [INFO] [stdout] 100 | let mut default_arg_matches = ::command().get_matches_from(empty_args); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | ::from_arg_matches_mut(&mut default_arg_matches).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench/codecs/mod.rs:129:8 [INFO] [stdout] | [INFO] [stdout] 113 | let mut matches = Self::command() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let codec = Self::from_arg_matches_mut(&mut matches)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | Ok(Box::new(codec)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench/codecs/mod.rs:253:8 [INFO] [stdout] | [INFO] [stdout] 232 | let codec: Result> = match name { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | Ok(Self(codec?)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:105:6 [INFO] [stdout] | [INFO] [stdout] 95 | fn schema_from_field_paths(mut field_paths: Vec<(Field, PathBuf)>) -> Result { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | let fields = field_paths.into_iter().map(|(f, _)| f).collect::>(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Ok(Schema::new_with_metadata(fields, metadata)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:151:6 [INFO] [stdout] | [INFO] [stdout] 149 | let dtype = parse::arrow_dtype(dtype_str)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | let name = split.collect::>().join("_"); [INFO] [stdout] 151 | Ok(Some(Field::new(name, dtype, false))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:187:6 [INFO] [stdout] | [INFO] [stdout] 161 | let inferred_schema = csv::infer_schema_from_files( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | let mut fields = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | Ok(Schema::new(fields)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:238:3 [INFO] [stdout] | [INFO] [stdout] 238 | / match file_opt.format()? { [INFO] [stdout] 239 | | // maybe one day I should structure this better [INFO] [stdout] 240 | | Format::Binary => infer_binary_schema(path), [INFO] [stdout] 241 | | Format::Csv => infer_csv_schema(col_opt, file_opt), [INFO] [stdout] ... | [INFO] [stdout] 244 | | Format::Wav => infer_wav_schema(path), [INFO] [stdout] 245 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:297:8 [INFO] [stdout] | [INFO] [stdout] 296 | let dtype = schema.field(col_idx).data_type().clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | Ok(BinaryColumnReader { [INFO] [stdout] | ________^ [INFO] [stdout] 298 | | col_path, [INFO] [stdout] 299 | | dtype, [INFO] [stdout] 300 | | did_read: false, [INFO] [stdout] 301 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:347:8 [INFO] [stdout] | [INFO] [stdout] 338 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | let batch_reader_builder = ParquetRecordBatchReaderBuilder::try_new(file)?; [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | let parquet_schema = parquet::arrow::arrow_to_parquet_schema(schema)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | let batch_reader = batch_reader_builder [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 347 | Ok(Self(batch_reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:358:10 [INFO] [stdout] | [INFO] [stdout] 355 | self.0.next().map(|batch_result| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 356 | let batch = batch_result?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | // 0 because we told arrow to only read the exact column we want [INFO] [stdout] 358 | Ok(batch.column(0).clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:375:8 [INFO] [stdout] | [INFO] [stdout] 370 | let csv_reader = csv::ReaderBuilder::new(SchemaRef::new(schema.clone())) [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 375 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 376 | | csv_reader, [INFO] [stdout] 377 | | col_idx, [INFO] [stdout] 378 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/mod.rs:388:10 [INFO] [stdout] | [INFO] [stdout] 386 | self.csv_reader.next().map(|batch_result| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | let batch = batch_result?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 388 | Ok(batch.column(self.col_idx).clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pco_cli` (bin "pcodec" test) due to 17 previous errors [INFO] running `Command { std: "docker" "inspect" "9bffa20a1104e4cf8f99e916950902163daab2ef04e2167e1b8ea3d8fae56cd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9bffa20a1104e4cf8f99e916950902163daab2ef04e2167e1b8ea3d8fae56cd7", kill_on_drop: false }` [INFO] [stdout] 9bffa20a1104e4cf8f99e916950902163daab2ef04e2167e1b8ea3d8fae56cd7