[INFO] fetching crate pcap-file 3.0.0-rc1... [INFO] checking pcap-file-3.0.0-rc1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pcap-file 3.0.0-rc1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate pcap-file 3.0.0-rc1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pcap-file 3.0.0-rc1 [INFO] finished tweaking crates.io crate pcap-file 3.0.0-rc1 [INFO] tweaked toml for crates.io crate pcap-file 3.0.0-rc1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 84 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (latest: v4.5.16) [INFO] [stderr] Adding clap_lex v0.2.4 (latest: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (latest: v7.0.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d756efab787d72d355b354c7c65e43ec9991b11dc41af6328984c87b10280461 [INFO] running `Command { std: "docker" "start" "-a" "d756efab787d72d355b354c7c65e43ec9991b11dc41af6328984c87b10280461", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d756efab787d72d355b354c7c65e43ec9991b11dc41af6328984c87b10280461", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d756efab787d72d355b354c7c65e43ec9991b11dc41af6328984c87b10280461", kill_on_drop: false }` [INFO] [stdout] d756efab787d72d355b354c7c65e43ec9991b11dc41af6328984c87b10280461 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f54b9a79ba4dc1412e6a1b4241a0209049501fe548fd4b2839962a3c5776ba96 [INFO] running `Command { std: "docker" "start" "-a" "f54b9a79ba4dc1412e6a1b4241a0209049501fe548fd4b2839962a3c5776ba96", kill_on_drop: false }` [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking byteorder_slice v3.0.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling derive-into-owned v0.2.0 [INFO] [stderr] Checking pcap-file v3.0.0-rc1 (/opt/rustwide/workdir) [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stdout] warning: trait `RuntimeByteorder` is never used [INFO] [stdout] --> src/common.rs:58:18 [INFO] [stdout] | [INFO] [stdout] 58 | pub(crate) trait RuntimeByteorder: ByteOrder { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pcap/reader.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(reader: R) -> Result, PcapError> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let mut reader = ReadBuffer::new(reader); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(PcapReader { parser, reader }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pcap/writer.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn with_header(mut writer: W, header: PcapHeader) -> PcapResult> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Ok(PcapWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 79 | | endianness: header.endianness, [INFO] [stdout] 80 | | snaplen: header.snaplen, [INFO] [stdout] 81 | | ts_resolution: header.ts_resolution, [INFO] [stdout] 82 | | writer, [INFO] [stdout] 83 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pcapng/blocks/opt_common.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 24 | let mut options = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Err(PcapError::InvalidField("Invalid option")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pcapng/reader.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(reader: R) -> Result, PcapError> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let mut reader = ReadBuffer::new(reader); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let parser = reader.parse_with(PcapNgParser::new)?; [INFO] [stdout] 43 | Ok(Self { parser, reader }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pcapng/writer.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn with_section_header(mut writer: W, section: SectionHeaderBlock<'static>) -> PcapResult { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | Ok(Self { section, interfaces: Vec::new(), ts_resolutions: Vec::new(), writer }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pcap-file` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "f54b9a79ba4dc1412e6a1b4241a0209049501fe548fd4b2839962a3c5776ba96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f54b9a79ba4dc1412e6a1b4241a0209049501fe548fd4b2839962a3c5776ba96", kill_on_drop: false }` [INFO] [stdout] f54b9a79ba4dc1412e6a1b4241a0209049501fe548fd4b2839962a3c5776ba96