[INFO] fetching crate pcap 2.1.0... [INFO] checking pcap-2.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pcap 2.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate pcap 2.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pcap 2.1.0 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate pcap 2.1.0 [INFO] tweaked toml for crates.io crate pcap 2.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate pcap 2.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5dbf3668638f3c720145977f68f3a5e5a65e869fdf5d9da1c65cbab821e49dec [INFO] running `Command { std: "docker" "start" "-a" "5dbf3668638f3c720145977f68f3a5e5a65e869fdf5d9da1c65cbab821e49dec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5dbf3668638f3c720145977f68f3a5e5a65e869fdf5d9da1c65cbab821e49dec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5dbf3668638f3c720145977f68f3a5e5a65e869fdf5d9da1c65cbab821e49dec", kill_on_drop: false }` [INFO] [stdout] 5dbf3668638f3c720145977f68f3a5e5a65e869fdf5d9da1c65cbab821e49dec [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0fc3b505f4ed682e65bf74e466a563bdf27a345893238ca5ea86215d3f2532e4 [INFO] running `Command { std: "docker" "start" "-a" "0fc3b505f4ed682e65bf74e466a563bdf27a345893238ca5ea86215d3f2532e4", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling memchr v2.7.2 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling regex-syntax v0.7.5 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling libloading v0.8.3 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking tokio-fs v0.1.7 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking tokio-uds v0.2.7 [INFO] [stderr] Checking tokio-udp v0.1.6 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking predicates-core v1.0.5 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Compiling cc v1.0.95 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking scoped-tls v0.1.2 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Compiling regex-automata v0.3.9 [INFO] [stderr] Checking tokio-core v0.1.18 [INFO] [stderr] Checking predicates-tree v1.0.7 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Compiling tun-tap v0.1.4 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking etherparse v0.13.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling regex v1.9.6 [INFO] [stderr] Compiling pcap v2.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/capture/mod.rs:116:28 [INFO] [stdout] | [INFO] [stdout] 112 | fn new_raw(path: Option<&str>, func: F) -> Result, Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | Error::with_errbuf(|err| { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 117 | | let handle = match path { [INFO] [stdout] 118 | | None => func(ptr::null(), err), [INFO] [stdout] 119 | | Some(path) => { [INFO] [stdout] ... | [INFO] [stdout] 126 | | )) [INFO] [stdout] 127 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/capture/mod.rs:124:16 [INFO] [stdout] | [INFO] [stdout] 112 | fn new_raw(path: Option<&str>, func: F) -> Result, Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let path = CString::new(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Ok(Capture::from( [INFO] [stdout] | ________________^ [INFO] [stdout] 125 | | NonNull::::new(handle).ok_or_else(|| unsafe { Error::new(err) })?, [INFO] [stdout] 126 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/capture/activated/mod.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn savefile>(&self, path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let name = CString::new(path.as_ref().to_str().unwrap())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | Ok(Savefile::from(handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/capture/activated/mod.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn savefile_append>(&self, path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let name = CString::new(path.as_ref().to_str().unwrap())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(Savefile::from(handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/capture/activated/active.rs:23:28 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn setnonblock(mut self) -> Result, Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Error::with_errbuf(|err| unsafe { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 24 | | if raw::pcap_setnonblock(self.handle.as_ptr(), 1, err) != 0 { [INFO] [stdout] 25 | | return Err(Error::new(err)); [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | self.nonblock = true; [INFO] [stdout] 28 | | Ok(self) [INFO] [stdout] 29 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pcap` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "0fc3b505f4ed682e65bf74e466a563bdf27a345893238ca5ea86215d3f2532e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0fc3b505f4ed682e65bf74e466a563bdf27a345893238ca5ea86215d3f2532e4", kill_on_drop: false }` [INFO] [stdout] 0fc3b505f4ed682e65bf74e466a563bdf27a345893238ca5ea86215d3f2532e4