[INFO] fetching crate pb-rs 0.10.0... [INFO] checking pb-rs-0.10.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pb-rs 0.10.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate pb-rs 0.10.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pb-rs 0.10.0 [INFO] finished tweaking crates.io crate pb-rs 0.10.0 [INFO] tweaked toml for crates.io crate pb-rs 0.10.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate pb-rs 0.10.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e17d5d6c3b47145e1718d18e096dd74f7dd43275d241de57574a685f5932711a [INFO] running `Command { std: "docker" "start" "-a" "e17d5d6c3b47145e1718d18e096dd74f7dd43275d241de57574a685f5932711a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e17d5d6c3b47145e1718d18e096dd74f7dd43275d241de57574a685f5932711a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e17d5d6c3b47145e1718d18e096dd74f7dd43275d241de57574a685f5932711a", kill_on_drop: false }` [INFO] [stdout] e17d5d6c3b47145e1718d18e096dd74f7dd43275d241de57574a685f5932711a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 51032aa695ce1217340384bdf7df2945b0e23668bb069b0203d9ee96ed553c37 [INFO] running `Command { std: "docker" "start" "-a" "51032aa695ce1217340384bdf7df2945b0e23668bb069b0203d9ee96ed553c37", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking regex v1.7.0 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking pb-rs v0.10.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/types.rs:1969:13 [INFO] [stdout] | [INFO] [stdout] 1969 | for mut m in &mut desc.messages { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/types.rs:1969:13 [INFO] [stdout] | [INFO] [stdout] 1969 | for mut m in &mut desc.messages { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:199:48 [INFO] [stdout] | [INFO] [stdout] 199 | map(map_field, |(k, v)| FieldType::Map(Box::new(k), Box::new(v))), [INFO] [stdout] | ------ ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:199:61 [INFO] [stdout] | [INFO] [stdout] 199 | map(map_field, |(k, v)| FieldType::Map(Box::new(k), Box::new(v))), [INFO] [stdout] | ------ ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:908:26 [INFO] [stdout] | [INFO] [stdout] 908 | .any(|m| m.all_fields().any(|f| (f.typ.has_bytes_and_string()))) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:927:22 [INFO] [stdout] | [INFO] [stdout] 927 | .any(|m| m.all_fields().any(|f| f.typ.is_map())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pb-rs` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:199:48 [INFO] [stdout] | [INFO] [stdout] 199 | map(map_field, |(k, v)| FieldType::Map(Box::new(k), Box::new(v))), [INFO] [stdout] | ------ ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:199:61 [INFO] [stdout] | [INFO] [stdout] 199 | map(map_field, |(k, v)| FieldType::Map(Box::new(k), Box::new(v))), [INFO] [stdout] | ------ ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:908:26 [INFO] [stdout] | [INFO] [stdout] 908 | .any(|m| m.all_fields().any(|f| (f.typ.has_bytes_and_string()))) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:927:22 [INFO] [stdout] | [INFO] [stdout] 927 | .any(|m| m.all_fields().any(|f| f.typ.is_map())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pb-rs` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "51032aa695ce1217340384bdf7df2945b0e23668bb069b0203d9ee96ed553c37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51032aa695ce1217340384bdf7df2945b0e23668bb069b0203d9ee96ed553c37", kill_on_drop: false }` [INFO] [stdout] 51032aa695ce1217340384bdf7df2945b0e23668bb069b0203d9ee96ed553c37