[INFO] fetching crate patica 0.0.3... [INFO] checking patica-0.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate patica 0.0.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate patica 0.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate patica 0.0.3 [INFO] finished tweaking crates.io crate patica 0.0.3 [INFO] tweaked toml for crates.io crate patica 0.0.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate patica 0.0.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] faa202e3a30e91f658825b28ea913b60c44cb1805f0598780ca1bf220c7502b4 [INFO] running `Command { std: "docker" "start" "-a" "faa202e3a30e91f658825b28ea913b60c44cb1805f0598780ca1bf220c7502b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "faa202e3a30e91f658825b28ea913b60c44cb1805f0598780ca1bf220c7502b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "faa202e3a30e91f658825b28ea913b60c44cb1805f0598780ca1bf220c7502b4", kill_on_drop: false }` [INFO] [stdout] faa202e3a30e91f658825b28ea913b60c44cb1805f0598780ca1bf220c7502b4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0526e7a71bd20a43ad233ee01c5fe72d37c06033ac9f4676c313fed3edfacd43 [INFO] running `Command { std: "docker" "start" "-a" "0526e7a71bd20a43ad233ee01c5fe72d37c06033ac9f4676c313fed3edfacd43", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking anstyle v1.0.3 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking copic_colors v0.1.1 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking anstream v0.5.0 [INFO] [stderr] Checking clap_builder v4.4.4 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking termion v2.0.1 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Checking clap v4.4.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking orfail v1.1.0 [INFO] [stderr] Checking pagurus v0.7.3 [INFO] [stderr] Checking pati v0.1.0 [INFO] [stderr] Checking pagurus_tui v0.7.3 [INFO] [stderr] Checking patica v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:163:12 [INFO] [stdout] | [INFO] [stdout] 160 | let file = std::fs::File::open(path).or_fail()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let reader = CommandReader::new(BufReader::new(file)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | let canvas = VersionedCanvas::default(); // TODO: use Canvas [INFO] [stdout] 163 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 164 | | path: path.clone(), [INFO] [stdout] 165 | | canvas, [INFO] [stdout] 166 | | reader, [INFO] [stdout] 167 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 100 | fn new(stream: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | Self { [INFO] [stdout] 102 | reader: BufReader::new(stream), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 137 | let stream = BufWriter::new(TcpStream::connect(("127.0.0.1", port)).or_fail()?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | Ok(Self { stream }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `patica` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:163:12 [INFO] [stdout] | [INFO] [stdout] 160 | let file = std::fs::File::open(path).or_fail()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let reader = CommandReader::new(BufReader::new(file)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | let canvas = VersionedCanvas::default(); // TODO: use Canvas [INFO] [stdout] 163 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 164 | | path: path.clone(), [INFO] [stdout] 165 | | canvas, [INFO] [stdout] 166 | | reader, [INFO] [stdout] 167 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 100 | fn new(stream: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | Self { [INFO] [stdout] 102 | reader: BufReader::new(stream), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 137 | let stream = BufWriter::new(TcpStream::connect(("127.0.0.1", port)).or_fail()?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | Ok(Self { stream }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `patica` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "0526e7a71bd20a43ad233ee01c5fe72d37c06033ac9f4676c313fed3edfacd43", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0526e7a71bd20a43ad233ee01c5fe72d37c06033ac9f4676c313fed3edfacd43", kill_on_drop: false }` [INFO] [stdout] 0526e7a71bd20a43ad233ee01c5fe72d37c06033ac9f4676c313fed3edfacd43