[INFO] fetching crate pathfinder_renderer 0.5.0... [INFO] checking pathfinder_renderer-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pathfinder_renderer 0.5.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate pathfinder_renderer 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pathfinder_renderer 0.5.0 [INFO] finished tweaking crates.io crate pathfinder_renderer 0.5.0 [INFO] tweaked toml for crates.io crate pathfinder_renderer 0.5.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 75 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.3.8 (latest: v0.8.11) [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding deflate v0.8.6 (latest: v1.0.0) [INFO] [stderr] Adding env_logger v0.7.1 (latest: v0.11.5) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hashbrown v0.7.2 (latest: v0.14.5) [INFO] [stderr] Adding image v0.23.14 (latest: v0.25.2) [INFO] [stderr] Adding miniz_oxide v0.3.7 (latest: v0.8.0) [INFO] [stderr] Adding num-rational v0.3.2 (latest: v0.4.2) [INFO] [stderr] Adding png v0.16.8 (latest: v0.17.13) [INFO] [stderr] Adding quickcheck v0.9.2 (latest: v1.0.3) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 51b4a420961f41f1c134ada083bb52d254e0ae1a9d27255fe36eb809cc54981b [INFO] running `Command { std: "docker" "start" "-a" "51b4a420961f41f1c134ada083bb52d254e0ae1a9d27255fe36eb809cc54981b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "51b4a420961f41f1c134ada083bb52d254e0ae1a9d27255fe36eb809cc54981b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51b4a420961f41f1c134ada083bb52d254e0ae1a9d27255fe36eb809cc54981b", kill_on_drop: false }` [INFO] [stdout] 51b4a420961f41f1c134ada083bb52d254e0ae1a9d27255fe36eb809cc54981b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 68c80db4120d5a7c9a1d8372328bc8cd7b8a721a0bc2e97d8c65b31848805384 [INFO] running `Command { std: "docker" "start" "-a" "68c80db4120d5a7c9a1d8372328bc8cd7b8a721a0bc2e97d8c65b31848805384", kill_on_drop: false }` [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling pathfinder_resources v0.5.0 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling hashbrown v0.7.2 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking ahash v0.3.8 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Compiling pathfinder_simd v0.5.4 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking pathfinder_geometry v0.5.1 [INFO] [stderr] Checking pathfinder_color v0.5.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking pathfinder_gpu v0.5.0 [INFO] [stderr] Checking pathfinder_content v0.5.0 [INFO] [stderr] Checking pathfinder_ui v0.5.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking pathfinder_renderer v0.5.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking quickcheck v0.9.2 [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/gpu/renderer.rs:490:13 [INFO] [stdout] | [INFO] [stdout] 490 | let mut render_target = &mut self.render_targets[render_target_id.render_target as usize]; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/paint.rs:445:17 [INFO] [stdout] | [INFO] [stdout] 445 | let mut color_texture_metadata = match metadata.color_texture_metadata { [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/paint.rs:667:13 [INFO] [stdout] | [INFO] [stdout] 667 | let mut data = self.tiles.last_mut().unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `color_texture_1_uniform` is never read [INFO] [stdout] --> src/gpu/shaders.rs:317:9 [INFO] [stdout] | [INFO] [stdout] 309 | pub struct TileProgram where D: Device { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 317 | pub color_texture_1_uniform: D::Uniform, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/scene.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct Scene { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 37 | id: SceneId, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `Scene` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/scene.rs:307:5 [INFO] [stdout] | [INFO] [stdout] 305 | pub struct RenderTarget { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 306 | size: Vector2I, [INFO] [stdout] 307 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RenderTarget` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Atlas` is never constructed [INFO] [stdout] --> src/allocator.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 53 | pub enum AllocationMode { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] 54 | Atlas, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AllocationMode` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bounds` is never read [INFO] [stdout] --> src/builder.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 46 | pub(crate) struct ObjectBuilder { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 49 | pub bounds: RectF, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ObjectBuilder` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `sampling_flags_1` is never read [INFO] [stdout] --> src/builder.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 53 | struct BuiltDrawPath { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 58 | sampling_flags_1: TextureSamplingFlags, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BuiltDrawPath` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `solid_tile_count` and `alpha_tile_count` are never read [INFO] [stdout] --> src/builder.rs:601:9 [INFO] [stdout] | [INFO] [stdout] 600 | pub struct TileStats { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 601 | pub solid_tile_count: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 602 | pub alpha_tile_count: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TileStats` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/concurrent/executor.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 27 | fn build_vector(&self, length: usize, builder: F) -> Vec [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | where T: Send, F: Fn(usize) -> T + Send + Sync { [INFO] [stdout] 29 | (0..length).into_iter().map(builder).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/concurrent/rayon.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 19 | fn build_vector(&self, length: usize, builder: F) -> Vec [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | where T: Send, F: Fn(usize) -> T + Send + Sync { [INFO] [stdout] 21 | (0..length).into_par_iter().map(builder).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/concurrent/scene_proxy.rs:40:32 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(executor: E) -> SceneProxy where E: Executor + Send + 'static { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | SceneProxy::from_scene(Scene::new(), executor) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/concurrent/scene_proxy.rs:70:53 [INFO] [stdout] | [INFO] [stdout] 69 | let (sender, receiver) = mpsc::sync_channel(MAX_MESSAGES_IN_FLIGHT); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let listener = Box::new(move |command| drop(sender.send(command))); [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/concurrent/scene_proxy.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 97 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | self.sender.send(MainToWorkerMsg::CopyScene(sender)).unwrap(); [INFO] [stdout] 99 | receiver.recv().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpu/renderer.rs:280:28 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn new(device: D, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | resources: &dyn ResourceLoader, [INFO] [stdout] 163 | dest_framebuffer: DestFramebuffer, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let blit_program = BlitProgram::new(&device, resources); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | let fill_program = FillProgram::new(&device, resources); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let tile_program = TileProgram::new(&device, resources); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | let tile_copy_program = CopyTileProgram::new(&device, resources); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | let stencil_program = StencilProgram::new(&device, resources); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | let reprojection_program = ReprojectionProgram::new(&device, resources); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | [INFO] [stdout] 173 | let area_lut_texture = device.create_texture_from_png(resources, "area-lut"); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | let gamma_lut_texture = device.create_texture_from_png(resources, "gamma-lut"); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | [INFO] [stdout] 176 | let texture_metadata_texture = device.create_texture( [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let quad_vertex_positions_buffer = device.create_buffer(); [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let quad_vertex_indices_buffer = device.create_buffer(); [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let quads_vertex_indices_buffer = device.create_buffer(); [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | let tile_vertex_buffer = device.create_buffer(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | [INFO] [stdout] 197 | let blit_vertex_array = BlitVertexArray::new( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let fill_vertex_array = FillVertexArray::new( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | let tile_vertex_array = TileVertexArray::new( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | let tile_copy_vertex_array = CopyTileVertexArray::new( [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | let stencil_vertex_array = StencilVertexArray::new(&device, &stencil_program); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let reprojection_vertex_array = ReprojectionVertexArray::new( [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let dest_blend_texture = device.create_texture(TextureFormat::RGBA8, window_size); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | let dest_blend_framebuffer = device.create_framebuffer(dest_blend_texture); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | let intermediate_dest_texture = device.create_texture(TextureFormat::RGBA8, window_size); [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | let intermediate_dest_framebuffer = device.create_framebuffer(intermediate_dest_texture); [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | [INFO] [stdout] 236 | let mut timer_queries = vec![]; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | let debug_ui_presenter = DebugUIPresenter::new(&device, resources, window_size); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | current_timer: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpu/renderer.rs:281:29 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn new(device: D, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | resources: &dyn ResourceLoader, [INFO] [stdout] 163 | dest_framebuffer: DestFramebuffer, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let blit_program = BlitProgram::new(&device, resources); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | let fill_program = FillProgram::new(&device, resources); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let tile_program = TileProgram::new(&device, resources); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | let tile_copy_program = CopyTileProgram::new(&device, resources); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | let stencil_program = StencilProgram::new(&device, resources); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | let reprojection_program = ReprojectionProgram::new(&device, resources); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | [INFO] [stdout] 173 | let area_lut_texture = device.create_texture_from_png(resources, "area-lut"); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | let gamma_lut_texture = device.create_texture_from_png(resources, "gamma-lut"); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | [INFO] [stdout] 176 | let texture_metadata_texture = device.create_texture( [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let quad_vertex_positions_buffer = device.create_buffer(); [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let quad_vertex_indices_buffer = device.create_buffer(); [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let quads_vertex_indices_buffer = device.create_buffer(); [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | let tile_vertex_buffer = device.create_buffer(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | [INFO] [stdout] 197 | let blit_vertex_array = BlitVertexArray::new( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let fill_vertex_array = FillVertexArray::new( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | let tile_vertex_array = TileVertexArray::new( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | let tile_copy_vertex_array = CopyTileVertexArray::new( [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | let stencil_vertex_array = StencilVertexArray::new(&device, &stencil_program); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let reprojection_vertex_array = ReprojectionVertexArray::new( [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let dest_blend_texture = device.create_texture(TextureFormat::RGBA8, window_size); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | let dest_blend_framebuffer = device.create_framebuffer(dest_blend_texture); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | let intermediate_dest_texture = device.create_texture(TextureFormat::RGBA8, window_size); [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | let intermediate_dest_framebuffer = device.create_framebuffer(intermediate_dest_texture); [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | [INFO] [stdout] 236 | let mut timer_queries = vec![]; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | let debug_ui_presenter = DebugUIPresenter::new(&device, resources, window_size); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | pending_timers: VecDeque::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpu/renderer.rs:286:28 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn new(device: D, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | resources: &dyn ResourceLoader, [INFO] [stdout] 163 | dest_framebuffer: DestFramebuffer, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let blit_program = BlitProgram::new(&device, resources); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | let fill_program = FillProgram::new(&device, resources); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let tile_program = TileProgram::new(&device, resources); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | let tile_copy_program = CopyTileProgram::new(&device, resources); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | let stencil_program = StencilProgram::new(&device, resources); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | let reprojection_program = ReprojectionProgram::new(&device, resources); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | [INFO] [stdout] 173 | let area_lut_texture = device.create_texture_from_png(resources, "area-lut"); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | let gamma_lut_texture = device.create_texture_from_png(resources, "gamma-lut"); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | [INFO] [stdout] 176 | let texture_metadata_texture = device.create_texture( [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let quad_vertex_positions_buffer = device.create_buffer(); [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let quad_vertex_indices_buffer = device.create_buffer(); [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let quads_vertex_indices_buffer = device.create_buffer(); [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | let tile_vertex_buffer = device.create_buffer(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | [INFO] [stdout] 197 | let blit_vertex_array = BlitVertexArray::new( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let fill_vertex_array = FillVertexArray::new( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | let tile_vertex_array = TileVertexArray::new( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | let tile_copy_vertex_array = CopyTileVertexArray::new( [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | let stencil_vertex_array = StencilVertexArray::new(&device, &stencil_program); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let reprojection_vertex_array = ReprojectionVertexArray::new( [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let dest_blend_texture = device.create_texture(TextureFormat::RGBA8, window_size); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | let dest_blend_framebuffer = device.create_framebuffer(dest_blend_texture); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | let intermediate_dest_texture = device.create_texture(TextureFormat::RGBA8, window_size); [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | let intermediate_dest_framebuffer = device.create_framebuffer(intermediate_dest_texture); [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | [INFO] [stdout] 236 | let mut timer_queries = vec![]; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | let debug_ui_presenter = DebugUIPresenter::new(&device, resources, window_size); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | texture_cache: TextureCache::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paint.rs:127:22 [INFO] [stdout] | [INFO] [stdout] 124 | pub fn from_pattern(pattern: Pattern) -> Paint { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | overlay: Some(PaintOverlay { [INFO] [stdout] | ______________________^ [INFO] [stdout] 128 | | composite_op: PaintCompositeOp::SrcIn, [INFO] [stdout] 129 | | contents: PaintContents::Pattern(pattern), [INFO] [stdout] 130 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scene.rs:253:9 [INFO] [stdout] | [INFO] [stdout] 249 | listener: Box, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | SceneBuilder::new(self, &prepared_options, listener).build(executor) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tile_map.rs:40:19 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn from_builder(build: F, rect: RectI) -> DenseTileMap [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | data: (0..length).map(build).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pathfinder_renderer` (lib) due to 12 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "68c80db4120d5a7c9a1d8372328bc8cd7b8a721a0bc2e97d8c65b31848805384", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "68c80db4120d5a7c9a1d8372328bc8cd7b8a721a0bc2e97d8c65b31848805384", kill_on_drop: false }` [INFO] [stdout] 68c80db4120d5a7c9a1d8372328bc8cd7b8a721a0bc2e97d8c65b31848805384