[INFO] fetching crate patchkit 0.1.8... [INFO] checking patchkit-0.1.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate patchkit 0.1.8 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate patchkit 0.1.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate patchkit 0.1.8 [INFO] finished tweaking crates.io crate patchkit 0.1.8 [INFO] tweaked toml for crates.io crate patchkit 0.1.8 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 44 packages to latest compatible versions [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e25bedd4615706657d46bffd4b835fc2b8de13a3811cb5a7dc16586cbd2953c9 [INFO] running `Command { std: "docker" "start" "-a" "e25bedd4615706657d46bffd4b835fc2b8de13a3811cb5a7dc16586cbd2953c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e25bedd4615706657d46bffd4b835fc2b8de13a3811cb5a7dc16586cbd2953c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e25bedd4615706657d46bffd4b835fc2b8de13a3811cb5a7dc16586cbd2953c9", kill_on_drop: false }` [INFO] [stdout] e25bedd4615706657d46bffd4b835fc2b8de13a3811cb5a7dc16586cbd2953c9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 99a01cb5a8de0b1ab01aab2e515df1b0b8a3fac866226629a77637da99d9092d [INFO] running `Command { std: "docker" "start" "-a" "99a01cb5a8de0b1ab01aab2e515df1b0b8a3fac866226629a77637da99d9092d", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.3.0 [INFO] [stderr] Checking lazy-regex v3.3.0 [INFO] [stderr] Checking patchkit v0.1.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/timestamp.rs:31:47 [INFO] [stdout] | [INFO] [stdout] 31 | let dt = chrono::DateTime::::from_utc(chrono::NaiveDateTime::from_timestamp(secs, 0), chrono::Utc); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/timestamp.rs:31:79 [INFO] [stdout] | [INFO] [stdout] 31 | let dt = chrono::DateTime::::from_utc(chrono::NaiveDateTime::from_timestamp(secs, 0), chrono::Utc); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::NaiveDateTime::timestamp`: use `.and_utc().timestamp()` instead [INFO] [stdout] --> src/timestamp.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 85 | Ok((dt.timestamp(), offset)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `end` [INFO] [stdout] --> src/ed.rs:11:39 [INFO] [stdout] | [INFO] [stdout] 11 | EdHunk::Remove(start, end, expected) | EdHunk::Change(start, end, expected, _) => { [INFO] [stdout] | ^^^ ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 11 | EdHunk::Remove(start, _end, expected) | EdHunk::Change(start, _end, expected, _) => { [INFO] [stdout] | ~~~~ ~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `end` [INFO] [stdout] --> src/ed.rs:24:36 [INFO] [stdout] | [INFO] [stdout] 24 | EdHunk::Add(start, end, added) | EdHunk::Change(start, end, _, added) => { [INFO] [stdout] | ^^^ ^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 24 | EdHunk::Add(start, _end, added) | EdHunk::Change(start, _end, _, added) => { [INFO] [stdout] | ~~~~ ~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/timestamp.rs:31:47 [INFO] [stdout] | [INFO] [stdout] 31 | let dt = chrono::DateTime::::from_utc(chrono::NaiveDateTime::from_timestamp(secs, 0), chrono::Utc); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/timestamp.rs:31:79 [INFO] [stdout] | [INFO] [stdout] 31 | let dt = chrono::DateTime::::from_utc(chrono::NaiveDateTime::from_timestamp(secs, 0), chrono::Utc); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::NaiveDateTime::timestamp`: use `.and_utc().timestamp()` instead [INFO] [stdout] --> src/timestamp.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 85 | Ok((dt.timestamp(), offset)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `end` [INFO] [stdout] --> src/ed.rs:11:39 [INFO] [stdout] | [INFO] [stdout] 11 | EdHunk::Remove(start, end, expected) | EdHunk::Change(start, end, expected, _) => { [INFO] [stdout] | ^^^ ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 11 | EdHunk::Remove(start, _end, expected) | EdHunk::Change(start, _end, expected, _) => { [INFO] [stdout] | ~~~~ ~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `end` [INFO] [stdout] --> src/ed.rs:24:36 [INFO] [stdout] | [INFO] [stdout] 24 | EdHunk::Add(start, end, added) | EdHunk::Change(start, end, _, added) => { [INFO] [stdout] | ^^^ ^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 24 | EdHunk::Add(start, _end, added) | EdHunk::Change(start, _end, _, added) => { [INFO] [stdout] | ~~~~ ~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:97:24 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn iter_lines_handle_nl<'a, I>(mut iter_lines: I) -> impl Iterator + 'a [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | std::iter::from_fn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 98 | | for line in iter_lines.by_ref() { [INFO] [stdout] 99 | | if line == NO_NL { [INFO] [stdout] 100 | | if let Some(last) = last_line.as_mut() { [INFO] [stdout] ... | [INFO] [stdout] 115 | | last_line.take() [INFO] [stdout] 116 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:330:8 [INFO] [stdout] | [INFO] [stdout] 312 | pub fn parse_patch<'a, I>(iter_lines: I) -> Result, Error> [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | let mut iter_lines = iter_lines_handle_nl(iter_lines); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | Ok(Box::new(patch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:813:5 [INFO] [stdout] | [INFO] [stdout] 809 | pub fn parse_patches<'a, I>(iter: I) -> Result>, Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 813 | / iter_file_patch(iter) [INFO] [stdout] 814 | | .filter_map(|entry| match entry { [INFO] [stdout] 815 | | Ok(FileEntry::Patch(lines)) => match parse_patch(lines.iter().map(|l| l.as_slice())) { [INFO] [stdout] 816 | | Ok(patch) => Some(Ok(patch)), [INFO] [stdout] ... | [INFO] [stdout] 821 | | Err(e) => Some(Err(e)), [INFO] [stdout] 822 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/patch.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn parse_patches<'a, I>(iter: I) -> Result, crate::parse::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | / crate::parse::iter_file_patch(iter) [INFO] [stdout] 149 | | .filter_map(|entry| match entry { [INFO] [stdout] 150 | | Ok(crate::parse::FileEntry::Patch(lines)) => { [INFO] [stdout] 151 | | match Self::parse_patch(lines.iter().map(|l| l.as_slice())) { [INFO] [stdout] ... | [INFO] [stdout] 158 | | Err(e) => Some(Err(e)), [INFO] [stdout] 159 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/quilt.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn find_common_patch_suffix<'a>(names: impl Iterator) -> Option<&'a str> { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | / suffix_count [INFO] [stdout] 35 | | .into_iter() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `patchkit` (lib) due to 6 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:97:24 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn iter_lines_handle_nl<'a, I>(mut iter_lines: I) -> impl Iterator + 'a [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | std::iter::from_fn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 98 | | for line in iter_lines.by_ref() { [INFO] [stdout] 99 | | if line == NO_NL { [INFO] [stdout] 100 | | if let Some(last) = last_line.as_mut() { [INFO] [stdout] ... | [INFO] [stdout] 115 | | last_line.take() [INFO] [stdout] 116 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:330:8 [INFO] [stdout] | [INFO] [stdout] 312 | pub fn parse_patch<'a, I>(iter_lines: I) -> Result, Error> [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | let mut iter_lines = iter_lines_handle_nl(iter_lines); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | Ok(Box::new(patch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:813:5 [INFO] [stdout] | [INFO] [stdout] 809 | pub fn parse_patches<'a, I>(iter: I) -> Result>, Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 813 | / iter_file_patch(iter) [INFO] [stdout] 814 | | .filter_map(|entry| match entry { [INFO] [stdout] 815 | | Ok(FileEntry::Patch(lines)) => match parse_patch(lines.iter().map(|l| l.as_slice())) { [INFO] [stdout] 816 | | Ok(patch) => Some(Ok(patch)), [INFO] [stdout] ... | [INFO] [stdout] 821 | | Err(e) => Some(Err(e)), [INFO] [stdout] 822 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/patch.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn parse_patches<'a, I>(iter: I) -> Result, crate::parse::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | / crate::parse::iter_file_patch(iter) [INFO] [stdout] 149 | | .filter_map(|entry| match entry { [INFO] [stdout] 150 | | Ok(crate::parse::FileEntry::Patch(lines)) => { [INFO] [stdout] 151 | | match Self::parse_patch(lines.iter().map(|l| l.as_slice())) { [INFO] [stdout] ... | [INFO] [stdout] 158 | | Err(e) => Some(Err(e)), [INFO] [stdout] 159 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/quilt.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn find_common_patch_suffix<'a>(names: impl Iterator) -> Option<&'a str> { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | / suffix_count [INFO] [stdout] 35 | | .into_iter() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `patchkit` (lib test) due to 6 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "99a01cb5a8de0b1ab01aab2e515df1b0b8a3fac866226629a77637da99d9092d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "99a01cb5a8de0b1ab01aab2e515df1b0b8a3fac866226629a77637da99d9092d", kill_on_drop: false }` [INFO] [stdout] 99a01cb5a8de0b1ab01aab2e515df1b0b8a3fac866226629a77637da99d9092d