[INFO] fetching crate partial-array 0.1.3... [INFO] checking partial-array-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate partial-array 0.1.3 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate partial-array 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate partial-array 0.1.3 [INFO] finished tweaking crates.io crate partial-array 0.1.3 [INFO] tweaked toml for crates.io crate partial-array 0.1.3 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] feb845a29ff414ade8d2a41c44790c460038daf4d7123ecc7b4e7bfc87d928a8 [INFO] running `Command { std: "docker" "start" "-a" "feb845a29ff414ade8d2a41c44790c460038daf4d7123ecc7b4e7bfc87d928a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "feb845a29ff414ade8d2a41c44790c460038daf4d7123ecc7b4e7bfc87d928a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "feb845a29ff414ade8d2a41c44790c460038daf4d7123ecc7b4e7bfc87d928a8", kill_on_drop: false }` [INFO] [stdout] feb845a29ff414ade8d2a41c44790c460038daf4d7123ecc7b4e7bfc87d928a8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f4c627aa6b3287eb80977a68e2c359f0ecd6d3738e2d22fa15000efe8c68f31a [INFO] running `Command { std: "docker" "start" "-a" "f4c627aa6b3287eb80977a68e2c359f0ecd6d3738e2d22fa15000efe8c68f31a", kill_on_drop: false }` [INFO] [stderr] Checking partial-array v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated associated function `core::array::IntoIter::::new`: use `IntoIterator::into_iter` instead [INFO] [stdout] --> src/lib.rs:396:32 [INFO] [stdout] | [INFO] [stdout] 396 | core::array::IntoIter::new(array).collect() [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `std::array::IntoIter::::new`: use `IntoIterator::into_iter` instead [INFO] [stdout] --> src/lib.rs:396:32 [INFO] [stdout] | [INFO] [stdout] 396 | core::array::IntoIter::new(array).collect() [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&&[T; M]` instead of dereferencing the inner type [INFO] [stdout] --> src/lib.rs:200:59 [INFO] [stdout] | [INFO] [stdout] 200 | self.len() == other.len() && self.deref() == other.deref() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&&[T; N]` instead of dereferencing the inner type [INFO] [stdout] --> src/lib.rs:220:42 [INFO] [stdout] | [INFO] [stdout] 220 | self.len() == other.len() && self.deref() == other.deref() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:235:59 [INFO] [stdout] | [INFO] [stdout] 235 | self.len() == other.len() && self.deref() == other.deref() [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[T]` does not implement `Deref`, so calling `deref` on `&[T]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:255:42 [INFO] [stdout] | [INFO] [stdout] 255 | self.len() == other.len() && self.deref() == other.deref() [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[T]` does not implement `Deref`, so calling `deref` on `&[T]` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:396:9 [INFO] [stdout] | [INFO] [stdout] 394 | fn from(array: [T; N]) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | // TODO: is there a more performant way? Maybe with unsafe [INFO] [stdout] 396 | core::array::IntoIter::new(array).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `partial-array` (lib) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&&[T; M]` instead of dereferencing the inner type [INFO] [stdout] --> src/lib.rs:200:59 [INFO] [stdout] | [INFO] [stdout] 200 | self.len() == other.len() && self.deref() == other.deref() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&&[T; N]` instead of dereferencing the inner type [INFO] [stdout] --> src/lib.rs:220:42 [INFO] [stdout] | [INFO] [stdout] 220 | self.len() == other.len() && self.deref() == other.deref() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:235:59 [INFO] [stdout] | [INFO] [stdout] 235 | self.len() == other.len() && self.deref() == other.deref() [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[T]` does not implement `Deref`, so calling `deref` on `&[T]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:255:42 [INFO] [stdout] | [INFO] [stdout] 255 | self.len() == other.len() && self.deref() == other.deref() [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[T]` does not implement `Deref`, so calling `deref` on `&[T]` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:396:9 [INFO] [stdout] | [INFO] [stdout] 394 | fn from(array: [T; N]) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | // TODO: is there a more performant way? Maybe with unsafe [INFO] [stdout] 396 | core::array::IntoIter::new(array).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `partial-array` (lib test) due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f4c627aa6b3287eb80977a68e2c359f0ecd6d3738e2d22fa15000efe8c68f31a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4c627aa6b3287eb80977a68e2c359f0ecd6d3738e2d22fa15000efe8c68f31a", kill_on_drop: false }` [INFO] [stdout] f4c627aa6b3287eb80977a68e2c359f0ecd6d3738e2d22fa15000efe8c68f31a