[INFO] fetching crate parterm 0.1.2... [INFO] checking parterm-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate parterm 0.1.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate parterm 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate parterm 0.1.2 [INFO] finished tweaking crates.io crate parterm 0.1.2 [INFO] tweaked toml for crates.io crate parterm 0.1.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate parterm 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 973d1466f806b8339e6e40ceb8e8b5484463e79ccc8f2098890b67d2f4d3c8d7 [INFO] running `Command { std: "docker" "start" "-a" "973d1466f806b8339e6e40ceb8e8b5484463e79ccc8f2098890b67d2f4d3c8d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "973d1466f806b8339e6e40ceb8e8b5484463e79ccc8f2098890b67d2f4d3c8d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "973d1466f806b8339e6e40ceb8e8b5484463e79ccc8f2098890b67d2f4d3c8d7", kill_on_drop: false }` [INFO] [stdout] 973d1466f806b8339e6e40ceb8e8b5484463e79ccc8f2098890b67d2f4d3c8d7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 135469edfda66eec27923233397fccaba3ac8b264439e7dd96840c0dc5ad3733 [INFO] running `Command { std: "docker" "start" "-a" "135469edfda66eec27923233397fccaba3ac8b264439e7dd96840c0dc5ad3733", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.85 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling rustversion v1.0.6 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking os_str_bytes v6.3.1 [INFO] [stderr] Checking iana-time-zone v0.1.53 [INFO] [stderr] Compiling signal-hook v0.3.13 [INFO] [stderr] Compiling anyhow v1.0.44 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Checking clap_lex v0.3.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking termion v1.5.5 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Checking nix v0.23.0 [INFO] [stderr] Checking clap v4.0.19 [INFO] [stderr] Checking chrono v0.4.22 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking flexi_logger v0.24.1 [INFO] [stderr] Checking parterm v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parterm.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 21 | fn spawn_with_name(name: &str, f: F) -> thread::JoinHandle [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | / thread::Builder::new() [INFO] [stdout] 28 | | .name(name.into()) [INFO] [stdout] 29 | | .spawn(f) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 43 | let mut cmd = Command::new(&shell); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | cmd.spawn().map_err(|_| PtyError::SpawnShell).and_then(|_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell.rs:288:26 [INFO] [stdout] | [INFO] [stdout] 288 | .or_else(|_| get_passwd().map(|passwd| passwd.shell)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parterm` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parterm.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 21 | fn spawn_with_name(name: &str, f: F) -> thread::JoinHandle [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | / thread::Builder::new() [INFO] [stdout] 28 | | .name(name.into()) [INFO] [stdout] 29 | | .spawn(f) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parterm.rs:241:19 [INFO] [stdout] | [INFO] [stdout] 239 | let mut output = get_pipe("test", false).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | let mut data = [0; 256]; [INFO] [stdout] 241 | match output.read(&mut data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 43 | let mut cmd = Command::new(&shell); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | cmd.spawn().map_err(|_| PtyError::SpawnShell).and_then(|_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell.rs:288:26 [INFO] [stdout] | [INFO] [stdout] 288 | .or_else(|_| get_passwd().map(|passwd| passwd.shell)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parterm` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "135469edfda66eec27923233397fccaba3ac8b264439e7dd96840c0dc5ad3733", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "135469edfda66eec27923233397fccaba3ac8b264439e7dd96840c0dc5ad3733", kill_on_drop: false }` [INFO] [stdout] 135469edfda66eec27923233397fccaba3ac8b264439e7dd96840c0dc5ad3733