[INFO] fetching crate parsli 0.1.4... [INFO] checking parsli-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate parsli 0.1.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate parsli 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate parsli 0.1.4 [INFO] finished tweaking crates.io crate parsli 0.1.4 [INFO] tweaked toml for crates.io crate parsli 0.1.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate parsli 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b3fd821641691784c1510f89bb05e0e7b5732d5b76cd2dd307a7605dd46d3cf1 [INFO] running `Command { std: "docker" "start" "-a" "b3fd821641691784c1510f89bb05e0e7b5732d5b76cd2dd307a7605dd46d3cf1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b3fd821641691784c1510f89bb05e0e7b5732d5b76cd2dd307a7605dd46d3cf1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3fd821641691784c1510f89bb05e0e7b5732d5b76cd2dd307a7605dd46d3cf1", kill_on_drop: false }` [INFO] [stdout] b3fd821641691784c1510f89bb05e0e7b5732d5b76cd2dd307a7605dd46d3cf1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a0806477ed65c31ba2738c09777b2b51aa3f42d591bf1b94dc84b3784bf0d2ac [INFO] running `Command { std: "docker" "start" "-a" "a0806477ed65c31ba2738c09777b2b51aa3f42d591bf1b94dc84b3784bf0d2ac", kill_on_drop: false }` [INFO] [stderr] Compiling portable-atomic v1.4.2 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking dot v0.1.4 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking petgraph v0.6.3 [INFO] [stderr] Checking indicatif v0.17.5 [INFO] [stderr] Checking parsli v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/pool.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | /// Do nothing initially [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 49 | status: Status::Idle, [INFO] [stdout] | -------------------- rustdoc does not generate documentation for expression fields [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/pool.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | /// Empty tree [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 51 | tree: Arc::new(Mutex::new(DepTree::new())), [INFO] [stdout] | ------------------------------------------ rustdoc does not generate documentation for expression fields [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/pool.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | /// Managers [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 54 | names: Arc::new(RwLock::new(HashMap::new())), [INFO] [stdout] | -------------------------------------------- rustdoc does not generate documentation for expression fields [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/pool.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | /// High refresh rate progress bar [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 58 | / progress: Arc::new(MultiProgress::with_draw_target( [INFO] [stdout] 59 | | ProgressDrawTarget::stderr_with_hz(60), [INFO] [stdout] 60 | | )), [INFO] [stdout] | |______________- rustdoc does not generate documentation for expression fields [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/pool.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | /// Do nothing initially [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 49 | status: Status::Idle, [INFO] [stdout] | -------------------- rustdoc does not generate documentation for expression fields [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/pool.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | /// Empty tree [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 51 | tree: Arc::new(Mutex::new(DepTree::new())), [INFO] [stdout] | ------------------------------------------ rustdoc does not generate documentation for expression fields [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/pool.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | /// Managers [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 54 | names: Arc::new(RwLock::new(HashMap::new())), [INFO] [stdout] | -------------------------------------------- rustdoc does not generate documentation for expression fields [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/pool.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | /// High refresh rate progress bar [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 58 | / progress: Arc::new(MultiProgress::with_draw_target( [INFO] [stdout] 59 | | ProgressDrawTarget::stderr_with_hz(60), [INFO] [stdout] 60 | | )), [INFO] [stdout] | |______________- rustdoc does not generate documentation for expression fields [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `update_position` is never used [INFO] [stdout] --> src/line.rs:71:19 [INFO] [stdout] | [INFO] [stdout] 19 | impl Line { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 71 | pub(crate) fn update_position(&self, position: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dep/tree.rs:27:10 [INFO] [stdout] | [INFO] [stdout] 26 | pub(crate) fn find_or_add_node(&mut self, k: K) -> TaskId { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | *self.to_id.entry(k).or_insert_with(|| self.inner.add_node(State::Waiting).index()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(f: F) -> Self where F: TaskFn { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Self { inner: Arc::new(f) } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/line.rs:22:21 [INFO] [stdout] | [INFO] [stdout] 21 | pub(crate) fn new(progress: Arc) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Self { bar: progress.add(ProgressBar::new(0)) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ctx.rs:25:45 [INFO] [stdout] | [INFO] [stdout] 25 | names.iter().filter_map(|name| Some((name.clone(), (*self.global.get(name)?).clone()))).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `update_position` is never used [INFO] [stdout] --> src/line.rs:71:19 [INFO] [stdout] | [INFO] [stdout] 19 | impl Line { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 71 | pub(crate) fn update_position(&self, position: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dep/tree.rs:27:10 [INFO] [stdout] | [INFO] [stdout] 26 | pub(crate) fn find_or_add_node(&mut self, k: K) -> TaskId { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | *self.to_id.entry(k).or_insert_with(|| self.inner.add_node(State::Waiting).index()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(f: F) -> Self where F: TaskFn { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Self { inner: Arc::new(f) } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/line.rs:22:21 [INFO] [stdout] | [INFO] [stdout] 21 | pub(crate) fn new(progress: Arc) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Self { bar: progress.add(ProgressBar::new(0)) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ctx.rs:25:45 [INFO] [stdout] | [INFO] [stdout] 25 | names.iter().filter_map(|name| Some((name.clone(), (*self.global.get(name)?).clone()))).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parsli` (lib) due to 5 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `parsli` (lib test) due to 5 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a0806477ed65c31ba2738c09777b2b51aa3f42d591bf1b94dc84b3784bf0d2ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0806477ed65c31ba2738c09777b2b51aa3f42d591bf1b94dc84b3784bf0d2ac", kill_on_drop: false }` [INFO] [stdout] a0806477ed65c31ba2738c09777b2b51aa3f42d591bf1b94dc84b3784bf0d2ac