[INFO] fetching crate parsec-term 0.2.0... [INFO] checking parsec-term-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate parsec-term 0.2.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate parsec-term 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate parsec-term 0.2.0 [INFO] finished tweaking crates.io crate parsec-term 0.2.0 [INFO] tweaked toml for crates.io crate parsec-term 0.2.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 42 packages to latest compatible versions [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6f5f6da0405e0c1a6ef25f2be75efbda1d1cad485cec79c8cbee3e82a61a823d [INFO] running `Command { std: "docker" "start" "-a" "6f5f6da0405e0c1a6ef25f2be75efbda1d1cad485cec79c8cbee3e82a61a823d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6f5f6da0405e0c1a6ef25f2be75efbda1d1cad485cec79c8cbee3e82a61a823d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f5f6da0405e0c1a6ef25f2be75efbda1d1cad485cec79c8cbee3e82a61a823d", kill_on_drop: false }` [INFO] [stdout] 6f5f6da0405e0c1a6ef25f2be75efbda1d1cad485cec79c8cbee3e82a61a823d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9bc4f85b6024d36bf0fdf36875eb155158f84629f2b695f16b526988b84eb7b2 [INFO] running `Command { std: "docker" "start" "-a" "9bc4f85b6024d36bf0fdf36875eb155158f84629f2b695f16b526988b84eb7b2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking str_indices v0.4.3 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking ropey v1.6.1 [INFO] [stderr] Checking any-rope v1.2.5 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking parsec-core v0.2.0 [INFO] [stderr] Checking parsec-term v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `lazy_cell` has been stable since 1.80.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | lazy_cell, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `result_option_inspect` has been stable since 1.76.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | result_option_inspect, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `lazy_cell` has been stable since 1.80.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | lazy_cell, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `result_option_inspect` has been stable since 1.76.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | result_option_inspect, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/area/mod.rs:354:51 [INFO] [stdout] | [INFO] [stdout] 354 | parent.map(|parent| Area::new(parent, self.layout.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/area/iter.rs:66:24 [INFO] [stdout] | [INFO] [stdout] 54 | iter: impl Iterator + Clone + 'a, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let mut iter = iter.peekable(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | std::iter::from_fn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 67 | | if let Some(unit) = finished_word.pop() { [INFO] [stdout] 68 | | return attach_caret( [INFO] [stdout] 69 | | (&mut x, &mut needs_to_wrap, &mut prev_char), [INFO] [stdout] ... | [INFO] [stdout] 103 | | }) [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/area/iter.rs:225:24 [INFO] [stdout] | [INFO] [stdout] 217 | mut iter: impl Iterator + Clone + 'a, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | std::iter::from_fn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 226 | | if let Some(next) = returns.pop() { [INFO] [stdout] 227 | | Some(next) [INFO] [stdout] 228 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 247 | | } [INFO] [stdout] 248 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layout/mod.rs:584:37 [INFO] [stdout] | [INFO] [stdout] 584 | .map(|(parent, ..)| parent.read().lineage.as_ref().unwrap().2) [INFO] [stdout] | ------------ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layout/mod.rs:603:17 [INFO] [stdout] | [INFO] [stdout] 603 | parent.read().lineage.as_ref().unwrap().1 == axis [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layout/mod.rs:616:26 [INFO] [stdout] | [INFO] [stdout] 616 | .filter(|area| area.read().lineage.as_ref().is_some_and(|(_, cmp, _)| axis == *cmp)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layout/mod.rs:632:32 [INFO] [stdout] | [INFO] [stdout] 631 | let parent = Rect::new_parent_of(rect, axis, &mut self.vars, cluster_new); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 632 | (parent.index, std::mem::replace(rect, parent)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parsec-term` (lib test) due to 8 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/area/mod.rs:354:51 [INFO] [stdout] | [INFO] [stdout] 354 | parent.map(|parent| Area::new(parent, self.layout.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/area/iter.rs:66:24 [INFO] [stdout] | [INFO] [stdout] 54 | iter: impl Iterator + Clone + 'a, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let mut iter = iter.peekable(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | std::iter::from_fn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 67 | | if let Some(unit) = finished_word.pop() { [INFO] [stdout] 68 | | return attach_caret( [INFO] [stdout] 69 | | (&mut x, &mut needs_to_wrap, &mut prev_char), [INFO] [stdout] ... | [INFO] [stdout] 103 | | }) [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/area/iter.rs:225:24 [INFO] [stdout] | [INFO] [stdout] 217 | mut iter: impl Iterator + Clone + 'a, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | std::iter::from_fn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 226 | | if let Some(next) = returns.pop() { [INFO] [stdout] 227 | | Some(next) [INFO] [stdout] 228 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 247 | | } [INFO] [stdout] 248 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layout/mod.rs:584:37 [INFO] [stdout] | [INFO] [stdout] 584 | .map(|(parent, ..)| parent.read().lineage.as_ref().unwrap().2) [INFO] [stdout] | ------------ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layout/mod.rs:603:17 [INFO] [stdout] | [INFO] [stdout] 603 | parent.read().lineage.as_ref().unwrap().1 == axis [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layout/mod.rs:616:26 [INFO] [stdout] | [INFO] [stdout] 616 | .filter(|area| area.read().lineage.as_ref().is_some_and(|(_, cmp, _)| axis == *cmp)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layout/mod.rs:632:32 [INFO] [stdout] | [INFO] [stdout] 631 | let parent = Rect::new_parent_of(rect, axis, &mut self.vars, cluster_new); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 632 | (parent.index, std::mem::replace(rect, parent)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parsec-term` (lib) due to 8 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9bc4f85b6024d36bf0fdf36875eb155158f84629f2b695f16b526988b84eb7b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9bc4f85b6024d36bf0fdf36875eb155158f84629f2b695f16b526988b84eb7b2", kill_on_drop: false }` [INFO] [stdout] 9bc4f85b6024d36bf0fdf36875eb155158f84629f2b695f16b526988b84eb7b2