[INFO] fetching crate parse-up 0.1.0... [INFO] checking parse-up-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate parse-up 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate parse-up 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate parse-up 0.1.0 [INFO] finished tweaking crates.io crate parse-up 0.1.0 [INFO] tweaked toml for crates.io crate parse-up 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 3 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a7513857d7ee5dd4b83c78eb53de669b7150a72bf6bcb887a74c502cd7fad0a3 [INFO] running `Command { std: "docker" "start" "-a" "a7513857d7ee5dd4b83c78eb53de669b7150a72bf6bcb887a74c502cd7fad0a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a7513857d7ee5dd4b83c78eb53de669b7150a72bf6bcb887a74c502cd7fad0a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7513857d7ee5dd4b83c78eb53de669b7150a72bf6bcb887a74c502cd7fad0a3", kill_on_drop: false }` [INFO] [stdout] a7513857d7ee5dd4b83c78eb53de669b7150a72bf6bcb887a74c502cd7fad0a3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 535505af8092f9674edd825eefb2daf3ffbbd320999767ce2694f12ef57d0e85 [INFO] running `Command { std: "docker" "start" "-a" "535505af8092f9674edd825eefb2daf3ffbbd320999767ce2694f12ef57d0e85", kill_on_drop: false }` [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking parse-up v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `oops` [INFO] [stdout] --> src/lib.rs:5:45 [INFO] [stdout] | [INFO] [stdout] 5 | use util::{chars_needed_to_complete, go_on, oops, yes_and}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `oops` [INFO] [stdout] --> src/util.rs:41:14 [INFO] [stdout] | [INFO] [stdout] 41 | macro_rules! oops { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `oops` [INFO] [stdout] --> src/lib.rs:5:45 [INFO] [stdout] | [INFO] [stdout] 5 | use util::{chars_needed_to_complete, go_on, oops, yes_and}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `oops` [INFO] [stdout] --> src/util.rs:41:14 [INFO] [stdout] | [INFO] [stdout] 41 | macro_rules! oops { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pairs` [INFO] [stdout] --> src/lib.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | let pairs = items [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_pairs` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pairs` [INFO] [stdout] --> src/lib.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | let pairs = items [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_pairs` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/lib.rs:101:11 [INFO] [stdout] | [INFO] [stdout] 101 | move |input: &str| todo!() [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `left` [INFO] [stdout] --> src/lib.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | left: impl UpParser<'input, L>, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_left` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `right` [INFO] [stdout] --> src/lib.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | right: impl UpParser<'input, R>, [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_right` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/lib.rs:108:11 [INFO] [stdout] | [INFO] [stdout] 108 | move |input| todo!() [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/lib.rs:101:11 [INFO] [stdout] | [INFO] [stdout] 101 | move |input: &str| todo!() [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `left` [INFO] [stdout] --> src/lib.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | left: impl UpParser<'input, L>, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_left` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `right` [INFO] [stdout] --> src/lib.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | right: impl UpParser<'input, R>, [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_right` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/lib.rs:108:11 [INFO] [stdout] | [INFO] [stdout] 108 | move |input| todo!() [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn yes_and(yes: T, and: &str) -> UpResult { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | Ok(YesAnd { [INFO] [stdout] | ________^ [INFO] [stdout] 9 | | yes, [INFO] [stdout] 10 | | and, [INFO] [stdout] 11 | | could_also: vec![], [INFO] [stdout] 12 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 16 | yes: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | and: &str, [INFO] [stdout] 18 | also: impl IntoIterator, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | ) -> UpResult { [INFO] [stdout] 20 | Ok(YesAnd { [INFO] [stdout] | ________^ [INFO] [stdout] 21 | | yes, [INFO] [stdout] 22 | | and, [INFO] [stdout] 23 | | could_also: also.into_iter().map(|a| a.to_string()).collect(), [INFO] [stdout] 24 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:31:16 [INFO] [stdout] | [INFO] [stdout] 28 | suggestions: impl IntoIterator, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | go_on: suggestions.into_iter().map(|g| g.to_string()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 62 | haystack: impl IntoIterator, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | ) -> Vec { [INFO] [stdout] 64 | / haystack [INFO] [stdout] 65 | | .into_iter() [INFO] [stdout] 66 | | .filter_map(|hay| { [INFO] [stdout] 67 | | hay.strip_prefix(needle).and_then(|s| match s { [INFO] [stdout] ... | [INFO] [stdout] 71 | | }) [INFO] [stdout] 72 | | .map(String::from) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn yes_and(yes: T, and: &str) -> UpResult { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | Ok(YesAnd { [INFO] [stdout] | ________^ [INFO] [stdout] 9 | | yes, [INFO] [stdout] 10 | | and, [INFO] [stdout] 11 | | could_also: vec![], [INFO] [stdout] 12 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 16 | yes: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | and: &str, [INFO] [stdout] 18 | also: impl IntoIterator, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | ) -> UpResult { [INFO] [stdout] 20 | Ok(YesAnd { [INFO] [stdout] | ________^ [INFO] [stdout] 21 | | yes, [INFO] [stdout] 22 | | and, [INFO] [stdout] 23 | | could_also: also.into_iter().map(|a| a.to_string()).collect(), [INFO] [stdout] 24 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:31:16 [INFO] [stdout] | [INFO] [stdout] 28 | suggestions: impl IntoIterator, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | go_on: suggestions.into_iter().map(|g| g.to_string()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 62 | haystack: impl IntoIterator, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | ) -> Vec { [INFO] [stdout] 64 | / haystack [INFO] [stdout] 65 | | .into_iter() [INFO] [stdout] 66 | | .filter_map(|hay| { [INFO] [stdout] 67 | | hay.strip_prefix(needle).and_then(|s| match s { [INFO] [stdout] ... | [INFO] [stdout] 71 | | }) [INFO] [stdout] 72 | | .map(String::from) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parse-up` (lib) due to 5 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parse-up` (lib test) due to 5 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "535505af8092f9674edd825eefb2daf3ffbbd320999767ce2694f12ef57d0e85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "535505af8092f9674edd825eefb2daf3ffbbd320999767ce2694f12ef57d0e85", kill_on_drop: false }` [INFO] [stdout] 535505af8092f9674edd825eefb2daf3ffbbd320999767ce2694f12ef57d0e85