[INFO] fetching crate parquet2 0.17.2... [INFO] checking parquet2-0.17.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate parquet2 0.17.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate parquet2 0.17.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate parquet2 0.17.2 [INFO] finished tweaking crates.io crate parquet2 0.17.2 [INFO] tweaked toml for crates.io crate parquet2 0.17.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate parquet2 0.17.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7576c63b90003e76f611d28a8123bf592ce9c5afbb4496c501e9404b7a50aecd [INFO] running `Command { std: "docker" "start" "-a" "7576c63b90003e76f611d28a8123bf592ce9c5afbb4496c501e9404b7a50aecd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7576c63b90003e76f611d28a8123bf592ce9c5afbb4496c501e9404b7a50aecd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7576c63b90003e76f611d28a8123bf592ce9c5afbb4496c501e9404b7a50aecd", kill_on_drop: false }` [INFO] [stdout] 7576c63b90003e76f611d28a8123bf592ce9c5afbb4496c501e9404b7a50aecd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9c4b5f8f478e1c9acc1fee155b3fd0da18897adb2bedbdc5e1291a64f4925284 [INFO] running `Command { std: "docker" "start" "-a" "9c4b5f8f478e1c9acc1fee155b3fd0da18897adb2bedbdc5e1291a64f4925284", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.131 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling crossbeam-utils v0.8.11 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Compiling pkg-config v0.3.26 [INFO] [stderr] Compiling serde_derive v1.0.143 [INFO] [stderr] Compiling serde v1.0.143 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling serde_json v1.0.83 [INFO] [stderr] Compiling zstd-safe v6.0.5+zstd.1.5.4 [INFO] [stderr] Compiling crossbeam-epoch v0.9.10 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking alloc-no-stdlib v2.0.3 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking either v1.7.0 [INFO] [stderr] Checking alloc-stdlib v0.2.1 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Checking os_str_bytes v6.5.0 [INFO] [stderr] Checking ciborium-io v0.2.0 [INFO] [stderr] Checking plotters-backend v0.3.4 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Compiling snap v1.1.0 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking brotli-decompressor v2.3.2 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking ciborium-ll v0.2.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Compiling tokio v1.20.1 [INFO] [stderr] Checking plotters-svg v0.3.2 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking streaming-decompression v0.1.2 [INFO] [stderr] Checking clap v3.2.23 [INFO] [stderr] Checking xxhash-rust v0.8.5 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Compiling seq-macro v0.3.1 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking parquet-format-safe v0.2.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking crossbeam-deque v0.8.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking plotters v0.3.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking brotli v3.3.4 [INFO] [stderr] Compiling zstd-sys v2.0.8+zstd.1.5.5 [INFO] [stderr] Compiling lz4-sys v1.9.4 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Checking zstd v0.12.3+zstd.1.5.2 [INFO] [stderr] Checking lz4 v1.24.0 [INFO] [stderr] Checking parquet2 v0.17.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/deserialize/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub use binary::*; [INFO] [stdout] | ^^^^^^^^^ the name `Dictionary` in the type namespace is first re-exported here [INFO] [stdout] ... [INFO] [stdout] 14 | pub use native::*; [INFO] [stdout] | --------- but the name `Dictionary` in the type namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `from_thrift::*` [INFO] [stdout] --> src/schema/io_thrift/mod.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub use from_thrift::*; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `to_thrift::*` [INFO] [stdout] --> src/schema/io_thrift/mod.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub use to_thrift::*; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::metadata::KeyValue` [INFO] [stdout] --> src/write/indexes/serialize.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub use crate::metadata::KeyValue; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::metadata::KeyValue` [INFO] [stdout] --> src/write/indexes/write.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub use crate::metadata::KeyValue; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking ciborium v0.2.0 [INFO] [stdout] warning: field `num_values` is never read [INFO] [stdout] --> src/write/page.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 43 | pub struct PageWriteSpec { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 44 | pub header: ParquetPageHeader, [INFO] [stdout] 45 | pub num_values: usize, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialize/binary.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn try_new(page: &'a DataPage, dict: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(Self { indexes, dict }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialize/binary.rs:42:15 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn try_new(page: &'a DataPage, dict: Option

) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | match (page.encoding(), dict, is_optional) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialize/fixed_len.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn try_new(page: &'a DataPage, dict: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(Self { indexes, dict }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialize/fixed_len.rs:80:15 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn try_new(page: &'a DataPage, dict: Option

) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | match (page.encoding(), dict, is_optional) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialize/native.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn try_new(page: &'a DataPage, dict: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(Self { dict, indexes }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialize/native.rs:76:15 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn try_new(page: &'a DataPage, dict: Option

) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | match (page.encoding(), dict, is_optional) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read/mod.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 50 | mut reader: R, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | pages_filter: Option, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let pages_filter = pages_filter.unwrap_or_else(|| Arc::new(|_, _| true)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(PageReader::new( [INFO] [stdout] | ________^ [INFO] [stdout] 60 | | reader, [INFO] [stdout] 61 | | column_chunk, [INFO] [stdout] 62 | | pages_filter, [INFO] [stdout] 63 | | scratch, [INFO] [stdout] 64 | | max_page_size, [INFO] [stdout] 65 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read/column/mod.rs:78:21 [INFO] [stdout] | [INFO] [stdout] 70 | reader: R, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | mut columns: Vec, [INFO] [stdout] 72 | page_filter: Option, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | reader: Some(reader), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read/column/mod.rs:82:22 [INFO] [stdout] | [INFO] [stdout] 70 | reader: R, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | mut columns: Vec, [INFO] [stdout] 72 | page_filter: Option, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | current: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read/column/mod.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 92 | fn advance(mut self) -> Result, Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let (reader, scratch) = if let Some((iter, _)) = self.current { [INFO] [stdout] | ------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let iter = get_page_iterator( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let current = Some((iter, column)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | Ok(State::Some(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 112 | | reader: None, [INFO] [stdout] 113 | | columns: self.columns, [INFO] [stdout] 114 | | page_filter: self.page_filter, [INFO] [stdout] ... | [INFO] [stdout] 117 | | max_page_size: self.max_page_size, [INFO] [stdout] 118 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read/compression.rs:263:19 [INFO] [stdout] | [INFO] [stdout] 261 | pub fn new(iter: I, buffer: Vec) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | Self { [INFO] [stdout] 263 | iter: _Decompressor::new(iter, buffer, decompress), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statistics/primitive.rs:65:40 [INFO] [stdout] | [INFO] [stdout] 65 | max_value: v.max_value.map(|x| x.to_le_bytes().as_ref().to_vec()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statistics/primitive.rs:66:40 [INFO] [stdout] | [INFO] [stdout] 66 | min_value: v.min_value.map(|x| x.to_le_bytes().as_ref().to_vec()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write/column_chunk.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 33 | mut compressed_pages: DynStreamingIterator<'a, CompressedPage, E>, [INFO] [stdout] | ----------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let mut specs = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok((column_chunk, specs, bytes_written)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write/page.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 81 | let statistics = match &compressed_page { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(PageWriteSpec { [INFO] [stdout] | ________^ [INFO] [stdout] 87 | | header, [INFO] [stdout] 88 | | header_size, [INFO] [stdout] 89 | | offset, [INFO] [stdout] ... | [INFO] [stdout] 94 | | num_values, [INFO] [stdout] 95 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write/row_group.rs:128:8 [INFO] [stdout] | [INFO] [stdout] 86 | columns: DynIter<'a, std::result::Result, E>>, [INFO] [stdout] | ----------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let column_iter = descriptors.iter().zip(columns); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let columns = column_iter [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let (columns, specs) = columns.into_iter().unzip(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | [INFO] [stdout] 128 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 129 | | RowGroup { [INFO] [stdout] 130 | | columns, [INFO] [stdout] 131 | | total_byte_size, [INFO] [stdout] ... | [INFO] [stdout] 139 | | bytes_written, [INFO] [stdout] 140 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write/row_group.rs:102:16 [INFO] [stdout] | [INFO] [stdout] 98 | .map(|(descriptor, page_iter)| { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | let (column, page_specs, size) = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Ok((column, page_specs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write/statistics.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 9 | fn reduce_single T>(lhs: Option, rhs: Option, op: F) -> Option { [INFO] [stdout] | -------------- -------------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | match (lhs, rhs) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write/dyn_iter.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(iter: I) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | iter: Box::new(iter), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write/dyn_iter.rs:62:19 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(iter: I) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | iter: Box::new(iter), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 20 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parquet2` (lib) due to 21 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "9c4b5f8f478e1c9acc1fee155b3fd0da18897adb2bedbdc5e1291a64f4925284", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c4b5f8f478e1c9acc1fee155b3fd0da18897adb2bedbdc5e1291a64f4925284", kill_on_drop: false }` [INFO] [stdout] 9c4b5f8f478e1c9acc1fee155b3fd0da18897adb2bedbdc5e1291a64f4925284