[INFO] fetching crate parity-scale-codec-derive 3.6.12... [INFO] checking parity-scale-codec-derive-3.6.12 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate parity-scale-codec-derive 3.6.12 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate parity-scale-codec-derive 3.6.12 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate parity-scale-codec-derive 3.6.12 [INFO] finished tweaking crates.io crate parity-scale-codec-derive 3.6.12 [INFO] tweaked toml for crates.io crate parity-scale-codec-derive 3.6.12 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 13 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 00c55e3bf562adde7d933005f5a16edf01c29b94c090adeda9a899421eaba4c7 [INFO] running `Command { std: "docker" "start" "-a" "00c55e3bf562adde7d933005f5a16edf01c29b94c090adeda9a899421eaba4c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "00c55e3bf562adde7d933005f5a16edf01c29b94c090adeda9a899421eaba4c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00c55e3bf562adde7d933005f5a16edf01c29b94c090adeda9a899421eaba4c7", kill_on_drop: false }` [INFO] [stdout] 00c55e3bf562adde7d933005f5a16edf01c29b94c090adeda9a899421eaba4c7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6b2c83fcd83b59a21b1db528f8bd3d05170e0e7c48b1ee73f5e1e3df631e4140 [INFO] running `Command { std: "docker" "start" "-a" "6b2c83fcd83b59a21b1db528f8bd3d05170e0e7c48b1ee73f5e1e3df631e4140", kill_on_drop: false }` [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking proc-macro-crate v3.2.0 [INFO] [stderr] Checking parity-scale-codec-derive v3.6.12 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/encode.rs:106:7 [INFO] [stdout] | [INFO] [stdout] 106 | Skip(&'a Field), [INFO] [stdout] | ---- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 106 | Skip(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:52:27 [INFO] [stdout] | [INFO] [stdout] 52 | let data_variants = || data.variants.iter().filter(|variant| !utils::should_skip(&variant.attrs)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parity-scale-codec-derive` (lib test) due to 7 previous errors; 1 warning emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:147:3 [INFO] [stdout] | [INFO] [stdout] 147 | utils::get_encoded_as_type(field).is_some() || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:302:8 [INFO] [stdout] | [INFO] [stdout] 302 | || data.variants.iter().filter(|variant| !utils::should_skip(&variant.attrs)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trait_bounds.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 200 | .flat_map(|ty| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | / find_type_paths_not_start_or_contain_ident(&ty, input_ident) [INFO] [stdout] 202 | | .into_iter() [INFO] [stdout] 203 | | .map(Type::Path) [INFO] [stdout] 204 | | // Remove again types that do not contain any of our generic parameters [INFO] [stdout] 205 | | .filter(|ty| type_contain_idents(ty, ty_params)) [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trait_bounds.rs:207:13 [INFO] [stdout] | [INFO] [stdout] 200 | .flat_map(|ty| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | .chain(iter::once(ty)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:36:44 [INFO] [stdout] | [INFO] [stdout] 36 | attr.path.is_ident("codec").then(|| pred(attr.parse_args().ok()?)).flatten() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/encode.rs:106:7 [INFO] [stdout] | [INFO] [stdout] 106 | Skip(&'a Field), [INFO] [stdout] | ---- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 106 | Skip(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:52:27 [INFO] [stdout] | [INFO] [stdout] 52 | let data_variants = || data.variants.iter().filter(|variant| !utils::should_skip(&variant.attrs)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:147:3 [INFO] [stdout] | [INFO] [stdout] 147 | utils::get_encoded_as_type(field).is_some() || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:302:8 [INFO] [stdout] | [INFO] [stdout] 302 | || data.variants.iter().filter(|variant| !utils::should_skip(&variant.attrs)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trait_bounds.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 200 | .flat_map(|ty| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | / find_type_paths_not_start_or_contain_ident(&ty, input_ident) [INFO] [stdout] 202 | | .into_iter() [INFO] [stdout] 203 | | .map(Type::Path) [INFO] [stdout] 204 | | // Remove again types that do not contain any of our generic parameters [INFO] [stdout] 205 | | .filter(|ty| type_contain_idents(ty, ty_params)) [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trait_bounds.rs:207:13 [INFO] [stdout] | [INFO] [stdout] 200 | .flat_map(|ty| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | .chain(iter::once(ty)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:36:44 [INFO] [stdout] | [INFO] [stdout] 36 | attr.path.is_ident("codec").then(|| pred(attr.parse_args().ok()?)).flatten() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parity-scale-codec-derive` (lib) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "6b2c83fcd83b59a21b1db528f8bd3d05170e0e7c48b1ee73f5e1e3df631e4140", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b2c83fcd83b59a21b1db528f8bd3d05170e0e7c48b1ee73f5e1e3df631e4140", kill_on_drop: false }` [INFO] [stdout] 6b2c83fcd83b59a21b1db528f8bd3d05170e0e7c48b1ee73f5e1e3df631e4140