[INFO] fetching crate paperdoll-tar 0.1.1... [INFO] checking paperdoll-tar-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate paperdoll-tar 0.1.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate paperdoll-tar 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate paperdoll-tar 0.1.1 [INFO] finished tweaking crates.io crate paperdoll-tar 0.1.1 [INFO] tweaked toml for crates.io crate paperdoll-tar 0.1.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 86 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding image v0.24.9 (latest: v0.25.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding remove_dir_all v0.5.3 (latest: v0.8.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 787800698df3f52b2a082d8e0060661a9272e39525950785c94f2b881dd93080 [INFO] running `Command { std: "docker" "start" "-a" "787800698df3f52b2a082d8e0060661a9272e39525950785c94f2b881dd93080", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "787800698df3f52b2a082d8e0060661a9272e39525950785c94f2b881dd93080", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "787800698df3f52b2a082d8e0060661a9272e39525950785c94f2b881dd93080", kill_on_drop: false }` [INFO] [stdout] 787800698df3f52b2a082d8e0060661a9272e39525950785c94f2b881dd93080 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fbfa25653f4da3a55c16f60c1ba59f8c3e438602181cfc46743aef6d1f71a0c9 [INFO] running `Command { std: "docker" "start" "-a" "fbfa25653f4da3a55c16f60c1ba59f8c3e438602181cfc46743aef6d1f71a0c9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking exr v1.72.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking tar v0.4.41 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking paperdoll v0.1.1 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking paperdoll-tar v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:10 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn load

(path: P) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | read(File::open(&path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:10 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn load

(path: P) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | read(File::open(&path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:53:40 [INFO] [stdout] | [INFO] [stdout] 53 | let manifest_path = temp_dir.path().clone().join(FILE_NAME_MANIFEST); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 53 - let manifest_path = temp_dir.path().clone().join(FILE_NAME_MANIFEST); [INFO] [stdout] 53 + let manifest_path = temp_dir.path().join(FILE_NAME_MANIFEST); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:63:39 [INFO] [stdout] | [INFO] [stdout] 63 | let img_path = temp_dir.path().clone().join(&doll.path); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 63 - let img_path = temp_dir.path().clone().join(&doll.path); [INFO] [stdout] 63 + let img_path = temp_dir.path().join(&doll.path); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:76:39 [INFO] [stdout] | [INFO] [stdout] 76 | let img_path = temp_dir.path().clone().join(&fragment.path); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 76 - let img_path = temp_dir.path().clone().join(&fragment.path); [INFO] [stdout] 76 + let img_path = temp_dir.path().join(&fragment.path); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:120:39 [INFO] [stdout] | [INFO] [stdout] 120 | let img_path = temp_dir.path().clone().join(&filename); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 120 - let img_path = temp_dir.path().clone().join(&filename); [INFO] [stdout] 120 + let img_path = temp_dir.path().join(&filename); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:157:39 [INFO] [stdout] | [INFO] [stdout] 157 | let img_path = temp_dir.path().clone().join(&filename); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 157 - let img_path = temp_dir.path().clone().join(&filename); [INFO] [stdout] 157 + let img_path = temp_dir.path().join(&filename); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:172:40 [INFO] [stdout] | [INFO] [stdout] 172 | let manifest_path = temp_dir.path().clone().join(FILE_NAME_MANIFEST); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 172 - let manifest_path = temp_dir.path().clone().join(FILE_NAME_MANIFEST); [INFO] [stdout] 172 + let manifest_path = temp_dir.path().join(FILE_NAME_MANIFEST); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `paperdoll-tar` (lib test) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:53:40 [INFO] [stdout] | [INFO] [stdout] 53 | let manifest_path = temp_dir.path().clone().join(FILE_NAME_MANIFEST); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 53 - let manifest_path = temp_dir.path().clone().join(FILE_NAME_MANIFEST); [INFO] [stdout] 53 + let manifest_path = temp_dir.path().join(FILE_NAME_MANIFEST); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:63:39 [INFO] [stdout] | [INFO] [stdout] 63 | let img_path = temp_dir.path().clone().join(&doll.path); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 63 - let img_path = temp_dir.path().clone().join(&doll.path); [INFO] [stdout] 63 + let img_path = temp_dir.path().join(&doll.path); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:76:39 [INFO] [stdout] | [INFO] [stdout] 76 | let img_path = temp_dir.path().clone().join(&fragment.path); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 76 - let img_path = temp_dir.path().clone().join(&fragment.path); [INFO] [stdout] 76 + let img_path = temp_dir.path().join(&fragment.path); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:120:39 [INFO] [stdout] | [INFO] [stdout] 120 | let img_path = temp_dir.path().clone().join(&filename); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 120 - let img_path = temp_dir.path().clone().join(&filename); [INFO] [stdout] 120 + let img_path = temp_dir.path().join(&filename); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:157:39 [INFO] [stdout] | [INFO] [stdout] 157 | let img_path = temp_dir.path().clone().join(&filename); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 157 - let img_path = temp_dir.path().clone().join(&filename); [INFO] [stdout] 157 + let img_path = temp_dir.path().join(&filename); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:172:40 [INFO] [stdout] | [INFO] [stdout] 172 | let manifest_path = temp_dir.path().clone().join(FILE_NAME_MANIFEST); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 172 - let manifest_path = temp_dir.path().clone().join(FILE_NAME_MANIFEST); [INFO] [stdout] 172 + let manifest_path = temp_dir.path().join(FILE_NAME_MANIFEST); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `paperdoll-tar` (lib) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "fbfa25653f4da3a55c16f60c1ba59f8c3e438602181cfc46743aef6d1f71a0c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fbfa25653f4da3a55c16f60c1ba59f8c3e438602181cfc46743aef6d1f71a0c9", kill_on_drop: false }` [INFO] [stdout] fbfa25653f4da3a55c16f60c1ba59f8c3e438602181cfc46743aef6d1f71a0c9