[INFO] fetching crate panfix 0.4.0... [INFO] checking panfix-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate panfix 0.4.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate panfix 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate panfix 0.4.0 [INFO] finished tweaking crates.io crate panfix 0.4.0 [INFO] tweaked toml for crates.io crate panfix 0.4.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate panfix 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fa5d92dd153daa7961b7c13b3c6066ef14121b9da3af09c53086d3b1fa934b55 [INFO] running `Command { std: "docker" "start" "-a" "fa5d92dd153daa7961b7c13b3c6066ef14121b9da3af09c53086d3b1fa934b55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fa5d92dd153daa7961b7c13b3c6066ef14121b9da3af09c53086d3b1fa934b55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa5d92dd153daa7961b7c13b3c6066ef14121b9da3af09c53086d3b1fa934b55", kill_on_drop: false }` [INFO] [stdout] fa5d92dd153daa7961b7c13b3c6066ef14121b9da3af09c53086d3b1fa934b55 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b3fd5a2dd3a205c987fb502132d8c1f8633dd8f6be00c10ed1e19565d48dd40 [INFO] running `Command { std: "docker" "start" "-a" "2b3fd5a2dd3a205c987fb502132d8c1f8633dd8f6be00c10ed1e19565d48dd40", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling syn v1.0.44 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking aho-corasick v0.7.13 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Compiling thiserror-impl v1.0.21 [INFO] [stderr] Checking thiserror v1.0.21 [INFO] [stderr] Checking panfix v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 83 | let lexer_builder = LexerBuilder::new(whitespace_regex).map_err(RegexError)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let juxt_op = Op::new_juxtapose(Assoc::Left, JUXTAPOSE_PREC); [INFO] [stdout] 85 | Ok(Grammar { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | // First three tokens: ERROR, BLANK, JUXTAPOSE [INFO] [stdout] 87 | | lexer_builder, [INFO] [stdout] 88 | | token_table: vec![ [INFO] [stdout] ... | [INFO] [stdout] 129 | | current_assoc: Assoc::Left, [INFO] [stdout] 130 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:249:12 [INFO] [stdout] | [INFO] [stdout] 226 | pub fn finish(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let lexer = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | Ok(Parser { [INFO] [stdout] | ____________^ [INFO] [stdout] 250 | | lexer, [INFO] [stdout] 251 | | tok_to_name, [INFO] [stdout] 252 | | tok_to_prefix, [INFO] [stdout] ... | [INFO] [stdout] 257 | | optok_to_prec, [INFO] [stdout] 258 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lexer.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn finish(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | Ok(Lexer { [INFO] [stdout] | ____________^ [INFO] [stdout] 136 | | whitespace: self.whitespace, [INFO] [stdout] 137 | | regex_set: RegexSet::new(self.patterns.iter().map(|p| p.regex.as_str()))?, [INFO] [stdout] 138 | | patterns: self.patterns, [INFO] [stdout] 139 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:16:76 [INFO] [stdout] | [INFO] [stdout] 14 | input: impl IntoIterator, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | ) -> Result, ResolverError> { [INFO] [stdout] 16 | Resolver::new(tok_to_prefix, tok_to_suffix, optok_to_follower).resolve(input.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shunter.rs:19:15 [INFO] [stdout] | [INFO] [stdout] 14 | iter: impl Iterator + 'a, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | iter: iter.peekable(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `panfix` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 83 | let lexer_builder = LexerBuilder::new(whitespace_regex).map_err(RegexError)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let juxt_op = Op::new_juxtapose(Assoc::Left, JUXTAPOSE_PREC); [INFO] [stdout] 85 | Ok(Grammar { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | // First three tokens: ERROR, BLANK, JUXTAPOSE [INFO] [stdout] 87 | | lexer_builder, [INFO] [stdout] 88 | | token_table: vec![ [INFO] [stdout] ... | [INFO] [stdout] 129 | | current_assoc: Assoc::Left, [INFO] [stdout] 130 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:249:12 [INFO] [stdout] | [INFO] [stdout] 226 | pub fn finish(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let lexer = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | Ok(Parser { [INFO] [stdout] | ____________^ [INFO] [stdout] 250 | | lexer, [INFO] [stdout] 251 | | tok_to_name, [INFO] [stdout] 252 | | tok_to_prefix, [INFO] [stdout] ... | [INFO] [stdout] 257 | | optok_to_prec, [INFO] [stdout] 258 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lexer.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn finish(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | Ok(Lexer { [INFO] [stdout] | ____________^ [INFO] [stdout] 136 | | whitespace: self.whitespace, [INFO] [stdout] 137 | | regex_set: RegexSet::new(self.patterns.iter().map(|p| p.regex.as_str()))?, [INFO] [stdout] 138 | | patterns: self.patterns, [INFO] [stdout] 139 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:16:76 [INFO] [stdout] | [INFO] [stdout] 14 | input: impl IntoIterator, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | ) -> Result, ResolverError> { [INFO] [stdout] 16 | Resolver::new(tok_to_prefix, tok_to_suffix, optok_to_follower).resolve(input.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shunter.rs:19:15 [INFO] [stdout] | [INFO] [stdout] 14 | iter: impl Iterator + 'a, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | iter: iter.peekable(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `panfix` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "2b3fd5a2dd3a205c987fb502132d8c1f8633dd8f6be00c10ed1e19565d48dd40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b3fd5a2dd3a205c987fb502132d8c1f8633dd8f6be00c10ed1e19565d48dd40", kill_on_drop: false }` [INFO] [stdout] 2b3fd5a2dd3a205c987fb502132d8c1f8633dd8f6be00c10ed1e19565d48dd40