[INFO] fetching crate pagurus_windows_system 0.6.0... [INFO] checking pagurus_windows_system-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pagurus_windows_system 0.6.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate pagurus_windows_system 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pagurus_windows_system 0.6.0 [INFO] finished tweaking crates.io crate pagurus_windows_system 0.6.0 [INFO] tweaked toml for crates.io crate pagurus_windows_system 0.6.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 12 packages to latest compatible versions [INFO] [stderr] Adding orfail v0.1.3 (latest: v1.1.0) [INFO] [stderr] Adding pagurus v0.6.4 (latest: v0.7.4) [INFO] [stderr] Adding windows v0.42.0 (latest: v0.58.0) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.42.2 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e82b032e7b09b5e51276cf9bed1ae573b4d4cfe58336af31f9b908071c1b900c [INFO] running `Command { std: "docker" "start" "-a" "e82b032e7b09b5e51276cf9bed1ae573b4d4cfe58336af31f9b908071c1b900c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e82b032e7b09b5e51276cf9bed1ae573b4d4cfe58336af31f9b908071c1b900c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e82b032e7b09b5e51276cf9bed1ae573b4d4cfe58336af31f9b908071c1b900c", kill_on_drop: false }` [INFO] [stdout] e82b032e7b09b5e51276cf9bed1ae573b4d4cfe58336af31f9b908071c1b900c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f7ec0aa4ed51e49d709e0ef97d2d3eb46d009ff269b733a50fc1684e7a5d05a1 [INFO] running `Command { std: "docker" "start" "-a" "f7ec0aa4ed51e49d709e0ef97d2d3eb46d009ff269b733a50fc1684e7a5d05a1", kill_on_drop: false }` [INFO] [stderr] Checking orfail v0.1.3 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking windows v0.42.0 [INFO] [stderr] Checking pagurus v0.6.4 [INFO] [stderr] Checking pagurus_windows_system v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 34 | let audio = unsafe { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let mut audio = None; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | audio, [INFO] [stdout] 92 | | mastering_voice, [INFO] [stdout] 93 | | source_voice, [INFO] [stdout] 94 | | buf: vec![0; data_samples * 2], [INFO] [stdout] 95 | | is_odd: false, [INFO] [stdout] 96 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/system.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 47 | let window = self.window.build().or_fail()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let io_request_tx = IoThread::spawn(window.event_tx()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Ok(WindowsSystem { [INFO] [stdout] | ____________^ [INFO] [stdout] 50 | | window, [INFO] [stdout] 51 | | audio_player: None, [INFO] [stdout] 52 | | start: Instant::now(), [INFO] [stdout] ... | [INFO] [stdout] 57 | | data_dir: self.data_dir, [INFO] [stdout] 58 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/window.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 49 | let handle = MainWindowThread::spawn(self).or_fail()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Ok(Window::new(handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/window.rs:244:12 [INFO] [stdout] | [INFO] [stdout] 221 | let (event_tx, event_rx) = mpsc::channel(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | let event_tx_for_handle = event_tx.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let (hwnd_tx, hwnd_rx) = mpsc::channel(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | Ok(MainWindowThreadHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 245 | | hwnd, [INFO] [stdout] 246 | | event_tx: event_tx_for_handle, [INFO] [stdout] 247 | | event_rx, [INFO] [stdout] 248 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pagurus_windows_system` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 34 | let audio = unsafe { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let mut audio = None; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | audio, [INFO] [stdout] 92 | | mastering_voice, [INFO] [stdout] 93 | | source_voice, [INFO] [stdout] 94 | | buf: vec![0; data_samples * 2], [INFO] [stdout] 95 | | is_odd: false, [INFO] [stdout] 96 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/system.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 47 | let window = self.window.build().or_fail()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let io_request_tx = IoThread::spawn(window.event_tx()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Ok(WindowsSystem { [INFO] [stdout] | ____________^ [INFO] [stdout] 50 | | window, [INFO] [stdout] 51 | | audio_player: None, [INFO] [stdout] 52 | | start: Instant::now(), [INFO] [stdout] ... | [INFO] [stdout] 57 | | data_dir: self.data_dir, [INFO] [stdout] 58 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/window.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 49 | let handle = MainWindowThread::spawn(self).or_fail()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Ok(Window::new(handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/window.rs:244:12 [INFO] [stdout] | [INFO] [stdout] 221 | let (event_tx, event_rx) = mpsc::channel(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | let event_tx_for_handle = event_tx.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let (hwnd_tx, hwnd_rx) = mpsc::channel(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | Ok(MainWindowThreadHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 245 | | hwnd, [INFO] [stdout] 246 | | event_tx: event_tx_for_handle, [INFO] [stdout] 247 | | event_rx, [INFO] [stdout] 248 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pagurus_windows_system` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "f7ec0aa4ed51e49d709e0ef97d2d3eb46d009ff269b733a50fc1684e7a5d05a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7ec0aa4ed51e49d709e0ef97d2d3eb46d009ff269b733a50fc1684e7a5d05a1", kill_on_drop: false }` [INFO] [stdout] f7ec0aa4ed51e49d709e0ef97d2d3eb46d009ff269b733a50fc1684e7a5d05a1