[INFO] fetching crate pageman 0.1.0... [INFO] checking pageman-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pageman 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate pageman 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pageman 0.1.0 [INFO] finished tweaking crates.io crate pageman 0.1.0 [INFO] tweaked toml for crates.io crate pageman 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 12 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0efc003063d1377742ea0f6b2bacb3c2fba30fe66212a8f50b82e295995e9d46 [INFO] running `Command { std: "docker" "start" "-a" "0efc003063d1377742ea0f6b2bacb3c2fba30fe66212a8f50b82e295995e9d46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0efc003063d1377742ea0f6b2bacb3c2fba30fe66212a8f50b82e295995e9d46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0efc003063d1377742ea0f6b2bacb3c2fba30fe66212a8f50b82e295995e9d46", kill_on_drop: false }` [INFO] [stdout] 0efc003063d1377742ea0f6b2bacb3c2fba30fe66212a8f50b82e295995e9d46 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3ffa59d0c02e09e61d3ac4914a0d390f54ed33372055e7cc61133b2809e5383b [INFO] running `Command { std: "docker" "start" "-a" "3ffa59d0c02e09e61d3ac4914a0d390f54ed33372055e7cc61133b2809e5383b", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking roaring v0.10.6 [INFO] [stderr] Checking generic-array v1.1.0 [INFO] [stderr] Checking pageman v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binable.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 75 | Ok(if is_some { [INFO] [stdout] | ____________^ [INFO] [stdout] 76 | | Some(B::decode_from(rdr)?) [INFO] [stdout] 77 | | } else { [INFO] [stdout] 78 | | None [INFO] [stdout] 79 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 85 | let file = fs::File::options() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 93 | | cache: Cache::new(cache_cap), [INFO] [stdout] 94 | | counter: Counter::default(), [INFO] [stdout] 95 | | dir: index_dir.clone(), [INFO] [stdout] 96 | | file, [INFO] [stdout] 97 | | vacants: RoaringBitmap::from([0]), [INFO] [stdout] 98 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:226:35 [INFO] [stdout] | [INFO] [stdout] 226 | .try_for_each(|entry| self.flush(entry).wrap_err("failed to flush the page")) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/cache.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 28 | fn out(self, pin_count: &mut usize) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 30 | | Value::Detached => bail!("Value is detached"), [INFO] [stdout] 31 | | Value::Pinned(v) => { [INFO] [stdout] 32 | | *pin_count -= 1; [INFO] [stdout] ... | [INFO] [stdout] 35 | | Value::Regular(v) => v, [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/cache.rs:143:31 [INFO] [stdout] | [INFO] [stdout] 143 | .map(|(k, v)| (k, v.out(&mut 0).unwrap())) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/cache.rs:150:13 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn push(&mut self, key: K, val: V) -> Result> { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / if let Some((k, v)) = self.entries.push(key, Value::Regular(val)) { [INFO] [stdout] 151 | | Some((k, v.out(&mut 0)?)) [INFO] [stdout] 152 | | } else { [INFO] [stdout] 153 | | None [INFO] [stdout] 154 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pageman` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binable.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 75 | Ok(if is_some { [INFO] [stdout] | ____________^ [INFO] [stdout] 76 | | Some(B::decode_from(rdr)?) [INFO] [stdout] 77 | | } else { [INFO] [stdout] 78 | | None [INFO] [stdout] 79 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 85 | let file = fs::File::options() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 93 | | cache: Cache::new(cache_cap), [INFO] [stdout] 94 | | counter: Counter::default(), [INFO] [stdout] 95 | | dir: index_dir.clone(), [INFO] [stdout] 96 | | file, [INFO] [stdout] 97 | | vacants: RoaringBitmap::from([0]), [INFO] [stdout] 98 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:226:35 [INFO] [stdout] | [INFO] [stdout] 226 | .try_for_each(|entry| self.flush(entry).wrap_err("failed to flush the page")) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/cache.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 28 | fn out(self, pin_count: &mut usize) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 30 | | Value::Detached => bail!("Value is detached"), [INFO] [stdout] 31 | | Value::Pinned(v) => { [INFO] [stdout] 32 | | *pin_count -= 1; [INFO] [stdout] ... | [INFO] [stdout] 35 | | Value::Regular(v) => v, [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/cache.rs:143:31 [INFO] [stdout] | [INFO] [stdout] 143 | .map(|(k, v)| (k, v.out(&mut 0).unwrap())) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/cache.rs:150:13 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn push(&mut self, key: K, val: V) -> Result> { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / if let Some((k, v)) = self.entries.push(key, Value::Regular(val)) { [INFO] [stdout] 151 | | Some((k, v.out(&mut 0)?)) [INFO] [stdout] 152 | | } else { [INFO] [stdout] 153 | | None [INFO] [stdout] 154 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pageman` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "3ffa59d0c02e09e61d3ac4914a0d390f54ed33372055e7cc61133b2809e5383b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ffa59d0c02e09e61d3ac4914a0d390f54ed33372055e7cc61133b2809e5383b", kill_on_drop: false }` [INFO] [stdout] 3ffa59d0c02e09e61d3ac4914a0d390f54ed33372055e7cc61133b2809e5383b