[INFO] fetching crate pafn 0.0.0... [INFO] checking pafn-0.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pafn 0.0.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate pafn 0.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pafn 0.0.0 [INFO] finished tweaking crates.io crate pafn 0.0.0 [INFO] tweaked toml for crates.io crate pafn 0.0.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dd42ec178c4b80f994dafce82c033188fa0f21bbc779958016e884991da042c0 [INFO] running `Command { std: "docker" "start" "-a" "dd42ec178c4b80f994dafce82c033188fa0f21bbc779958016e884991da042c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dd42ec178c4b80f994dafce82c033188fa0f21bbc779958016e884991da042c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd42ec178c4b80f994dafce82c033188fa0f21bbc779958016e884991da042c0", kill_on_drop: false }` [INFO] [stdout] dd42ec178c4b80f994dafce82c033188fa0f21bbc779958016e884991da042c0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b6c195f0a86a7e77dad14e6a7296c2ec59332c1946106d48d497fd95efd91946 [INFO] running `Command { std: "docker" "start" "-a" "b6c195f0a86a7e77dad14e6a7296c2ec59332c1946106d48d497fd95efd91946", kill_on_drop: false }` [INFO] [stderr] Checking pafn v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `comp` is never used [INFO] [stdout] --> src/paf1_2.rs:3:4 [INFO] [stdout] | [INFO] [stdout] 3 | fn comp(f: F, g: G) -> impl Fn(X) -> Z [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `comp2` is never used [INFO] [stdout] --> src/paf1_2.rs:11:4 [INFO] [stdout] | [INFO] [stdout] 11 | fn comp2(f: F, g: G) -> impl Fn((Pf, Pg), X) -> Z [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PaFn` is never constructed [INFO] [stdout] --> src/paf1_2.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 42 | struct PaFn(Box Y>); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `run` and `bind` are never used [INFO] [stdout] --> src/paf1_2.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 44 | impl PaFn { [INFO] [stdout] | --------------------------------------- methods in this implementation [INFO] [stdout] 45 | pub fn run(&self, p: P) -> Y { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 49 | pub fn bind PaFn + 'static>(self, g: G) -> PaFn<(P, Pg), Z> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paf1_2.rs:8:16 [INFO] [stdout] | [INFO] [stdout] 3 | fn comp(f: F, g: G) -> impl Fn(X) -> Z [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 8 | move |x| f(g(x)) [INFO] [stdout] | - ^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paf1_2.rs:16:30 [INFO] [stdout] | [INFO] [stdout] 11 | fn comp2(f: F, g: G) -> impl Fn((Pf, Pg), X) -> Z [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | move |(pf, pg), x| f(pf, g(pg, x)) [INFO] [stdout] | -------- - ^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paf1_2.rs:36:16 [INFO] [stdout] | [INFO] [stdout] 34 | fn shr(self, rhs: PAF) -> Self::Output { [INFO] [stdout] | ---- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | PAF { [INFO] [stdout] 36 | f: Box::new(move |(pf, pg), x| (self.f)(pf, (rhs.f)(pg, x))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paf1_2.rs:36:57 [INFO] [stdout] | [INFO] [stdout] 34 | fn shr(self, rhs: PAF) -> Self::Output { [INFO] [stdout] | ---- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | PAF { [INFO] [stdout] 36 | f: Box::new(move |(pf, pg), x| (self.f)(pf, (rhs.f)(pg, x))), [INFO] [stdout] | -------- - ^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paf1_2.rs:50:14 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn bind PaFn + 'static>(self, g: G) -> PaFn<(P, Pg), Z> { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | PaFn(Box::new(move |(p, pg)| { [INFO] [stdout] | ______________^ [INFO] [stdout] 51 | | g(self.run(p)).run(pg) [INFO] [stdout] 52 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paf1_2.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn bind PaFn + 'static>(self, g: G) -> PaFn<(P, Pg), Z> { [INFO] [stdout] | ---- - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | PaFn(Box::new(move |(p, pg)| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | g(self.run(p)).run(pg) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pafn` (lib) due to 7 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `comp` is never used [INFO] [stdout] --> src/paf1_2.rs:3:4 [INFO] [stdout] | [INFO] [stdout] 3 | fn comp(f: F, g: G) -> impl Fn(X) -> Z [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `comp2` is never used [INFO] [stdout] --> src/paf1_2.rs:11:4 [INFO] [stdout] | [INFO] [stdout] 11 | fn comp2(f: F, g: G) -> impl Fn((Pf, Pg), X) -> Z [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PaFn` is never constructed [INFO] [stdout] --> src/paf1_2.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 42 | struct PaFn(Box Y>); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `run` and `bind` are never used [INFO] [stdout] --> src/paf1_2.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 44 | impl PaFn { [INFO] [stdout] | --------------------------------------- methods in this implementation [INFO] [stdout] 45 | pub fn run(&self, p: P) -> Y { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 49 | pub fn bind PaFn + 'static>(self, g: G) -> PaFn<(P, Pg), Z> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paf1_2.rs:8:16 [INFO] [stdout] | [INFO] [stdout] 3 | fn comp(f: F, g: G) -> impl Fn(X) -> Z [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 8 | move |x| f(g(x)) [INFO] [stdout] | - ^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paf1_2.rs:16:30 [INFO] [stdout] | [INFO] [stdout] 11 | fn comp2(f: F, g: G) -> impl Fn((Pf, Pg), X) -> Z [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | move |(pf, pg), x| f(pf, g(pg, x)) [INFO] [stdout] | -------- - ^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paf1_2.rs:36:16 [INFO] [stdout] | [INFO] [stdout] 34 | fn shr(self, rhs: PAF) -> Self::Output { [INFO] [stdout] | ---- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | PAF { [INFO] [stdout] 36 | f: Box::new(move |(pf, pg), x| (self.f)(pf, (rhs.f)(pg, x))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paf1_2.rs:36:57 [INFO] [stdout] | [INFO] [stdout] 34 | fn shr(self, rhs: PAF) -> Self::Output { [INFO] [stdout] | ---- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | PAF { [INFO] [stdout] 36 | f: Box::new(move |(pf, pg), x| (self.f)(pf, (rhs.f)(pg, x))), [INFO] [stdout] | -------- - ^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paf1_2.rs:50:14 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn bind PaFn + 'static>(self, g: G) -> PaFn<(P, Pg), Z> { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | PaFn(Box::new(move |(p, pg)| { [INFO] [stdout] | ______________^ [INFO] [stdout] 51 | | g(self.run(p)).run(pg) [INFO] [stdout] 52 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paf1_2.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn bind PaFn + 'static>(self, g: G) -> PaFn<(P, Pg), Z> { [INFO] [stdout] | ---- - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | PaFn(Box::new(move |(p, pg)| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | g(self.run(p)).run(pg) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pafn` (lib test) due to 7 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b6c195f0a86a7e77dad14e6a7296c2ec59332c1946106d48d497fd95efd91946", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6c195f0a86a7e77dad14e6a7296c2ec59332c1946106d48d497fd95efd91946", kill_on_drop: false }` [INFO] [stdout] b6c195f0a86a7e77dad14e6a7296c2ec59332c1946106d48d497fd95efd91946