[INFO] fetching crate padantic 0.1.0... [INFO] checking padantic-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate padantic 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate padantic 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate padantic 0.1.0 [INFO] finished tweaking crates.io crate padantic 0.1.0 [INFO] tweaked toml for crates.io crate padantic 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate padantic 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe5650d0b2a9d323f9ed20dd45ede2c8316f2009aec9b3a3a7ee4f81f36cac57 [INFO] running `Command { std: "docker" "start" "-a" "fe5650d0b2a9d323f9ed20dd45ede2c8316f2009aec9b3a3a7ee4f81f36cac57", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe5650d0b2a9d323f9ed20dd45ede2c8316f2009aec9b3a3a7ee4f81f36cac57", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe5650d0b2a9d323f9ed20dd45ede2c8316f2009aec9b3a3a7ee4f81f36cac57", kill_on_drop: false }` [INFO] [stdout] fe5650d0b2a9d323f9ed20dd45ede2c8316f2009aec9b3a3a7ee4f81f36cac57 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 50929992e7d9d8be139fe0fe735cd9bb000987ad17c035ba27285d3db225f17f [INFO] running `Command { std: "docker" "start" "-a" "50929992e7d9d8be139fe0fe735cd9bb000987ad17c035ba27285d3db225f17f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.67 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking arc-swap v0.4.4 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking smallvec v1.2.0 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking lock_api v0.3.3 [INFO] [stderr] Compiling syn v1.0.16 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling doc-comment v0.3.2 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking parking_lot_core v0.7.0 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking parking_lot v0.10.0 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking term v0.6.1 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking crossbeam-channel v0.4.2 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking unicode-segmentation v1.6.0 [INFO] [stderr] Checking crossbeam v0.7.3 [INFO] [stderr] Checking signal-hook v0.1.13 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking hex v0.4.2 [INFO] [stderr] Checking base64 v0.11.0 [INFO] [stderr] Checking crossterm v0.14.2 [INFO] [stderr] Checking crossterm v0.16.0 [INFO] [stderr] Checking tui v0.8.0 [INFO] [stderr] Checking simplelog v0.7.4 [INFO] [stderr] Compiling snafu-derive v0.6.2 [INFO] [stderr] Checking snafu v0.6.2 [INFO] [stderr] Checking padantic v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/oracle.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 51 | let mut child = Command::new(&ctx.cmd) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let err = child.stderr.take().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let writer = BufWriter::new(child.stdin.take().unwrap()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let reader = BufReader::new(child.stdout.take().unwrap()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Ok(CmdOracle { child, writer, reader }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/oracle.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 51 | let mut child = Command::new(&ctx.cmd) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let err = child.stderr.take().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let writer = BufWriter::new(child.stdin.take().unwrap()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let reader = BufReader::new(child.stdout.take().unwrap()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Ok(CmdOracle { child, writer, reader }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypt.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 55 | oracle: CmdOracle, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | Ok(BlockDecypt { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | b_inter: vec![0u8; blksz], [INFO] [stdout] 68 | | b_plain: vec![0u8; blksz], [INFO] [stdout] 69 | | blksz: blksz as u8, [INFO] [stdout] 70 | | b_pyld, iv, oracle, chars, last, cb, block [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypt.rs:89:16 [INFO] [stdout] | [INFO] [stdout] 74 | fn decrypt_byte(&mut self, i: u8, mut chars: impl Iterator) [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | .ok_or(Error::Tries) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypt.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | / BlockDecypt::new(blk1, blk0, [INFO] [stdout] 153 | | oracle.spawn().context(Oracle)?, [INFO] [stdout] 154 | | chars, prog, i -1, [INFO] [stdout] 155 | | i == blkc -1 && (iv || blkc > 2))? [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypt.rs:159:22 [INFO] [stdout] | [INFO] [stdout] 159 | .map(|h| h.join().unwrap()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypt.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 55 | oracle: CmdOracle, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | Ok(BlockDecypt { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | b_inter: vec![0u8; blksz], [INFO] [stdout] 68 | | b_plain: vec![0u8; blksz], [INFO] [stdout] 69 | | blksz: blksz as u8, [INFO] [stdout] 70 | | b_pyld, iv, oracle, chars, last, cb, block [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypt.rs:89:16 [INFO] [stdout] | [INFO] [stdout] 74 | fn decrypt_byte(&mut self, i: u8, mut chars: impl Iterator) [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | .ok_or(Error::Tries) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypt.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | / BlockDecypt::new(blk1, blk0, [INFO] [stdout] 153 | | oracle.spawn().context(Oracle)?, [INFO] [stdout] 154 | | chars, prog, i -1, [INFO] [stdout] 155 | | i == blkc -1 && (iv || blkc > 2))? [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypt.rs:159:22 [INFO] [stdout] | [INFO] [stdout] 159 | .map(|h| h.join().unwrap()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `padantic` (bin "padantic" test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `padantic` (bin "padantic") due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "50929992e7d9d8be139fe0fe735cd9bb000987ad17c035ba27285d3db225f17f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50929992e7d9d8be139fe0fe735cd9bb000987ad17c035ba27285d3db225f17f", kill_on_drop: false }` [INFO] [stdout] 50929992e7d9d8be139fe0fe735cd9bb000987ad17c035ba27285d3db225f17f