[INFO] fetching crate packman 0.1.2... [INFO] checking packman-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate packman 0.1.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate packman 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate packman 0.1.2 [INFO] finished tweaking crates.io crate packman 0.1.2 [INFO] tweaked toml for crates.io crate packman 0.1.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate packman 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 92a8c98adcfd96634a18bafd0e0f4f6e6e5c8b841a17384762bcc014e619ce83 [INFO] running `Command { std: "docker" "start" "-a" "92a8c98adcfd96634a18bafd0e0f4f6e6e5c8b841a17384762bcc014e619ce83", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "92a8c98adcfd96634a18bafd0e0f4f6e6e5c8b841a17384762bcc014e619ce83", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "92a8c98adcfd96634a18bafd0e0f4f6e6e5c8b841a17384762bcc014e619ce83", kill_on_drop: false }` [INFO] [stdout] 92a8c98adcfd96634a18bafd0e0f4f6e6e5c8b841a17384762bcc014e619ce83 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] da6f3d919883d1b3c6b34618535f1b4f069496380703c0b74c2d5c589266f637 [INFO] running `Command { std: "docker" "start" "-a" "da6f3d919883d1b3c6b34618535f1b4f069496380703c0b74c2d5c589266f637", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.77 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling proc-macro2 v1.0.21 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling syn v1.0.40 [INFO] [stderr] Compiling serde_derive v1.0.115 [INFO] [stderr] Compiling serde v1.0.115 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking linked-hash-map v0.5.3 [INFO] [stderr] Checking dtoa v0.4.6 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking yaml-rust v0.4.4 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking ppv-lite86 v0.2.9 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking chrono v0.4.15 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking nanoid v0.3.0 [INFO] [stderr] Checking serde_yaml v0.8.13 [INFO] [stderr] Checking bincode v1.3.1 [INFO] [stderr] Checking packman v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `fmt::Display` [INFO] [stdout] --> src/fs.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use fmt::Display; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::marker::PhantomData` [INFO] [stdout] --> src/fs.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::marker::PhantomData; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fmt::Display` [INFO] [stdout] --> src/fs.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use fmt::Display; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::marker::PhantomData` [INFO] [stdout] --> src/fs.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::marker::PhantomData; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/fs.rs:372:27 [INFO] [stdout] | [INFO] [stdout] 372 | fn save_data(&mut self, data: &[u8]) -> PackResult<()> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `verify_magic` and `get_magic` are never used [INFO] [stdout] --> src/fs.rs:46:10 [INFO] [stdout] | [INFO] [stdout] 30 | impl Superblock { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 46 | pub fn verify_magic(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 49 | pub fn get_magic(&self) -> u64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `save_data`, `recover`, and `is_healthy` are never used [INFO] [stdout] --> src/fs.rs:372:6 [INFO] [stdout] | [INFO] [stdout] 233 | impl PackFile { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 372 | fn save_data(&mut self, data: &[u8]) -> PackResult<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 375 | fn recover(&mut self) {} [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 376 | fn is_healthy(&mut self) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `superblock_offset` is never used [INFO] [stdout] --> src/fs.rs:580:17 [INFO] [stdout] | [INFO] [stdout] 580 | pub(crate) fn superblock_offset() -> u64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `file_size` is never used [INFO] [stdout] --> src/fs.rs:595:17 [INFO] [stdout] | [INFO] [stdout] 595 | pub(crate) fn file_size(inode_a: &Inode, inode_b: &Inode) -> u64 [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:331:11 [INFO] [stdout] | [INFO] [stdout] 330 | let mut pack_file = fs::PackFile::open(&path)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 331 | match bincode::deserialize::(&pack_file.load_data()?) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:504:9 [INFO] [stdout] | [INFO] [stdout] 503 | .filter_map(|file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 504 | file.ok().and_then(|e| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:591:9 [INFO] [stdout] | [INFO] [stdout] 590 | .filter_map(|file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 591 | file.ok().and_then(|e| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn serialize_into(&mut self, w: W) -> PackResult<()> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | bincode::serialize_into(w, self).map_err(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn serialize_into(&mut self, w: W) -> PackResult<()> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | bincode::serialize_into(w, self).map_err(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `packman` (lib) due to 6 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/fs.rs:372:27 [INFO] [stdout] | [INFO] [stdout] 372 | fn save_data(&mut self, data: &[u8]) -> PackResult<()> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `verify_magic` and `get_magic` are never used [INFO] [stdout] --> src/fs.rs:46:10 [INFO] [stdout] | [INFO] [stdout] 30 | impl Superblock { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 46 | pub fn verify_magic(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 49 | pub fn get_magic(&self) -> u64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `save_data`, `recover`, and `is_healthy` are never used [INFO] [stdout] --> src/fs.rs:372:6 [INFO] [stdout] | [INFO] [stdout] 233 | impl PackFile { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 372 | fn save_data(&mut self, data: &[u8]) -> PackResult<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 375 | fn recover(&mut self) {} [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 376 | fn is_healthy(&mut self) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `superblock_offset` is never used [INFO] [stdout] --> src/fs.rs:580:17 [INFO] [stdout] | [INFO] [stdout] 580 | pub(crate) fn superblock_offset() -> u64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `file_size` is never used [INFO] [stdout] --> src/fs.rs:595:17 [INFO] [stdout] | [INFO] [stdout] 595 | pub(crate) fn file_size(inode_a: &Inode, inode_b: &Inode) -> u64 [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:331:11 [INFO] [stdout] | [INFO] [stdout] 330 | let mut pack_file = fs::PackFile::open(&path)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 331 | match bincode::deserialize::(&pack_file.load_data()?) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:504:9 [INFO] [stdout] | [INFO] [stdout] 503 | .filter_map(|file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 504 | file.ok().and_then(|e| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:591:9 [INFO] [stdout] | [INFO] [stdout] 590 | .filter_map(|file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 591 | file.ok().and_then(|e| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn serialize_into(&mut self, w: W) -> PackResult<()> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | bincode::serialize_into(w, self).map_err(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn serialize_into(&mut self, w: W) -> PackResult<()> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | bincode::serialize_into(w, self).map_err(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `packman` (lib test) due to 6 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "da6f3d919883d1b3c6b34618535f1b4f069496380703c0b74c2d5c589266f637", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "da6f3d919883d1b3c6b34618535f1b4f069496380703c0b74c2d5c589266f637", kill_on_drop: false }` [INFO] [stdout] da6f3d919883d1b3c6b34618535f1b4f069496380703c0b74c2d5c589266f637