[INFO] fetching crate packetize_derive 0.96.0... [INFO] checking packetize_derive-0.96.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate packetize_derive 0.96.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate packetize_derive 0.96.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate packetize_derive 0.96.0 [INFO] finished tweaking crates.io crate packetize_derive 0.96.0 [INFO] tweaked toml for crates.io crate packetize_derive 0.96.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 95902adce126635378d5d9f315ca6f55c3823f2ef7b2d1270bc06ac97fb6330a [INFO] running `Command { std: "docker" "start" "-a" "95902adce126635378d5d9f315ca6f55c3823f2ef7b2d1270bc06ac97fb6330a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "95902adce126635378d5d9f315ca6f55c3823f2ef7b2d1270bc06ac97fb6330a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95902adce126635378d5d9f315ca6f55c3823f2ef7b2d1270bc06ac97fb6330a", kill_on_drop: false }` [INFO] [stdout] 95902adce126635378d5d9f315ca6f55c3823f2ef7b2d1270bc06ac97fb6330a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9b3ba9b3b8a8b7ffbb6d80a0bde29b9e59c687caf92d03ef6c431819f94d5f02 [INFO] running `Command { std: "docker" "start" "-a" "9b3ba9b3b8a8b7ffbb6d80a0bde29b9e59c687caf92d03ef6c431819f94d5f02", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking packetize_derive v0.96.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `quotes_of_match_case` [INFO] [stdout] --> src/lib.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | let quotes_of_match_case: Vec<_> = packet_stream.states.iter().map(|state| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_quotes_of_match_case` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `encode_packet` [INFO] [stdout] --> src/lib.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | let encode_packet = if bound_packets.is_empty() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_encode_packet` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state_idents` [INFO] [stdout] --> src/lib.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 214 | let state_idents: Vec<&Ident> = idents_by_states(&packet_stream.states); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_state_idents` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `decode_fn_name` [INFO] [stdout] --> src/lib.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 215 | let decode_fn_name = format_ident!("decode_{}_packet", bound.fn_name); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_decode_fn_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `encode_fn_name` [INFO] [stdout] --> src/lib.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | let encode_fn_name = format_ident!("encode_{}_packet", bound.fn_name); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_encode_fn_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `trait_name` [INFO] [stdout] --> src/lib.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 217 | let trait_name = format_ident!("{}", bound.trait_name); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_trait_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:292:33 [INFO] [stdout] | [INFO] [stdout] 292 | changing_state: find_ident_in_attrs(&field.attrs, "change_state_to").map(|attr| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 293 | | match attr.meta { [INFO] [stdout] 294 | | syn::Meta::List(list) => list.tokens, [INFO] [stdout] 295 | | _ => panic!("attribute needs single value input"), [INFO] [stdout] 296 | | } [INFO] [stdout] 297 | | }), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:298:30 [INFO] [stdout] | [INFO] [stdout] 298 | enforced_id: find_ident_in_attrs(&field.attrs, "id").map(|attr| { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 299 | | match attr.meta { [INFO] [stdout] 300 | | syn::Meta::List(list) => { [INFO] [stdout] 301 | | let tokens = list.tokens; [INFO] [stdout] ... | [INFO] [stdout] 305 | | } [INFO] [stdout] 306 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `packetize_derive` (lib) due to 3 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `quotes_of_match_case` [INFO] [stdout] --> src/lib.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | let quotes_of_match_case: Vec<_> = packet_stream.states.iter().map(|state| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_quotes_of_match_case` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `encode_packet` [INFO] [stdout] --> src/lib.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | let encode_packet = if bound_packets.is_empty() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_encode_packet` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state_idents` [INFO] [stdout] --> src/lib.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 214 | let state_idents: Vec<&Ident> = idents_by_states(&packet_stream.states); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_state_idents` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `decode_fn_name` [INFO] [stdout] --> src/lib.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 215 | let decode_fn_name = format_ident!("decode_{}_packet", bound.fn_name); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_decode_fn_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `encode_fn_name` [INFO] [stdout] --> src/lib.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | let encode_fn_name = format_ident!("encode_{}_packet", bound.fn_name); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_encode_fn_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `trait_name` [INFO] [stdout] --> src/lib.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 217 | let trait_name = format_ident!("{}", bound.trait_name); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_trait_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:292:33 [INFO] [stdout] | [INFO] [stdout] 292 | changing_state: find_ident_in_attrs(&field.attrs, "change_state_to").map(|attr| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 293 | | match attr.meta { [INFO] [stdout] 294 | | syn::Meta::List(list) => list.tokens, [INFO] [stdout] 295 | | _ => panic!("attribute needs single value input"), [INFO] [stdout] 296 | | } [INFO] [stdout] 297 | | }), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:298:30 [INFO] [stdout] | [INFO] [stdout] 298 | enforced_id: find_ident_in_attrs(&field.attrs, "id").map(|attr| { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 299 | | match attr.meta { [INFO] [stdout] 300 | | syn::Meta::List(list) => { [INFO] [stdout] 301 | | let tokens = list.tokens; [INFO] [stdout] ... | [INFO] [stdout] 305 | | } [INFO] [stdout] 306 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `packetize_derive` (lib test) due to 3 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9b3ba9b3b8a8b7ffbb6d80a0bde29b9e59c687caf92d03ef6c431819f94d5f02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b3ba9b3b8a8b7ffbb6d80a0bde29b9e59c687caf92d03ef6c431819f94d5f02", kill_on_drop: false }` [INFO] [stdout] 9b3ba9b3b8a8b7ffbb6d80a0bde29b9e59c687caf92d03ef6c431819f94d5f02