[INFO] fetching crate p3-symmetric 0.2.0... [INFO] checking p3-symmetric-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate p3-symmetric 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate p3-symmetric 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate p3-symmetric 0.2.0 [INFO] finished tweaking crates.io crate p3-symmetric 0.2.0 [INFO] tweaked toml for crates.io crate p3-symmetric 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 27 packages to latest compatible versions [INFO] [stderr] Adding nums v0.1.0 (latest: v1.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe3d45b9eaf5cc4b6d3d9b00c0d5ae9aea5c6ec685466da9ace3c2ac2b627816 [INFO] running `Command { std: "docker" "start" "-a" "fe3d45b9eaf5cc4b6d3d9b00c0d5ae9aea5c6ec685466da9ace3c2ac2b627816", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe3d45b9eaf5cc4b6d3d9b00c0d5ae9aea5c6ec685466da9ace3c2ac2b627816", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe3d45b9eaf5cc4b6d3d9b00c0d5ae9aea5c6ec685466da9ace3c2ac2b627816", kill_on_drop: false }` [INFO] [stdout] fe3d45b9eaf5cc4b6d3d9b00c0d5ae9aea5c6ec685466da9ace3c2ac2b627816 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f9cd5ed3421377bee5c2145199dc4674bc4d27fc7ffcea03495d14cec224c153 [INFO] running `Command { std: "docker" "start" "-a" "f9cd5ed3421377bee5c2145199dc4674bc4d27fc7ffcea03495d14cec224c153", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking nums v0.1.0 [INFO] [stderr] Checking p3-util v0.2.0 [INFO] [stderr] Checking p3-field v0.2.0 [INFO] [stderr] Checking p3-symmetric v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compression.rs:76:31 [INFO] [stdout] | [INFO] [stdout] 75 | fn compress(&self, input: [[T; CHUNK]; N]) -> [T; CHUNK] { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | self.hasher.hash_iter(input.into_iter().flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hasher.rs:11:24 [INFO] [stdout] | [INFO] [stdout] 6 | fn hash_iter_slices<'a, I>(&self, input: I) -> Out [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | self.hash_iter(input.into_iter().flatten().cloned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hasher.rs:19:26 [INFO] [stdout] | [INFO] [stdout] 18 | fn hash_item(&self, input: Item) -> Out { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | self.hash_slice(&[input]) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializing_hasher.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 34 | fn hash_iter(&self, input: I) -> [u8; 32] [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | / input [INFO] [stdout] 40 | | .into_iter() [INFO] [stdout] 41 | | .flat_map(|x| x.as_canonical_u32().to_le_bytes()), [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializing_hasher.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 53 | fn hash_iter(&self, input: I) -> [PW; 8] [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | / input [INFO] [stdout] 59 | | .into_iter() [INFO] [stdout] 60 | | .map(|x| PW::from_fn(|i| x.as_slice()[i].as_canonical_u32())), [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializing_hasher.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 70 | fn hash_iter(&self, input: I) -> [u8; 32] [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | / input [INFO] [stdout] 76 | | .into_iter() [INFO] [stdout] 77 | | .flat_map(|x| x.as_canonical_u64().to_le_bytes()), [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializing_hasher.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 89 | fn hash_iter(&self, input: I) -> [PW; 4] [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | / input [INFO] [stdout] 95 | | .into_iter() [INFO] [stdout] 96 | | .map(|x| PW::from_fn(|i| x.as_slice()[i].as_canonical_u64())), [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sponge.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn new(permutation: P) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | permutation, [INFO] [stdout] 78 | | num_f_elms, [INFO] [stdout] 79 | | _phantom: PhantomData, [INFO] [stdout] 80 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `p3-symmetric` (lib test) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compression.rs:76:31 [INFO] [stdout] | [INFO] [stdout] 75 | fn compress(&self, input: [[T; CHUNK]; N]) -> [T; CHUNK] { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | self.hasher.hash_iter(input.into_iter().flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hasher.rs:11:24 [INFO] [stdout] | [INFO] [stdout] 6 | fn hash_iter_slices<'a, I>(&self, input: I) -> Out [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | self.hash_iter(input.into_iter().flatten().cloned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hasher.rs:19:26 [INFO] [stdout] | [INFO] [stdout] 18 | fn hash_item(&self, input: Item) -> Out { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | self.hash_slice(&[input]) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializing_hasher.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 34 | fn hash_iter(&self, input: I) -> [u8; 32] [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | / input [INFO] [stdout] 40 | | .into_iter() [INFO] [stdout] 41 | | .flat_map(|x| x.as_canonical_u32().to_le_bytes()), [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializing_hasher.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 53 | fn hash_iter(&self, input: I) -> [PW; 8] [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | / input [INFO] [stdout] 59 | | .into_iter() [INFO] [stdout] 60 | | .map(|x| PW::from_fn(|i| x.as_slice()[i].as_canonical_u32())), [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializing_hasher.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 70 | fn hash_iter(&self, input: I) -> [u8; 32] [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | / input [INFO] [stdout] 76 | | .into_iter() [INFO] [stdout] 77 | | .flat_map(|x| x.as_canonical_u64().to_le_bytes()), [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializing_hasher.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 89 | fn hash_iter(&self, input: I) -> [PW; 4] [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | / input [INFO] [stdout] 95 | | .into_iter() [INFO] [stdout] 96 | | .map(|x| PW::from_fn(|i| x.as_slice()[i].as_canonical_u64())), [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sponge.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn new(permutation: P) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | permutation, [INFO] [stdout] 78 | | num_f_elms, [INFO] [stdout] 79 | | _phantom: PhantomData, [INFO] [stdout] 80 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `p3-symmetric` (lib) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "f9cd5ed3421377bee5c2145199dc4674bc4d27fc7ffcea03495d14cec224c153", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9cd5ed3421377bee5c2145199dc4674bc4d27fc7ffcea03495d14cec224c153", kill_on_drop: false }` [INFO] [stdout] f9cd5ed3421377bee5c2145199dc4674bc4d27fc7ffcea03495d14cec224c153