[INFO] fetching crate p2p_channel 0.5.1... [INFO] checking p2p_channel-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate p2p_channel 0.5.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate p2p_channel 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate p2p_channel 0.5.1 [INFO] finished tweaking crates.io crate p2p_channel 0.5.1 [INFO] tweaked toml for crates.io crate p2p_channel 0.5.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate p2p_channel 0.5.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5b7922e73fb83edbc9c3fcf9264c523a56e68a0fd01db590433438c8d37b60ba [INFO] running `Command { std: "docker" "start" "-a" "5b7922e73fb83edbc9c3fcf9264c523a56e68a0fd01db590433438c8d37b60ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5b7922e73fb83edbc9c3fcf9264c523a56e68a0fd01db590433438c8d37b60ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b7922e73fb83edbc9c3fcf9264c523a56e68a0fd01db590433438c8d37b60ba", kill_on_drop: false }` [INFO] [stdout] 5b7922e73fb83edbc9c3fcf9264c523a56e68a0fd01db590433438c8d37b60ba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9aad087b5e74c4a91692fadbf7eddd9d132ffce5a81a432e739eb2e92095a6be [INFO] running `Command { std: "docker" "start" "-a" "9aad087b5e74c4a91692fadbf7eddd9d132ffce5a81a432e739eb2e92095a6be", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Compiling network-interface v2.0.0 [INFO] [stderr] Checking r-ex v1.0.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking crossbeam-skiplist v0.1.3 [INFO] [stderr] Checking stun-bytes v1.0.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking stun-format v1.0.1 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking clap_builder v4.5.13 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking dashmap v6.0.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking ctrlc2 v3.5.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking clap v4.5.13 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking p2p_channel v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `index` is never read [INFO] [stdout] --> src/stun/socket/mod.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct LocalInterface { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 23 | index: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LocalInterface` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boot/mod.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 23 | let (cone_sender, cone_receiver) = bounded(1); [INFO] [stdout] | ----------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let (symmetric_sender, symmetric_receiver) = bounded(1); [INFO] [stdout] | ---------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let direct_route_table_time = Arc::new(SkipMap::new()); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let parker = Parker::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let un_parker = parker.unparker().clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let status = Arc::new(AtomicCell::new(Status::Cone)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let channel = Channel::::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let sender = channel.sender()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let punch = Punch::new(cone_receiver, symmetric_receiver, sender); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let idle = Idle::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | Ok((channel, punch, idle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/mod.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 111 | cone_sender: PunchSender<(ID, NatInfo)>, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | symmetric_sender: PunchSender<(ID, NatInfo)>, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | direct_route_table_time: Arc>, AtomicI64, AtomicI64)>>, [INFO] [stdout] | --------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | un_parker: Unparker, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | status: Arc>, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | ) -> io::Result> { [INFO] [stdout] 117 | let channel_flag_gen = Arc::new(AtomicU64::new(1)); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | let channel_flag = 0; [INFO] [stdout] 119 | let src_default_udp = UdpSocket::bind("0.0.0.0:0")?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | src_default_udp.set_nonblocking(true)?; [INFO] [stdout] 121 | let mut default_udp = MioUdpSocket::from_std(src_default_udp.try_clone()?); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | let share_info = Arc::new(RwLock::new(Vec::with_capacity(size))); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | let udp_list = Vec::with_capacity(size); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | let direct_route_table = Arc::new(DashMap::with_capacity(64)); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let poll = Poll::new()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let waker = Waker::new(poll.registry(), CHANGE_TOKEN)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | let mut change_waker_list = Vec::with_capacity(16); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | change_waker_list.push((channel_flag, waker)); [INFO] [stdout] 131 | let change_waker_list = Arc::new(Mutex::new(change_waker_list)); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let lock = Arc::new(Mutex::new(())); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | Ok(Channel { [INFO] [stdout] | ____________^ [INFO] [stdout] 136 | | channel_flag_gen, [INFO] [stdout] 137 | | channel_flag, [INFO] [stdout] 138 | | src_default_udp, [INFO] [stdout] ... | [INFO] [stdout] 152 | | un_parker, [INFO] [stdout] 153 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/sender.rs:264:23 [INFO] [stdout] | [INFO] [stdout] 264 | .map(|k| (k.key().clone(), k.value().clone())) [INFO] [stdout] | - ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/punch/mod.rs:51:25 [INFO] [stdout] | [INFO] [stdout] 38 | cone_receiver: Receiver<(ID, NatInfo)>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | symmetric_receiver: Receiver<(ID, NatInfo)>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | sender: Sender, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | port_index: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/punch/mod.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 66 | let (id, nat_info) = if let Some(timeout) = timeout { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | match receiver.recv_timeout(timeout) { [INFO] [stdout] 68 | Ok(rs) => rs, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Ok(rs) => rs, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok((id, nat_info)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stun/mod.rs:40:19 [INFO] [stdout] | [INFO] [stdout] 20 | let mut hash_set = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Ok((nat_type, hash_set.into_iter().collect(), port_range)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `p2p_channel` (lib test) due to 7 previous errors; 1 warning emitted [INFO] [stdout] warning: field `index` is never read [INFO] [stdout] --> src/stun/socket/mod.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct LocalInterface { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 23 | index: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LocalInterface` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boot/mod.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 23 | let (cone_sender, cone_receiver) = bounded(1); [INFO] [stdout] | ----------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let (symmetric_sender, symmetric_receiver) = bounded(1); [INFO] [stdout] | ---------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let direct_route_table_time = Arc::new(SkipMap::new()); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let parker = Parker::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let un_parker = parker.unparker().clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let status = Arc::new(AtomicCell::new(Status::Cone)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let channel = Channel::::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let sender = channel.sender()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let punch = Punch::new(cone_receiver, symmetric_receiver, sender); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let idle = Idle::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | Ok((channel, punch, idle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/mod.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 111 | cone_sender: PunchSender<(ID, NatInfo)>, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | symmetric_sender: PunchSender<(ID, NatInfo)>, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | direct_route_table_time: Arc>, AtomicI64, AtomicI64)>>, [INFO] [stdout] | --------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | un_parker: Unparker, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | status: Arc>, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | ) -> io::Result> { [INFO] [stdout] 117 | let channel_flag_gen = Arc::new(AtomicU64::new(1)); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | let channel_flag = 0; [INFO] [stdout] 119 | let src_default_udp = UdpSocket::bind("0.0.0.0:0")?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | src_default_udp.set_nonblocking(true)?; [INFO] [stdout] 121 | let mut default_udp = MioUdpSocket::from_std(src_default_udp.try_clone()?); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | let share_info = Arc::new(RwLock::new(Vec::with_capacity(size))); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | let udp_list = Vec::with_capacity(size); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | let direct_route_table = Arc::new(DashMap::with_capacity(64)); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let poll = Poll::new()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let waker = Waker::new(poll.registry(), CHANGE_TOKEN)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | let mut change_waker_list = Vec::with_capacity(16); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | change_waker_list.push((channel_flag, waker)); [INFO] [stdout] 131 | let change_waker_list = Arc::new(Mutex::new(change_waker_list)); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let lock = Arc::new(Mutex::new(())); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | Ok(Channel { [INFO] [stdout] | ____________^ [INFO] [stdout] 136 | | channel_flag_gen, [INFO] [stdout] 137 | | channel_flag, [INFO] [stdout] 138 | | src_default_udp, [INFO] [stdout] ... | [INFO] [stdout] 152 | | un_parker, [INFO] [stdout] 153 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/sender.rs:264:23 [INFO] [stdout] | [INFO] [stdout] 264 | .map(|k| (k.key().clone(), k.value().clone())) [INFO] [stdout] | - ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/punch/mod.rs:51:25 [INFO] [stdout] | [INFO] [stdout] 38 | cone_receiver: Receiver<(ID, NatInfo)>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | symmetric_receiver: Receiver<(ID, NatInfo)>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | sender: Sender, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | port_index: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/punch/mod.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 66 | let (id, nat_info) = if let Some(timeout) = timeout { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | match receiver.recv_timeout(timeout) { [INFO] [stdout] 68 | Ok(rs) => rs, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Ok(rs) => rs, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok((id, nat_info)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stun/mod.rs:40:19 [INFO] [stdout] | [INFO] [stdout] 20 | let mut hash_set = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Ok((nat_type, hash_set.into_iter().collect(), port_range)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `p2p_channel` (lib) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "9aad087b5e74c4a91692fadbf7eddd9d132ffce5a81a432e739eb2e92095a6be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9aad087b5e74c4a91692fadbf7eddd9d132ffce5a81a432e739eb2e92095a6be", kill_on_drop: false }` [INFO] [stdout] 9aad087b5e74c4a91692fadbf7eddd9d132ffce5a81a432e739eb2e92095a6be