[INFO] fetching crate oxisynth 0.0.5... [INFO] checking oxisynth-0.0.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate oxisynth 0.0.5 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate oxisynth 0.0.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate oxisynth 0.0.5 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate oxisynth 0.0.5 [INFO] tweaked toml for crates.io crate oxisynth 0.0.5 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate oxisynth 0.0.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cf1d27330a75f8cff8912caccc1e720b232ef8abde2938628769c3676077129c [INFO] running `Command { std: "docker" "start" "-a" "cf1d27330a75f8cff8912caccc1e720b232ef8abde2938628769c3676077129c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cf1d27330a75f8cff8912caccc1e720b232ef8abde2938628769c3676077129c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf1d27330a75f8cff8912caccc1e720b232ef8abde2938628769c3676077129c", kill_on_drop: false }` [INFO] [stdout] cf1d27330a75f8cff8912caccc1e720b232ef8abde2938628769c3676077129c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f4a83e2e9c347f495a20ca7573cd13bb7e6c5b787174db1128e5d34853e0be52 [INFO] running `Command { std: "docker" "start" "-a" "f4a83e2e9c347f495a20ca7573cd13bb7e6c5b787174db1128e5d34853e0be52", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.71 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Compiling thiserror v1.0.52 [INFO] [stderr] Checking riff v1.0.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking byte-slice-cast v1.2.2 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking generational-arena v0.2.9 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Checking soundfont v0.0.3 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling syn v2.0.43 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling thiserror-impl v1.0.52 [INFO] [stderr] Compiling num-derive v0.4.1 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Checking oxisynth v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `TuningManager` [INFO] [stdout] --> src/synth.rs:12:25 [INFO] [stdout] | [INFO] [stdout] 12 | pub use crate::{Tuning, TuningManager}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TuningManager` [INFO] [stdout] --> src/synth.rs:12:25 [INFO] [stdout] | [INFO] [stdout] 12 | pub use crate::{Tuning, TuningManager}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/channel_pool.rs:14:40 [INFO] [stdout] | [INFO] [stdout] 14 | .map(|id| Channel::new(id, preset.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/soundfont.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 52 | let sample_data = Arc::new(SampleData::load(file, sample_pos, sample_size)?); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | [INFO] [stdout] 54 | let mut samples = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let mut presets = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(Self { presets }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/soundfont/instrument.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 31 | let mut global_zone = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let mut zones = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 45 | | _name: name, [INFO] [stdout] 46 | | global_zone, [INFO] [stdout] 47 | | zones, [INFO] [stdout] 48 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/soundfont/instrument.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 113 | let sample = if let Some(sample_id) = zone.sample() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let sample = samples.iter().find(|sample| &sample.name == name).cloned(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 142 | | name, [INFO] [stdout] 143 | | sample, [INFO] [stdout] 144 | | key_low, [INFO] [stdout] ... | [INFO] [stdout] 149 | | mods, [INFO] [stdout] 150 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/soundfont/preset.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 30 | let mut global_zone = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let mut zones = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 45 | | name, [INFO] [stdout] 46 | | bank: preset.header.bank as u32, [INFO] [stdout] 47 | | num: preset.header.preset as u32, [INFO] [stdout] 48 | | global_zone, [INFO] [stdout] 49 | | zones, [INFO] [stdout] 50 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/soundfont/preset.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 126 | let inst = if let Some(id) = zone.instrument() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let i = Instrument::import(sf2, &sf2.instruments[*id as usize], samples)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | name, [INFO] [stdout] 148 | | inst, [INFO] [stdout] 149 | | key_low, [INFO] [stdout] ... | [INFO] [stdout] 154 | | mods, [INFO] [stdout] 155 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oxisynth` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/channel_pool.rs:14:40 [INFO] [stdout] | [INFO] [stdout] 14 | .map(|id| Channel::new(id, preset.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/soundfont.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 52 | let sample_data = Arc::new(SampleData::load(file, sample_pos, sample_size)?); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | [INFO] [stdout] 54 | let mut samples = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let mut presets = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(Self { presets }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/soundfont/instrument.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 31 | let mut global_zone = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let mut zones = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 45 | | _name: name, [INFO] [stdout] 46 | | global_zone, [INFO] [stdout] 47 | | zones, [INFO] [stdout] 48 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/soundfont/instrument.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 113 | let sample = if let Some(sample_id) = zone.sample() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let sample = samples.iter().find(|sample| &sample.name == name).cloned(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 142 | | name, [INFO] [stdout] 143 | | sample, [INFO] [stdout] 144 | | key_low, [INFO] [stdout] ... | [INFO] [stdout] 149 | | mods, [INFO] [stdout] 150 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/soundfont/preset.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 30 | let mut global_zone = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let mut zones = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 45 | | name, [INFO] [stdout] 46 | | bank: preset.header.bank as u32, [INFO] [stdout] 47 | | num: preset.header.preset as u32, [INFO] [stdout] 48 | | global_zone, [INFO] [stdout] 49 | | zones, [INFO] [stdout] 50 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/soundfont/preset.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 126 | let inst = if let Some(id) = zone.instrument() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let i = Instrument::import(sf2, &sf2.instruments[*id as usize], samples)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | name, [INFO] [stdout] 148 | | inst, [INFO] [stdout] 149 | | key_low, [INFO] [stdout] ... | [INFO] [stdout] 154 | | mods, [INFO] [stdout] 155 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oxisynth` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f4a83e2e9c347f495a20ca7573cd13bb7e6c5b787174db1128e5d34853e0be52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4a83e2e9c347f495a20ca7573cd13bb7e6c5b787174db1128e5d34853e0be52", kill_on_drop: false }` [INFO] [stdout] f4a83e2e9c347f495a20ca7573cd13bb7e6c5b787174db1128e5d34853e0be52