[INFO] fetching crate oxc_diagnostics 0.25.0... [INFO] checking oxc_diagnostics-0.25.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate oxc_diagnostics 0.25.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate oxc_diagnostics 0.25.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate oxc_diagnostics 0.25.0 [INFO] finished tweaking crates.io crate oxc_diagnostics 0.25.0 [INFO] tweaked toml for crates.io crate oxc_diagnostics 0.25.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 69cda4682de9e8b1688d21980f0663af0985ec3687f32dcdea22d9cecabb1133 [INFO] running `Command { std: "docker" "start" "-a" "69cda4682de9e8b1688d21980f0663af0985ec3687f32dcdea22d9cecabb1133", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "69cda4682de9e8b1688d21980f0663af0985ec3687f32dcdea22d9cecabb1133", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69cda4682de9e8b1688d21980f0663af0985ec3687f32dcdea22d9cecabb1133", kill_on_drop: false }` [INFO] [stdout] 69cda4682de9e8b1688d21980f0663af0985ec3687f32dcdea22d9cecabb1133 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 53ee4f60c790e0dbf96f5ae1e3b617a7f1a0c9ae5e1f769ab65faa5fd4f498f6 [INFO] running `Command { std: "docker" "start" "-a" "53ee4f60c790e0dbf96f5ae1e3b617a7f1a0c9ae5e1f769ab65faa5fd4f498f6", kill_on_drop: false }` [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking owo-colors v4.0.0 [INFO] [stderr] Compiling miette-derive v7.2.0 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking miette v7.2.0 [INFO] [stderr] Checking oxc_diagnostics v0.25.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:113:20 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn error>>(message: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | Self { [INFO] [stdout] 113 | inner: Box::new(OxcDiagnosticInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 114 | | message: message.into(), [INFO] [stdout] 115 | | labels: None, [INFO] [stdout] 116 | | help: None, [INFO] [stdout] 117 | | severity: Severity::Error, [INFO] [stdout] 118 | | code: OxcCode::default(), [INFO] [stdout] 119 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:125:20 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn warn>>(message: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | Self { [INFO] [stdout] 125 | inner: Box::new(OxcDiagnosticInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 126 | | message: message.into(), [INFO] [stdout] 127 | | labels: None, [INFO] [stdout] 128 | | help: None, [INFO] [stdout] 129 | | severity: Severity::Warning, [INFO] [stdout] 130 | | code: OxcCode::default(), [INFO] [stdout] 131 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 137 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | scope: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | number: U, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | ) -> Self { [INFO] [stdout] 141 | self.with_error_code_scope(scope).with_error_code_num(number) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 212 | pub fn with_source_code(self, code: T) -> Error { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | Error::from(self).with_source_code(code) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphic_reporter.rs:1169:12 [INFO] [stdout] | [INFO] [stdout] 1117 | let context_data = source [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1169 | Ok((context_data, lines)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:46:23 [INFO] [stdout] | [INFO] [stdout] 44 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Self { [INFO] [stdout] 46 | reporter: Box::::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:117:59 [INFO] [stdout] | [INFO] [stdout] 117 | .map(|diagnostic| diagnostic.with_source_code(Arc::clone(&source))) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oxc_diagnostics` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:113:20 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn error>>(message: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | Self { [INFO] [stdout] 113 | inner: Box::new(OxcDiagnosticInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 114 | | message: message.into(), [INFO] [stdout] 115 | | labels: None, [INFO] [stdout] 116 | | help: None, [INFO] [stdout] 117 | | severity: Severity::Error, [INFO] [stdout] 118 | | code: OxcCode::default(), [INFO] [stdout] 119 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:125:20 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn warn>>(message: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | Self { [INFO] [stdout] 125 | inner: Box::new(OxcDiagnosticInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 126 | | message: message.into(), [INFO] [stdout] 127 | | labels: None, [INFO] [stdout] 128 | | help: None, [INFO] [stdout] 129 | | severity: Severity::Warning, [INFO] [stdout] 130 | | code: OxcCode::default(), [INFO] [stdout] 131 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 137 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | scope: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | number: U, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | ) -> Self { [INFO] [stdout] 141 | self.with_error_code_scope(scope).with_error_code_num(number) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 212 | pub fn with_source_code(self, code: T) -> Error { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | Error::from(self).with_source_code(code) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphic_reporter.rs:1169:12 [INFO] [stdout] | [INFO] [stdout] 1117 | let context_data = source [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1169 | Ok((context_data, lines)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:46:23 [INFO] [stdout] | [INFO] [stdout] 44 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Self { [INFO] [stdout] 46 | reporter: Box::::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:117:59 [INFO] [stdout] | [INFO] [stdout] 117 | .map(|diagnostic| diagnostic.with_source_code(Arc::clone(&source))) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oxc_diagnostics` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "53ee4f60c790e0dbf96f5ae1e3b617a7f1a0c9ae5e1f769ab65faa5fd4f498f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53ee4f60c790e0dbf96f5ae1e3b617a7f1a0c9ae5e1f769ab65faa5fd4f498f6", kill_on_drop: false }` [INFO] [stdout] 53ee4f60c790e0dbf96f5ae1e3b617a7f1a0c9ae5e1f769ab65faa5fd4f498f6