[INFO] fetching crate oura 1.9.1... [INFO] checking oura-1.9.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate oura 1.9.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate oura 1.9.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate oura 1.9.1 [INFO] finished tweaking crates.io crate oura 1.9.1 [INFO] tweaked toml for crates.io crate oura 1.9.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate oura 1.9.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cb269eb2051a2f3ac7d7528e858d2caedc96bd4cc4195e080c50cce27335c3cd [INFO] running `Command { std: "docker" "start" "-a" "cb269eb2051a2f3ac7d7528e858d2caedc96bd4cc4195e080c50cce27335c3cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cb269eb2051a2f3ac7d7528e858d2caedc96bd4cc4195e080c50cce27335c3cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb269eb2051a2f3ac7d7528e858d2caedc96bd4cc4195e080c50cce27335c3cd", kill_on_drop: false }` [INFO] [stdout] cb269eb2051a2f3ac7d7528e858d2caedc96bd4cc4195e080c50cce27335c3cd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 48c54b1b23dbe27b288706616cb9f13f6433fdd1d48a9fddb8a3c8a866958c9b [INFO] running `Command { std: "docker" "start" "-a" "48c54b1b23dbe27b288706616cb9f13f6433fdd1d48a9fddb8a3c8a866958c9b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling thiserror v1.0.51 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling minicbor v0.20.0 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling minicbor v0.19.1 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking unicode-bidi v0.3.14 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking cryptoxide v0.4.4 [INFO] [stderr] Checking deranged v0.3.10 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling async-trait v0.1.74 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling prometheus v0.13.3 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking base58 v0.2.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking crc v3.0.1 [INFO] [stderr] Checking chunked_transfer v1.5.0 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking ascii v1.1.0 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling syn v2.0.41 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking unicode-truncate v0.2.0 [INFO] [stderr] Checking tiny_http v0.10.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling minicbor-derive v0.13.0 [INFO] [stderr] Compiling merge_derive v0.1.0 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Checking merge v0.1.0 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling thiserror-impl v1.0.51 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking prometheus_exporter v0.8.5 [INFO] [stderr] Checking pallas-codec v0.30.1 [INFO] [stderr] Checking pallas-codec v0.18.2 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking pallas-multiplexer v0.18.2 [INFO] [stderr] Checking pallas-crypto v0.30.1 [INFO] [stderr] Checking pallas-miniprotocols v0.18.2 [INFO] [stderr] Checking pallas-addresses v0.30.1 [INFO] [stderr] Checking pallas-primitives v0.30.1 [INFO] [stderr] Checking config v0.13.4 [INFO] [stderr] Checking pallas-traverse v0.30.1 [INFO] [stderr] Checking oura v1.9.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `ChainState` is never constructed [INFO] [stdout] --> src/utils/metrics.rs:26:19 [INFO] [stdout] | [INFO] [stdout] 26 | pub(crate) struct ChainState { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ChainState` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:198:22 [INFO] [stdout] | [INFO] [stdout] 194 | pub fn with_metrics(self, config: metrics::Config) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | let provider = metrics::Provider::initialize(&config).expect("metric server started"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | metrics: provider.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:224:20 [INFO] [stdout] | [INFO] [stdout] 221 | pub fn attach_utils_to(&self, target: T) -> WithUtils { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | utils: self.utils.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/noop.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 15 | fn bootstrap(&self, input: StageReceiver) -> PartialBootstrapResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let (output_tx, output_rx) = new_inter_stage_channel(None); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | [INFO] [stdout] 18 | let handle = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok((handle, output_rx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/selection.rs:243:12 [INFO] [stdout] | [INFO] [stdout] 230 | fn bootstrap(&self, input: StageReceiver) -> PartialBootstrapResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | let (output_tx, output_rx) = new_inter_stage_channel(None); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | [INFO] [stdout] 233 | let check = self.check.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | [INFO] [stdout] 235 | let handle = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | Ok((handle, output_rx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sinks/assert/setup.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 20 | fn bootstrap(&self, input: StageReceiver) -> BootstrapResult { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let utils = self.utils.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | assertion_loop(input, config, utils).expect("assertion loop failed") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/n2c/run.rs:137:60 [INFO] [stdout] | [INFO] [stdout] 137 | .map_err(|x| AttemptError::Recoverable(x.into()))?; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/n2c/run.rs:246:18 [INFO] [stdout] | [INFO] [stdout] 246 | || match do_chainsync_attempt(config, utils.clone(), &output_tx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/n2c/setup.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 50 | let (output_tx, output_rx) = new_inter_stage_channel(None); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let utils = self.utils.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let handle = std::thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok((handle, output_rx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/n2c/setup.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 50 | let (output_tx, output_rx) = new_inter_stage_channel(None); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let utils = self.utils.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let handle = std::thread::spawn(move || { [INFO] [stdout] 55 | do_chainsync(&config, utils, output_tx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/n2n/run.rs:128:60 [INFO] [stdout] | [INFO] [stdout] 128 | .map_err(|x| AttemptError::Recoverable(x.into()))?; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ChainState` is never constructed [INFO] [stdout] --> src/utils/metrics.rs:26:19 [INFO] [stdout] | [INFO] [stdout] 26 | pub(crate) struct ChainState { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ChainState` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/n2n/run.rs:272:18 [INFO] [stdout] | [INFO] [stdout] 272 | || match do_chainsync_attempt(config, utils.clone(), &output_tx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/n2n/setup.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 50 | let (output_tx, output_rx) = new_inter_stage_channel(None); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let utils = self.utils.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let handle = std::thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok((handle, output_rx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/n2n/setup.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 50 | let (output_tx, output_rx) = new_inter_stage_channel(None); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let utils = self.utils.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let handle = std::thread::spawn(move || { [INFO] [stdout] 55 | do_chainsync(&config, utils, output_tx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:198:22 [INFO] [stdout] | [INFO] [stdout] 194 | pub fn with_metrics(self, config: metrics::Config) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | let provider = metrics::Provider::initialize(&config).expect("metric server started"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | metrics: provider.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:224:20 [INFO] [stdout] | [INFO] [stdout] 221 | pub fn attach_utils_to(&self, target: T) -> WithUtils { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | utils: self.utils.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/noop.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 15 | fn bootstrap(&self, input: StageReceiver) -> PartialBootstrapResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let (output_tx, output_rx) = new_inter_stage_channel(None); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | [INFO] [stdout] 18 | let handle = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok((handle, output_rx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters/selection.rs:243:12 [INFO] [stdout] | [INFO] [stdout] 230 | fn bootstrap(&self, input: StageReceiver) -> PartialBootstrapResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | let (output_tx, output_rx) = new_inter_stage_channel(None); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | [INFO] [stdout] 233 | let check = self.check.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | [INFO] [stdout] 235 | let handle = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | Ok((handle, output_rx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sinks/assert/setup.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 20 | fn bootstrap(&self, input: StageReceiver) -> BootstrapResult { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let utils = self.utils.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | assertion_loop(input, config, utils).expect("assertion loop failed") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/n2c/run.rs:137:60 [INFO] [stdout] | [INFO] [stdout] 137 | .map_err(|x| AttemptError::Recoverable(x.into()))?; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/n2c/run.rs:246:18 [INFO] [stdout] | [INFO] [stdout] 246 | || match do_chainsync_attempt(config, utils.clone(), &output_tx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/n2c/setup.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 50 | let (output_tx, output_rx) = new_inter_stage_channel(None); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let utils = self.utils.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let handle = std::thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok((handle, output_rx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/n2c/setup.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 50 | let (output_tx, output_rx) = new_inter_stage_channel(None); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let utils = self.utils.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let handle = std::thread::spawn(move || { [INFO] [stdout] 55 | do_chainsync(&config, utils, output_tx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/n2n/run.rs:128:60 [INFO] [stdout] | [INFO] [stdout] 128 | .map_err(|x| AttemptError::Recoverable(x.into()))?; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/n2n/run.rs:272:18 [INFO] [stdout] | [INFO] [stdout] 272 | || match do_chainsync_attempt(config, utils.clone(), &output_tx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/n2n/setup.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 50 | let (output_tx, output_rx) = new_inter_stage_channel(None); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let utils = self.utils.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let handle = std::thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok((handle, output_rx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/n2n/setup.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 50 | let (output_tx, output_rx) = new_inter_stage_channel(None); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let utils = self.utils.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let handle = std::thread::spawn(move || { [INFO] [stdout] 55 | do_chainsync(&config, utils, output_tx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oura` (lib test) due to 14 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 13 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oura` (lib) due to 14 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "48c54b1b23dbe27b288706616cb9f13f6433fdd1d48a9fddb8a3c8a866958c9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48c54b1b23dbe27b288706616cb9f13f6433fdd1d48a9fddb8a3c8a866958c9b", kill_on_drop: false }` [INFO] [stdout] 48c54b1b23dbe27b288706616cb9f13f6433fdd1d48a9fddb8a3c8a866958c9b