[INFO] fetching crate otter-sql 0.1.2... [INFO] checking otter-sql-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate otter-sql 0.1.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate otter-sql 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate otter-sql 0.1.2 [INFO] finished tweaking crates.io crate otter-sql 0.1.2 [INFO] tweaked toml for crates.io crate otter-sql 0.1.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 43 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding fmt-derive v0.0.5 (latest: v0.1.2) [INFO] [stderr] Adding fmt-derive-proc v0.0.5 (latest: v0.1.2) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding ordered-float v3.9.2 (latest: v4.2.2) [INFO] [stderr] Adding papergrid v0.7.1 (latest: v0.12.0) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (latest: v3.2.0) [INFO] [stderr] Adding sqlparser v0.18.0 (latest: v0.50.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tabled v0.10.0 (latest: v0.16.0) [INFO] [stderr] Adding tabled_derive v0.5.0 (latest: v0.8.0) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3a1612eacfb9801824834f9037a6dd83867678a3bacf12204e074668e871ab6b [INFO] running `Command { std: "docker" "start" "-a" "3a1612eacfb9801824834f9037a6dd83867678a3bacf12204e074668e871ab6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3a1612eacfb9801824834f9037a6dd83867678a3bacf12204e074668e871ab6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a1612eacfb9801824834f9037a6dd83867678a3bacf12204e074668e871ab6b", kill_on_drop: false }` [INFO] [stdout] 3a1612eacfb9801824834f9037a6dd83867678a3bacf12204e074668e871ab6b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8da0c5baa3ce34bdc3ff229d8e853ba5aa249295441cd80e0f1d5532fe3756f1 [INFO] running `Command { std: "docker" "start" "-a" "8da0c5baa3ce34bdc3ff229d8e853ba5aa249295441cd80e0f1d5532fe3756f1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking permutation v0.4.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking papergrid v0.7.1 [INFO] [stderr] Checking sqlparser v0.18.0 [INFO] [stderr] Checking arraystring v0.3.0 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking ordered-float v3.9.2 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling tabled_derive v0.5.0 [INFO] [stderr] Compiling fmt-derive-proc v0.0.5 [INFO] [stderr] Checking tabled v0.10.0 [INFO] [stderr] Checking fmt-derive v0.0.5 [INFO] [stderr] Checking otter-sql v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: value assigned to `current_reg` is never read [INFO] [stdout] --> src/codegen.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | current_reg = current_reg.next_index(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `current_reg` is never read [INFO] [stdout] --> src/codegen.rs:288:25 [INFO] [stdout] | [INFO] [stdout] 288 | current_reg = current_reg.next_index(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_register`, `table`, and `drop_table` are never used [INFO] [stdout] --> src/vm.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 62 | impl VirtualMachine { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 78 | fn get_register(&mut self, index: &RegisterIndex) -> Option<&Register> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 100 | fn table(&self, index: &TableIndex) -> Option<&Table> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 108 | fn drop_table(&mut self, index: &TableIndex) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 50 | let ast = parse(code)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | Ok(ast [INFO] [stdout] | ________^ [INFO] [stdout] 52 | | .into_iter() [INFO] [stdout] 53 | | .map(|stmt| codegen_ast(&stmt)) [INFO] [stdout] 54 | | .collect::, CodegenError>>()?) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen.rs:429:8 [INFO] [stdout] | [INFO] [stdout] 59 | let mut instrs = Vec::::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 429 | Ok(IntermediateCode { instrs }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:457:23 [INFO] [stdout] | [INFO] [stdout] 457 | match self.find_table(schema, name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `otter-sql` (lib) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: value assigned to `current_reg` is never read [INFO] [stdout] --> src/codegen.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | current_reg = current_reg.next_index(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `current_reg` is never read [INFO] [stdout] --> src/codegen.rs:288:25 [INFO] [stdout] | [INFO] [stdout] 288 | current_reg = current_reg.next_index(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_register` and `drop_table` are never used [INFO] [stdout] --> src/vm.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 62 | impl VirtualMachine { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 78 | fn get_register(&mut self, index: &RegisterIndex) -> Option<&Register> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 108 | fn drop_table(&mut self, index: &TableIndex) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 50 | let ast = parse(code)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | Ok(ast [INFO] [stdout] | ________^ [INFO] [stdout] 52 | | .into_iter() [INFO] [stdout] 53 | | .map(|stmt| codegen_ast(&stmt)) [INFO] [stdout] 54 | | .collect::, CodegenError>>()?) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen.rs:429:8 [INFO] [stdout] | [INFO] [stdout] 59 | let mut instrs = Vec::::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 429 | Ok(IntermediateCode { instrs }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:457:23 [INFO] [stdout] | [INFO] [stdout] 457 | match self.find_table(schema, name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:1016:13 [INFO] [stdout] | [INFO] [stdout] 991 | let mut vm = VirtualMachine::default(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 992 | let _res = check_single_statement( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1016 | table.columns().cloned().collect::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `otter-sql` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8da0c5baa3ce34bdc3ff229d8e853ba5aa249295441cd80e0f1d5532fe3756f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8da0c5baa3ce34bdc3ff229d8e853ba5aa249295441cd80e0f1d5532fe3756f1", kill_on_drop: false }` [INFO] [stdout] 8da0c5baa3ce34bdc3ff229d8e853ba5aa249295441cd80e0f1d5532fe3756f1