[INFO] fetching crate osu-db 0.3.0... [INFO] checking osu-db-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate osu-db 0.3.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate osu-db 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate osu-db 0.3.0 [INFO] finished tweaking crates.io crate osu-db 0.3.0 [INFO] tweaked toml for crates.io crate osu-db 0.3.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 44 packages to latest compatible versions [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 72d5da95f325ece0e24d0d451775832b5d6f9302daa164038c1ecb16c57aa261 [INFO] running `Command { std: "docker" "start" "-a" "72d5da95f325ece0e24d0d451775832b5d6f9302daa164038c1ecb16c57aa261", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "72d5da95f325ece0e24d0d451775832b5d6f9302daa164038c1ecb16c57aa261", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "72d5da95f325ece0e24d0d451775832b5d6f9302daa164038c1ecb16c57aa261", kill_on_drop: false }` [INFO] [stdout] 72d5da95f325ece0e24d0d451775832b5d6f9302daa164038c1ecb16c57aa261 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0f75cfdfe346bb44fafa8d91f27766d58e0f0770cc063b283709670f2aa67fa4 [INFO] running `Command { std: "docker" "start" "-a" "0f75cfdfe346bb44fafa8d91f27766d58e0f0770cc063b283709670f2aa67fa4", kill_on_drop: false }` [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Checking osu-db v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/lib.rs:245:21 [INFO] [stdout] | [INFO] [stdout] 245 | let epoch = Utc.ymd(1, 1, 1).and_hms(0, 0, 0); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::Date::::and_hms`: Use and_hms_opt() instead [INFO] [stdout] --> src/lib.rs:245:34 [INFO] [stdout] | [INFO] [stdout] 245 | let epoch = Utc.ymd(1, 1, 1).and_hms(0, 0, 0); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/lib.rs:256:21 [INFO] [stdout] | [INFO] [stdout] 256 | let epoch = Utc.ymd(1, 1, 1).and_hms(0, 0, 0); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::Date::::and_hms`: Use and_hms_opt() instead [INFO] [stdout] --> src/lib.rs:256:34 [INFO] [stdout] | [INFO] [stdout] 256 | let epoch = Utc.ymd(1, 1, 1).and_hms(0, 0, 0); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/lib.rs:245:21 [INFO] [stdout] | [INFO] [stdout] 245 | let epoch = Utc.ymd(1, 1, 1).and_hms(0, 0, 0); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::Date::::and_hms`: Use and_hms_opt() instead [INFO] [stdout] --> src/lib.rs:245:34 [INFO] [stdout] | [INFO] [stdout] 245 | let epoch = Utc.ymd(1, 1, 1).and_hms(0, 0, 0); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/lib.rs:256:21 [INFO] [stdout] | [INFO] [stdout] 256 | let epoch = Utc.ymd(1, 1, 1).and_hms(0, 0, 0); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::Date::::and_hms`: Use and_hms_opt() instead [INFO] [stdout] --> src/lib.rs:256:34 [INFO] [stdout] | [INFO] [stdout] 256 | let epoch = Utc.ymd(1, 1, 1).and_hms(0, 0, 0); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_bit_range` is never used [INFO] [stdout] --> src/lib.rs:177:8 [INFO] [stdout] | [INFO] [stdout] 173 | trait Bit { [INFO] [stdout] | --- method in this trait [INFO] [stdout] ... [INFO] [stdout] 177 | fn set_bit_range(&mut self, pos: ops::Range, val: Self); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection.rs:33:24 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn to_file>(&self, path: P) -> io::Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | self.to_writer(BufWriter::new(File::create(path)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/listing.rs:55:24 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn save>(&self, path: P) -> io::Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | self.to_writer(BufWriter::new(File::create(path)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replay.rs:99:24 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn save>(&self, path: P, compression_level: Option) -> io::Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | self.to_writer(BufWriter::new(File::create(path)?), compression_level) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/score.rs:33:24 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn save>(&self, path: P) -> io::Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | self.to_writer(BufWriter::new(File::create(path)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `osu-db` (lib test) due to 5 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `set_bit_range` is never used [INFO] [stdout] --> src/lib.rs:177:8 [INFO] [stdout] | [INFO] [stdout] 173 | trait Bit { [INFO] [stdout] | --- method in this trait [INFO] [stdout] ... [INFO] [stdout] 177 | fn set_bit_range(&mut self, pos: ops::Range, val: Self); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection.rs:33:24 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn to_file>(&self, path: P) -> io::Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | self.to_writer(BufWriter::new(File::create(path)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/listing.rs:55:24 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn save>(&self, path: P) -> io::Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | self.to_writer(BufWriter::new(File::create(path)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replay.rs:99:24 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn save>(&self, path: P, compression_level: Option) -> io::Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | self.to_writer(BufWriter::new(File::create(path)?), compression_level) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/score.rs:33:24 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn save>(&self, path: P) -> io::Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | self.to_writer(BufWriter::new(File::create(path)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `osu-db` (lib) due to 5 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0f75cfdfe346bb44fafa8d91f27766d58e0f0770cc063b283709670f2aa67fa4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f75cfdfe346bb44fafa8d91f27766d58e0f0770cc063b283709670f2aa67fa4", kill_on_drop: false }` [INFO] [stdout] 0f75cfdfe346bb44fafa8d91f27766d58e0f0770cc063b283709670f2aa67fa4