[INFO] fetching crate osmnodecache 0.8.4... [INFO] checking osmnodecache-0.8.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate osmnodecache 0.8.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate osmnodecache 0.8.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate osmnodecache 0.8.4 [INFO] finished tweaking crates.io crate osmnodecache 0.8.4 [INFO] tweaked toml for crates.io crate osmnodecache 0.8.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 79 packages to latest compatible versions [INFO] [stderr] Adding dashmap v5.5.3 (latest: v6.0.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding memmap2 v0.5.10 (latest: v0.9.4) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding which v4.4.2 (latest: v6.0.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0fc888de93dccfb2c8af8ae528f755f24729ad9bdcb3765c3621c03ee399ba69 [INFO] running `Command { std: "docker" "start" "-a" "0fc888de93dccfb2c8af8ae528f755f24729ad9bdcb3765c3621c03ee399ba69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0fc888de93dccfb2c8af8ae528f755f24729ad9bdcb3765c3621c03ee399ba69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0fc888de93dccfb2c8af8ae528f755f24729ad9bdcb3765c3621c03ee399ba69", kill_on_drop: false }` [INFO] [stdout] 0fc888de93dccfb2c8af8ae528f755f24729ad9bdcb3765c3621c03ee399ba69 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 60024954ee8f3856373605fc24e99ec7909bbf9dbcf4f49a85aa76ac01417244 [INFO] running `Command { std: "docker" "start" "-a" "60024954ee8f3856373605fc24e99ec7909bbf9dbcf4f49a85aa76ac01417244", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling protobuf v3.5.1 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling fastrand v2.1.1 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking protobuf-support v3.5.1 [INFO] [stderr] Compiling cargo-husky v1.5.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking osmnodecache v0.8.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dense_file.rs:116:8 [INFO] [stdout] | [INFO] [stdout] 104 | let file = open_cache_file(opts.filename.as_ref())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | Ok(unsafe { MmapMut::map_mut(&file)? }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dense_file.rs:126:6 [INFO] [stdout] | [INFO] [stdout] 120 | let mm = memmap.read().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | (Some(mm), raw_data) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dense_file.rs:172:18 [INFO] [stdout] | [INFO] [stdout] 171 | let (mm_setter, raw_data) = lock_and_link(&self.memmap); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | Box::new(CacheWriter { [INFO] [stdout] | __________________^ [INFO] [stdout] 173 | | parent: self, [INFO] [stdout] 174 | | mm_setter, [INFO] [stdout] 175 | | raw_data, [INFO] [stdout] 176 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hashmap.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 16 | fn open_for_read>(filename: P) -> OsmNodeCacheResult> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Ok(BufReader::new(File::open(filename)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hashmap.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 20 | fn open_for_write>(filename: P) -> OsmNodeCacheResult> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(BufWriter::new(open_cache_file(filename)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hashmap.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn from_json>(filename: P) -> OsmNodeCacheResult { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | data: Arc::new(serde_json::from_reader(open_for_read(filename)?)?), [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hashmap.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn from_bin>(filename: P) -> OsmNodeCacheResult { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 45 | | data: Arc::new(bincode::deserialize_from(open_for_read(filename)?)?), [INFO] [stdout] 46 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `osmnodecache` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "60024954ee8f3856373605fc24e99ec7909bbf9dbcf4f49a85aa76ac01417244", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60024954ee8f3856373605fc24e99ec7909bbf9dbcf4f49a85aa76ac01417244", kill_on_drop: false }` [INFO] [stdout] 60024954ee8f3856373605fc24e99ec7909bbf9dbcf4f49a85aa76ac01417244