[INFO] fetching crate osmium-libs-lsp-server-wrapper 0.1.0... [INFO] checking osmium-libs-lsp-server-wrapper-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate osmium-libs-lsp-server-wrapper 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate osmium-libs-lsp-server-wrapper 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate osmium-libs-lsp-server-wrapper 0.1.0 [INFO] finished tweaking crates.io crate osmium-libs-lsp-server-wrapper 0.1.0 [INFO] tweaked toml for crates.io crate osmium-libs-lsp-server-wrapper 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 31 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding lsp-types v0.94.1 (latest: v0.97.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 124fbd35901426b656dfe54108ec11f4f81a5fea7f8efcb7a6d478003e075f85 [INFO] running `Command { std: "docker" "start" "-a" "124fbd35901426b656dfe54108ec11f4f81a5fea7f8efcb7a6d478003e075f85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "124fbd35901426b656dfe54108ec11f4f81a5fea7f8efcb7a6d478003e075f85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "124fbd35901426b656dfe54108ec11f4f81a5fea7f8efcb7a6d478003e075f85", kill_on_drop: false }` [INFO] [stdout] 124fbd35901426b656dfe54108ec11f4f81a5fea7f8efcb7a6d478003e075f85 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 64c31f44f0e32ea827a6c734adc218196ef7cab8f81a03f060c3983f0d8eac37 [INFO] running `Command { std: "docker" "start" "-a" "64c31f44f0e32ea827a6c734adc218196ef7cab8f81a03f060c3983f0d8eac37", kill_on_drop: false }` [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking lsp-server v0.7.6 [INFO] [stderr] Checking lsp-types v0.94.1 [INFO] [stderr] Checking osmium-libs-lsp-server-wrapper v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `ErrorCode` [INFO] [stdout] --> src/jsonrpc.rs:4:30 [INFO] [stdout] | [INFO] [stdout] 4 | pub use self::error::{Error, ErrorCode, Result}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ErrorCode` [INFO] [stdout] --> src/jsonrpc.rs:4:30 [INFO] [stdout] | [INFO] [stdout] 4 | pub use self::error::{Error, ErrorCode, Result}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:165:15 [INFO] [stdout] | [INFO] [stdout] 164 | pub fn telemetry_event(&self, data: U) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | match serde_json::to_value(data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:29:24 [INFO] [stdout] | [INFO] [stdout] 27 | let (connection, io_threads) = Connection::stdio(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let client = Rc::new(RefCell::new(Client::new())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Rc::new_cyclic(|me| LspStdioServer { [INFO] [stdout] | ________________________^ [INFO] [stdout] 30 | | inner: InnerLspStdioServer { [INFO] [stdout] 31 | | connection, [INFO] [stdout] 32 | | io_threads, [INFO] [stdout] ... | [INFO] [stdout] 35 | | }, [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:30:20 [INFO] [stdout] | [INFO] [stdout] 27 | let (connection, io_threads) = Connection::stdio(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let client = Rc::new(RefCell::new(Client::new())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Rc::new_cyclic(|me| LspStdioServer { [INFO] [stdout] 30 | inner: InnerLspStdioServer { [INFO] [stdout] | ____________________^ [INFO] [stdout] 31 | | connection, [INFO] [stdout] 32 | | io_threads, [INFO] [stdout] 33 | | client, [INFO] [stdout] 34 | | self_ref: me.clone(), [INFO] [stdout] 35 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:30:20 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(client: Rc>, init: F) -> Self [INFO] [stdout] | --------------------------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let backend = init(client); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | LspService { [INFO] [stdout] 30 | state: Arc::new(ServerState::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(client: Rc>, init: F) -> Self [INFO] [stdout] | --------------------------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let backend = init(client); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | inner: InnerService { [INFO] [stdout] | ____________________^ [INFO] [stdout] 32 | | backend: Arc::new(backend), [INFO] [stdout] 33 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `osmium-libs-lsp-server-wrapper` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:165:15 [INFO] [stdout] | [INFO] [stdout] 164 | pub fn telemetry_event(&self, data: U) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | match serde_json::to_value(data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:29:24 [INFO] [stdout] | [INFO] [stdout] 27 | let (connection, io_threads) = Connection::stdio(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let client = Rc::new(RefCell::new(Client::new())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Rc::new_cyclic(|me| LspStdioServer { [INFO] [stdout] | ________________________^ [INFO] [stdout] 30 | | inner: InnerLspStdioServer { [INFO] [stdout] 31 | | connection, [INFO] [stdout] 32 | | io_threads, [INFO] [stdout] ... | [INFO] [stdout] 35 | | }, [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:30:20 [INFO] [stdout] | [INFO] [stdout] 27 | let (connection, io_threads) = Connection::stdio(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let client = Rc::new(RefCell::new(Client::new())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Rc::new_cyclic(|me| LspStdioServer { [INFO] [stdout] 30 | inner: InnerLspStdioServer { [INFO] [stdout] | ____________________^ [INFO] [stdout] 31 | | connection, [INFO] [stdout] 32 | | io_threads, [INFO] [stdout] 33 | | client, [INFO] [stdout] 34 | | self_ref: me.clone(), [INFO] [stdout] 35 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:30:20 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(client: Rc>, init: F) -> Self [INFO] [stdout] | --------------------------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let backend = init(client); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | LspService { [INFO] [stdout] 30 | state: Arc::new(ServerState::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(client: Rc>, init: F) -> Self [INFO] [stdout] | --------------------------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let backend = init(client); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | inner: InnerService { [INFO] [stdout] | ____________________^ [INFO] [stdout] 32 | | backend: Arc::new(backend), [INFO] [stdout] 33 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `osmium-libs-lsp-server-wrapper` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "64c31f44f0e32ea827a6c734adc218196ef7cab8f81a03f060c3983f0d8eac37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64c31f44f0e32ea827a6c734adc218196ef7cab8f81a03f060c3983f0d8eac37", kill_on_drop: false }` [INFO] [stdout] 64c31f44f0e32ea827a6c734adc218196ef7cab8f81a03f060c3983f0d8eac37