[INFO] fetching crate osmflat 0.1.0... [INFO] checking osmflat-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate osmflat 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate osmflat 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate osmflat 0.1.0 [INFO] finished tweaking crates.io crate osmflat 0.1.0 [INFO] tweaked toml for crates.io crate osmflat 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate osmflat 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 319a4e457c4fa9e90242a721a5ed41e3bd1429f180572f2921e7fe29e8b9b73b [INFO] running `Command { std: "docker" "start" "-a" "319a4e457c4fa9e90242a721a5ed41e3bd1429f180572f2921e7fe29e8b9b73b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "319a4e457c4fa9e90242a721a5ed41e3bd1429f180572f2921e7fe29e8b9b73b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "319a4e457c4fa9e90242a721a5ed41e3bd1429f180572f2921e7fe29e8b9b73b", kill_on_drop: false }` [INFO] [stdout] 319a4e457c4fa9e90242a721a5ed41e3bd1429f180572f2921e7fe29e8b9b73b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c1ad0a59c9a6198d6f109be54106f3e80b1880452e2badfe229cd0576eec36eb [INFO] running `Command { std: "docker" "start" "-a" "c1ad0a59c9a6198d6f109be54106f3e80b1880452e2badfe229cd0576eec36eb", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling syn v1.0.45 [INFO] [stderr] Compiling libc v0.2.79 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling serde_derive v1.0.117 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling serde v1.0.117 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking diff v0.1.12 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Compiling serde_json v1.0.59 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking flatdata v0.5.1 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking smallvec v1.4.2 [INFO] [stderr] Checking svg v0.8.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking osmflat v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking png v0.16.7 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/osmflat_generated.rs:1780:12 [INFO] [stdout] | [INFO] [stdout] 1722 | pub fn open(storage: flatdata::StorageHandle) [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1733 | let resource = extend(storage.read("header", schema::osm::resources::HEADER)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1734 | let header = resource.map(|x| super::osm::Header::from_bytes_slice(x))??; [INFO] [stdout] 1735 | let resource = extend(storage.read("nodes", schema::osm::resources::NODES)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1739 | let resource = extend(storage.read("ways", schema::osm::resources::WAYS)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1743 | let resource = extend(storage.read("relations", schema::osm::resources::RELATIONS)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1749 | let index = extend(storage.read("relation_members_index", &index_schema)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1750 | let data = extend(storage.read("relation_members", schema::osm::resources::RELATION_MEMBERS)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1751 | let result = match (index, data) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1758 | (Ok(_), Err(x)) | (Err(x), Ok(_)) => {return Err(x);} [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1759 | (Err(x), Err(_)) => Err(x), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1763 | let resource = extend(storage.read("tags", schema::osm::resources::TAGS)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1767 | let resource = extend(storage.read("tags_index", schema::osm::resources::TAGS_INDEX)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1771 | let resource = extend(storage.read("nodes_index", schema::osm::resources::NODES_INDEX)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1775 | let resource = extend(storage.read("stringtable", schema::osm::resources::STRINGTABLE)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1780 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1781 | | _storage: storage, [INFO] [stdout] 1782 | | header, [INFO] [stdout] 1783 | | nodes, [INFO] [stdout] ... | [INFO] [stdout] 1790 | | stringtable, [INFO] [stdout] 1791 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/osmflat_generated.rs:1974:12 [INFO] [stdout] | [INFO] [stdout] 1971 | storage: flatdata::StorageHandle, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1974 | Ok(Self { storage }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tags.rs:44:20 [INFO] [stdout] | [INFO] [stdout] 38 | mut predicate: impl FnMut(&[u8], &[u8]) -> bool, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | range.find_map(move |idx| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 45 | | let tag = &tags[tags_index[idx as usize].value() as usize]; [INFO] [stdout] 46 | | let key_block = &strings.as_bytes()[tag.key_idx() as usize..]; [INFO] [stdout] 47 | | let value_block = &strings.as_bytes()[tag.value_idx() as usize..]; [INFO] [stdout] ... | [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `osmflat` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "c1ad0a59c9a6198d6f109be54106f3e80b1880452e2badfe229cd0576eec36eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1ad0a59c9a6198d6f109be54106f3e80b1880452e2badfe229cd0576eec36eb", kill_on_drop: false }` [INFO] [stdout] c1ad0a59c9a6198d6f109be54106f3e80b1880452e2badfe229cd0576eec36eb