[INFO] fetching crate oskr 1.0.0-rc.5... [INFO] checking oskr-1.0.0-rc.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate oskr 1.0.0-rc.5 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate oskr 1.0.0-rc.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate oskr 1.0.0-rc.5 [INFO] finished tweaking crates.io crate oskr 1.0.0-rc.5 [INFO] tweaked toml for crates.io crate oskr 1.0.0-rc.5 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate oskr 1.0.0-rc.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c5dd91607e8728ed1e7a88c7b72a924ed49cd2114328e9e67e949a20e8610d00 [INFO] running `Command { std: "docker" "start" "-a" "c5dd91607e8728ed1e7a88c7b72a924ed49cd2114328e9e67e949a20e8610d00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c5dd91607e8728ed1e7a88c7b72a924ed49cd2114328e9e67e949a20e8610d00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5dd91607e8728ed1e7a88c7b72a924ed49cd2114328e9e67e949a20e8610d00", kill_on_drop: false }` [INFO] [stdout] c5dd91607e8728ed1e7a88c7b72a924ed49cd2114328e9e67e949a20e8610d00 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f8c72234943e1133fe78f81d636d40ed32cdd26a3acd76856434cb324ec45f8 [INFO] running `Command { std: "docker" "start" "-a" "8f8c72234943e1133fe78f81d636d40ed32cdd26a3acd76856434cb324ec45f8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.89 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Checking base64ct v1.4.1 [INFO] [stderr] Checking const-oid v0.7.1 [INFO] [stderr] Checking zeroize v1.5.4 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking pem-rfc7468 v0.3.1 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Checking der v0.5.1 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking tracing-core v0.1.23 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking base16ct v0.1.1 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Compiling crossbeam-queue v0.3.5 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling parking_lot_core v0.9.1 [INFO] [stderr] Compiling async-trait v0.1.52 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling quote v1.0.16 [INFO] [stderr] Checking spki v0.5.4 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking pkcs8 v0.8.0 [INFO] [stderr] Checking raw-cpuid v10.3.0 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking getrandom v0.2.5 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking crossbeam v0.8.1 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Checking async-task v4.2.0 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking ff v0.11.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tracing-subscriber v0.3.9 [INFO] [stderr] Checking group v0.11.0 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking quanta v0.9.3 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking crypto-mac v0.11.1 [INFO] [stderr] Checking crypto-bigint v0.3.2 [INFO] [stderr] Checking sec1 v0.2.1 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking hmac v0.11.0 [INFO] [stderr] Checking signature v1.4.0 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking sha2 v0.10.2 [INFO] [stderr] Checking hdrhistogram v7.5.0 [INFO] [stderr] Checking elliptic-curve v0.11.12 [INFO] [stderr] Checking rfc6979 v0.1.0 [INFO] [stderr] Checking ecdsa v0.13.4 [INFO] [stderr] Checking k256 v0.10.4 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking ctrlc v3.2.1 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling tracing-attributes v0.1.20 [INFO] [stderr] Compiling clap_derive v3.1.4 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking tracing v0.1.32 [INFO] [stderr] Checking clap v3.1.6 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking oskr v1.0.0-rc.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `rx_agent` [INFO] [stdout] --> src/framework/dpdk.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | rx_agent: impl Fn(Self::Address, Self::RxBuffer) + 'static + Send, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_rx_agent` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `view_number` and `pre_prepare` are never read [INFO] [stdout] --> src/protocol/pbft/replica.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 71 | struct LogItem { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 72 | view_number: ViewNumber, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 76 | pre_prepare: SignedMessage, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `QuorumKey` is never constructed [INFO] [stdout] --> src/protocol/pbft/replica.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 88 | struct QuorumKey { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `QuorumKey` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/facade.rs:238:12 [INFO] [stdout] | [INFO] [stdout] 202 | let mut replica_address = Vec::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | let mut multicast_address = None; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 239 | | replica: replica_address, [INFO] [stdout] 240 | | group, [INFO] [stdout] 241 | | multicast: multicast_address, [INFO] [stdout] 242 | | f: n_fault.unwrap(), [INFO] [stdout] 243 | | signing_key: Vec::new(), // fill later [INFO] [stdout] 244 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage.rs:61:21 [INFO] [stdout] | [INFO] [stdout] 59 | fn from(state: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Self { [INFO] [stdout] 61 | shared: state.shared(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage.rs:62:20 [INFO] [stdout] | [INFO] [stdout] 59 | fn from(state: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | state: Mutex::new(state), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 59 | fn from(state: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | submit: Arc::new(Submit { [INFO] [stdout] | _____________________^ [INFO] [stdout] 64 | | stateful_list: SegQueue::new(), [INFO] [stdout] 65 | | stateless_list: SegQueue::new(), [INFO] [stdout] 66 | | will_park_list: ArrayQueue::new(64), // configurable? [INFO] [stdout] 67 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage.rs:68:21 [INFO] [stdout] | [INFO] [stdout] 59 | fn from(state: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | metric: Metric { [INFO] [stdout] | _____________________^ [INFO] [stdout] 69 | | stateful: Latency::new("stateful"), [INFO] [stdout] 70 | | stateless: Latency::new("stateless"), [INFO] [stdout] 71 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage.rs:78:16 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn with_stateful(&self, f: impl FnOnce(&mut StatefulContext<'_, S>)) { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | f(&mut StatefulContext { [INFO] [stdout] | ________________^ [INFO] [stdout] 79 | | state: self.state.lock().unwrap(), [INFO] [stdout] 80 | | submit: self.submit.clone(), [INFO] [stdout] 81 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn with_stateless(&self, f: impl FnOnce(&StatelessContext)) { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | f(&StatelessContext { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | shared: self.shared.clone(), [INFO] [stdout] 87 | | submit: self.submit.clone(), [INFO] [stdout] 88 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn deserialize(reader: impl Read) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | / bincode::DefaultOptions::new() [INFO] [stdout] 50 | | .allow_trailing_bytes() [INFO] [stdout] 51 | | .deserialize_from(reader) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/config.rs:99:28 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn for_shard(config: facade::Config, group_id: usize) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | verifying_key: config [INFO] [stdout] | ____________________________^ [INFO] [stdout] 100 | | .signing_key [INFO] [stdout] 101 | | .iter() [INFO] [stdout] 102 | | .map(|(address, key)| (address.clone(), key.verifying_key())) [INFO] [stdout] 103 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/config.rs:104:20 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn for_shard(config: facade::Config, group_id: usize) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | inner: ConfigInner::Shard(config, group_id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/config.rs:102:40 [INFO] [stdout] | [INFO] [stdout] 102 | .map(|(address, key)| (address.clone(), key.verifying_key())) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/config.rs:110:28 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn for_global(config: facade::Config) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | Self { [INFO] [stdout] 110 | verifying_key: config [INFO] [stdout] | ____________________________^ [INFO] [stdout] 111 | | .signing_key [INFO] [stdout] 112 | | .iter() [INFO] [stdout] 113 | | .map(|(address, key)| (address.clone(), key.verifying_key())) [INFO] [stdout] 114 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/config.rs:115:20 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn for_global(config: facade::Config) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | inner: ConfigInner::Global(config), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/config.rs:113:40 [INFO] [stdout] | [INFO] [stdout] 113 | .map(|(address, key)| (address.clone(), key.verifying_key())) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/hotstuff/message.rs:46:35 [INFO] [stdout] | [INFO] [stdout] 46 | #[derive(Debug, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/pbft/message.rs:7:35 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Debug, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/unreplicated.rs:187:33 [INFO] [stdout] | [INFO] [stdout] 185 | let submit = replica.submit.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | transport.register(replica, move |remote, buffer| { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | submit.stateful(move |replica| replica.receive_buffer(remote, buffer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/unreplicated.rs:202:21 [INFO] [stdout] | [INFO] [stdout] 196 | fn send_reply(&self, remote: T::Address, reply: ReplyMessage) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | / serialize(SignedMessage::sign( [INFO] [stdout] 203 | | reply, [INFO] [stdout] 204 | | replica.config.signing_key(replica), [INFO] [stdout] 205 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framework/busy_poll.rs:24:48 [INFO] [stdout] | [INFO] [stdout] 24 | Self::TASK_TABLE.with(|task_table| task_table.borrow().keys().cloned().collect()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framework/busy_poll.rs:27:52 [INFO] [stdout] | [INFO] [stdout] 27 | Self::TASK_TABLE.with(|task_table| task_table.borrow_mut().remove(&id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framework/busy_poll.rs:32:49 [INFO] [stdout] | [INFO] [stdout] 26 | if let Some(mut task) = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | .with(move |task_table| task_table.borrow_mut().insert(id, task)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framework/busy_poll.rs:47:49 [INFO] [stdout] | [INFO] [stdout] 47 | while Self::TASK_TABLE.with(|task_list| task_list.borrow().len()) > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framework/busy_poll.rs:53:44 [INFO] [stdout] | [INFO] [stdout] 53 | Self::TASK_TABLE.with(|task_table| task_table.borrow_mut().remove(&id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framework/busy_poll.rs:92:35 [INFO] [stdout] | [INFO] [stdout] 87 | fn spawn(task: impl Future + Send + 'static) -> Self::JoinHandle { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let (tx, rx) = oneshot::channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let task = [INFO] [stdout] 92 | Box::pin(async move { tx.send(task.await).map_err(|_| unreachable!()).unwrap() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framework/busy_poll.rs:94:44 [INFO] [stdout] | [INFO] [stdout] 91 | let task = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Self::TASK_TABLE.with(|task_table| task_table.borrow_mut().insert(id, task)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framework/dpdk.rs:232:24 [INFO] [stdout] | [INFO] [stdout] 232 | .map(|arg| CString::new(arg).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 26 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oskr` (lib) due to 27 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `rx_agent` [INFO] [stdout] --> src/simulated.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | rx_agent: impl Fn(Self::Address, Self::RxBuffer) + 'static + Send, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_rx_agent` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rx_agent` [INFO] [stdout] --> src/framework/dpdk.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | rx_agent: impl Fn(Self::Address, Self::RxBuffer) + 'static + Send, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_rx_agent` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `view_number` and `pre_prepare` are never read [INFO] [stdout] --> src/protocol/pbft/replica.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 71 | struct LogItem { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 72 | view_number: ViewNumber, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 76 | pre_prepare: SignedMessage, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `QuorumKey` is never constructed [INFO] [stdout] --> src/protocol/pbft/replica.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 88 | struct QuorumKey { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `QuorumKey` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/facade.rs:238:12 [INFO] [stdout] | [INFO] [stdout] 202 | let mut replica_address = Vec::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | let mut multicast_address = None; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 239 | | replica: replica_address, [INFO] [stdout] 240 | | group, [INFO] [stdout] 241 | | multicast: multicast_address, [INFO] [stdout] 242 | | f: n_fault.unwrap(), [INFO] [stdout] 243 | | signing_key: Vec::new(), // fill later [INFO] [stdout] 244 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulated.rs:176:25 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn new(_config: Config) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | let (tx, rx) = unbounded_channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | recv_table: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulated.rs:177:27 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn new(_config: Config) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | let (tx, rx) = unbounded_channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | filter_table: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulated.rs:281:18 [INFO] [stdout] | [INFO] [stdout] 280 | fn from(state: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | Self(Submit { [INFO] [stdout] | __________________^ [INFO] [stdout] 282 | | shared: state.shared(), [INFO] [stdout] 283 | | state: Arc::new(Mutex::new(state)), [INFO] [stdout] 284 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage.rs:61:21 [INFO] [stdout] | [INFO] [stdout] 59 | fn from(state: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Self { [INFO] [stdout] 61 | shared: state.shared(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage.rs:62:20 [INFO] [stdout] | [INFO] [stdout] 59 | fn from(state: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | state: Mutex::new(state), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 59 | fn from(state: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | submit: Arc::new(Submit { [INFO] [stdout] | _____________________^ [INFO] [stdout] 64 | | stateful_list: SegQueue::new(), [INFO] [stdout] 65 | | stateless_list: SegQueue::new(), [INFO] [stdout] 66 | | will_park_list: ArrayQueue::new(64), // configurable? [INFO] [stdout] 67 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage.rs:68:21 [INFO] [stdout] | [INFO] [stdout] 59 | fn from(state: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | metric: Metric { [INFO] [stdout] | _____________________^ [INFO] [stdout] 69 | | stateful: Latency::new("stateful"), [INFO] [stdout] 70 | | stateless: Latency::new("stateless"), [INFO] [stdout] 71 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage.rs:78:16 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn with_stateful(&self, f: impl FnOnce(&mut StatefulContext<'_, S>)) { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | f(&mut StatefulContext { [INFO] [stdout] | ________________^ [INFO] [stdout] 79 | | state: self.state.lock().unwrap(), [INFO] [stdout] 80 | | submit: self.submit.clone(), [INFO] [stdout] 81 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stage.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn with_stateless(&self, f: impl FnOnce(&StatelessContext)) { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | f(&StatelessContext { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | shared: self.shared.clone(), [INFO] [stdout] 87 | | submit: self.submit.clone(), [INFO] [stdout] 88 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn deserialize(reader: impl Read) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | / bincode::DefaultOptions::new() [INFO] [stdout] 50 | | .allow_trailing_bytes() [INFO] [stdout] 51 | | .deserialize_from(reader) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/config.rs:99:28 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn for_shard(config: facade::Config, group_id: usize) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | verifying_key: config [INFO] [stdout] | ____________________________^ [INFO] [stdout] 100 | | .signing_key [INFO] [stdout] 101 | | .iter() [INFO] [stdout] 102 | | .map(|(address, key)| (address.clone(), key.verifying_key())) [INFO] [stdout] 103 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/config.rs:104:20 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn for_shard(config: facade::Config, group_id: usize) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | inner: ConfigInner::Shard(config, group_id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/config.rs:102:40 [INFO] [stdout] | [INFO] [stdout] 102 | .map(|(address, key)| (address.clone(), key.verifying_key())) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/config.rs:110:28 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn for_global(config: facade::Config) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | Self { [INFO] [stdout] 110 | verifying_key: config [INFO] [stdout] | ____________________________^ [INFO] [stdout] 111 | | .signing_key [INFO] [stdout] 112 | | .iter() [INFO] [stdout] 113 | | .map(|(address, key)| (address.clone(), key.verifying_key())) [INFO] [stdout] 114 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/config.rs:115:20 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn for_global(config: facade::Config) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | inner: ConfigInner::Global(config), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/config.rs:113:40 [INFO] [stdout] | [INFO] [stdout] 113 | .map(|(address, key)| (address.clone(), key.verifying_key())) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/hotstuff/message.rs:46:35 [INFO] [stdout] | [INFO] [stdout] 46 | #[derive(Debug, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/hotstuff/tests.rs:24:54 [INFO] [stdout] | [INFO] [stdout] 16 | let mut transport = Transport::new(config()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let (stop_tx, stop) = oneshot::channel(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | spawn(async move { transport.deliver_until(stop).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/hotstuff/tests.rs:25:71 [INFO] [stdout] | [INFO] [stdout] 21 | let mut client: Client<_, AsyncEcosystem> = Client::register_new(config(), &mut transport); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let request = spawn(async move { client.invoke(b"hello".to_vec()).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/pbft/message.rs:7:35 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Debug, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/pbft/tests.rs:66:40 [INFO] [stdout] | [INFO] [stdout] 66 | .map(|i| Replica::register_new(config(), &mut transport, i, App::default(), 1, false)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/pbft/tests.rs:74:54 [INFO] [stdout] | [INFO] [stdout] 64 | let mut transport = Transport::new(config()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | let (stop_tx, stop) = oneshot::channel(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | spawn(async move { transport.deliver_until(stop).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/pbft/tests.rs:90:40 [INFO] [stdout] | [INFO] [stdout] 90 | .map(|i| Replica::register_new(config(), &mut transport, i, App::default(), 1, false)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/pbft/tests.rs:93:39 [INFO] [stdout] | [INFO] [stdout] 93 | .map(|_| Client::register_new(config(), &mut transport)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/pbft/tests.rs:100:19 [INFO] [stdout] | [INFO] [stdout] 99 | .map(|(i, mut client)| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | spawn(async move { [INFO] [stdout] | ___________________^ [INFO] [stdout] 101 | | assert_eq!( [INFO] [stdout] 102 | | client.invoke(format!("client-{}", i).into()).await, [INFO] [stdout] 103 | | Opaque::from(format!("reply: client-{}", i)) [INFO] [stdout] 104 | | ); [INFO] [stdout] 105 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/pbft/tests.rs:110:54 [INFO] [stdout] | [INFO] [stdout] 88 | let mut transport = Transport::new(config()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let (stop_tx, stop) = oneshot::channel(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | spawn(async move { transport.deliver_until(stop).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/unreplicated.rs:187:33 [INFO] [stdout] | [INFO] [stdout] 185 | let submit = replica.submit.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | transport.register(replica, move |remote, buffer| { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | submit.stateful(move |replica| replica.receive_buffer(remote, buffer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/unreplicated.rs:202:21 [INFO] [stdout] | [INFO] [stdout] 196 | fn send_reply(&self, remote: T::Address, reply: ReplyMessage) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | / serialize(SignedMessage::sign( [INFO] [stdout] 203 | | reply, [INFO] [stdout] 204 | | replica.config.signing_key(replica), [INFO] [stdout] 205 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/unreplicated.rs:260:58 [INFO] [stdout] | [INFO] [stdout] 254 | let mut transport = Transport::new(config()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | let (stop_tx, stop) = oneshot::channel(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | spawn(async move { transport.deliver_until(stop).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/unreplicated.rs:280:58 [INFO] [stdout] | [INFO] [stdout] 274 | let mut transport = Transport::new(config()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | let (stop_tx, stop) = oneshot::channel(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | spawn(async move { transport.deliver_until(stop).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framework/busy_poll.rs:24:48 [INFO] [stdout] | [INFO] [stdout] 24 | Self::TASK_TABLE.with(|task_table| task_table.borrow().keys().cloned().collect()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framework/busy_poll.rs:27:52 [INFO] [stdout] | [INFO] [stdout] 27 | Self::TASK_TABLE.with(|task_table| task_table.borrow_mut().remove(&id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framework/busy_poll.rs:32:49 [INFO] [stdout] | [INFO] [stdout] 26 | if let Some(mut task) = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | .with(move |task_table| task_table.borrow_mut().insert(id, task)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framework/busy_poll.rs:47:49 [INFO] [stdout] | [INFO] [stdout] 47 | while Self::TASK_TABLE.with(|task_list| task_list.borrow().len()) > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framework/busy_poll.rs:53:44 [INFO] [stdout] | [INFO] [stdout] 53 | Self::TASK_TABLE.with(|task_table| task_table.borrow_mut().remove(&id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framework/busy_poll.rs:92:35 [INFO] [stdout] | [INFO] [stdout] 87 | fn spawn(task: impl Future + Send + 'static) -> Self::JoinHandle { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let (tx, rx) = oneshot::channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let task = [INFO] [stdout] 92 | Box::pin(async move { tx.send(task.await).map_err(|_| unreachable!()).unwrap() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framework/busy_poll.rs:94:44 [INFO] [stdout] | [INFO] [stdout] 91 | let task = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Self::TASK_TABLE.with(|task_table| task_table.borrow_mut().insert(id, task)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framework/dpdk.rs:232:24 [INFO] [stdout] | [INFO] [stdout] 232 | .map(|arg| CString::new(arg).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framework/tokio.rs:24:20 [INFO] [stdout] | [INFO] [stdout] 23 | fn spawn(task: impl Future + Send + 'static) -> Self::JoinHandle { [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | JoinHandle(spawn(task)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 40 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oskr` (lib test) due to 41 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8f8c72234943e1133fe78f81d636d40ed32cdd26a3acd76856434cb324ec45f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f8c72234943e1133fe78f81d636d40ed32cdd26a3acd76856434cb324ec45f8", kill_on_drop: false }` [INFO] [stdout] 8f8c72234943e1133fe78f81d636d40ed32cdd26a3acd76856434cb324ec45f8